Attention is currently required from: Nicholas Sudsgaard, Paul Menzel.
Nico Huber has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/83504?usp=email )
Change subject: southbridge/intel: Use azalia_audio_init() instead of duplicating code ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83504/comment/77055219_e8ae068b?usp... : PS3, Line 12: The southbridge's codect_detect() was written a long time ago and : mentions that it was "not working yet" in the commit message. Therefore, : I believe that the differences was due to it being a rough : implementation and did not follow the specification exactly in some : places (e.g. only using 4 bits for codec_mask instead of 15 bits).
This awfully sounds like you are making excuses for changing the […]
Just digged a little deeper. The BKDG references relate to [1] (except the copy-pasta ones). And the procedure was first corrected in commit 4505948f.
Just to add some background. I think this commit should just go in (without a wrong text wall).
[1] https://www.amd.com/content/dam/amd/en/documents/archived-tech-docs/programm...