Attention is currently required from: Arthur Heymans, Robert Zieba, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67931 )
Change subject: src/drivers: Add SMMBARSTORE driver ......................................................................
Patch Set 1:
(3 comments)
File src/drivers/smmbarstore/Kconfig:
https://review.coreboot.org/c/coreboot/+/67931/comment/26d132a8_38548669 PS1, Line 3: SMMBARSTORE Can you use _? `SMM_BAR_STORE`. Or should it be `SMM_PCI_BAR_STORE`?
File src/drivers/smmbarstore/ramstage.c:
https://review.coreboot.org/c/coreboot/+/67931/comment/af2e846c_64458273 PS1, Line 16: "outb %%al, %%dx" I'm honestly not the biggest fan of having to invoke SMM from ramstage. Arthur just got rid of the code that has to invoke SMM to set the SMBASE.
Can we define a Kconfig `CHIPSET_SMM_STORE`. This will include a `struct chipset_smm_data` into the `struct smm_runtime`. Then the `smm_module_loader` calls `load_chipset_smm_data`, and in smm we can have a public`get_shipset_smm_data` that any module can use.
File src/include/smmbarstore.h:
https://review.coreboot.org/c/coreboot/+/67931/comment/4b87b0fa_3196dd3f PS1, Line 9: enum smmbarstore_type_t {
trailing whitespace
Please fix.
-
Raul Rangel (Code Review)