[S] Change in coreboot[master]: device/xhci: Add struct for capability registers - coreboot-gerrit

5 Mar 2023


      Attention is currently required from: Robert Zieba, Raul Rangel, Karthik Ramasubramanian.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69915 )
Change subject: device/xhci: Add struct for capability registers
......................................................................
Patch Set 13:
(1 comment)
File src/include/device/xhci.h:
https://review.coreboot.org/c/coreboot/+/69915/comment/00b1a4f6_7fd10888 
PS11, Line 109:
...
Does it need to be packed to reflect the exact register structure?
Marking it as packed shouldn't change anything here. The two uint8s and the uint16 will cleanly go into 32 bits, so there shouldn't be any padding. Are you seeing something I don't see?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69915
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If38bfde726bd4e5dd314456f25a2b08acd3cd20c
Gerrit-Change-Number: 69915
Gerrit-PatchSet: 13
Gerrit-Owner: Robert Zieba robertzieba@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Robert Zieba robertzieba@google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Sun, 05 Mar 2023 15:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment