Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74051 )
Change subject: mb/google/corsola: Add support for mipi panel
......................................................................
Patch Set 19:
(3 comments)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74051/comment/17b1f7b5_ad4f53b9
PS19, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Move bridge related functions to panel_ps8640.c and panel_anx7625.
You can take a reference to kukui/panel_{ps8640, anx7625}.c
https://review.coreboot.org/c/coreboot/+/74051/comment/d68770da_54ef6050
PS19, Line 245: return get_panel_description();
return NULL if none of boards is matched.
File src/mainboard/google/corsola/panel_starmie.c:
https://review.coreboot.org/c/coreboot/+/74051/comment/a8060af8_c12c5f9f
PS15, Line 13: mainboard_set_regulator_voltage(MTK_
Done on CB:74341
Oh, I see.
If the regulator's voltage is not adjustable, maybe we should implement it in `mainboard_{enable/disable}_regulator` next time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f079e54f0317ff2f685f0e3834ebd1ceb8e9fcb
Gerrit-Change-Number: 74051
Gerrit-PatchSet: 19
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 03 May 2023 04:00:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment