V Sowmya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41861 )
Change subject: soc/intel/jasperlake: Updat platform.asl to ASL2.0 syntax ......................................................................
soc/intel/jasperlake: Updat platform.asl to ASL2.0 syntax
This change updates platform.asl to use ASL2.0 syntax. This increases the readability of the ASL code.
TEST=Verified using --timeless option to abuild that the resulting coreboot.rom is same as without the ASL2.0 syntax changes for wdoo.
Change-Id: Ie55bcd9ac2ca746c046ebe05140b2ac291fb0459 Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/soc/intel/jasperlake/acpi/platform.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/41861/1
diff --git a/src/soc/intel/jasperlake/acpi/platform.asl b/src/soc/intel/jasperlake/acpi/platform.asl index 7345864..4b01aeb 100644 --- a/src/soc/intel/jasperlake/acpi/platform.asl +++ b/src/soc/intel/jasperlake/acpi/platform.asl @@ -16,5 +16,5 @@ Method (_PIC, 1) { /* Remember the OS' IRQ routing choice. */ - Store (Arg0, PICM) + PICM = Arg0 }
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41861 )
Change subject: soc/intel/jasperlake: Updat platform.asl to ASL2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41861/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41861/1//COMMIT_MSG@7 PS1, Line 7: Updat Update
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41861 )
Change subject: soc/intel/jasperlake: Updat platform.asl to ASL2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Selma Bensaid, Subrata Banik, Arthur Heymans, Alexey Buyanov, Patrick Rudolph, Venkata Krishna Nimmagadda,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41861
to look at the new patch set (#2).
Change subject: soc/intel/jasperlake: Update platform.asl to ASL2.0 syntax ......................................................................
soc/intel/jasperlake: Update platform.asl to ASL2.0 syntax
This change updates platform.asl to use ASL2.0 syntax. This increases the readability of the ASL code.
TEST=Verified using --timeless option to abuild that the resulting coreboot.rom is same as without the ASL2.0 syntax changes for wdoo.
Change-Id: Ie55bcd9ac2ca746c046ebe05140b2ac291fb0459 Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/soc/intel/jasperlake/acpi/platform.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/41861/2
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41861 )
Change subject: soc/intel/jasperlake: Update platform.asl to ASL2.0 syntax ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41861/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41861/1//COMMIT_MSG@7 PS1, Line 7: Updat
Update
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41861 )
Change subject: soc/intel/jasperlake: Update platform.asl to ASL2.0 syntax ......................................................................
soc/intel/jasperlake: Update platform.asl to ASL2.0 syntax
This change updates platform.asl to use ASL2.0 syntax. This increases the readability of the ASL code.
TEST=Verified using --timeless option to abuild that the resulting coreboot.rom is same as without the ASL2.0 syntax changes for wdoo.
Change-Id: Ie55bcd9ac2ca746c046ebe05140b2ac291fb0459 Signed-off-by: V Sowmya v.sowmya@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41861 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/jasperlake/acpi/platform.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/jasperlake/acpi/platform.asl b/src/soc/intel/jasperlake/acpi/platform.asl index 7345864..4b01aeb 100644 --- a/src/soc/intel/jasperlake/acpi/platform.asl +++ b/src/soc/intel/jasperlake/acpi/platform.asl @@ -16,5 +16,5 @@ Method (_PIC, 1) { /* Remember the OS' IRQ routing choice. */ - Store (Arg0, PICM) + PICM = Arg0 }
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41861 )
Change subject: soc/intel/jasperlake: Update platform.asl to ASL2.0 syntax ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4648 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4647 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4646 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4645
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)
-
V Sowmya (Code Review)