Change in coreboot[master]: util/docker: Unify local build targets - coreboot-gerrit

4 Nov 2018


      Martin Roth has posted comments on this change. ( https://review.coreboot.org/29456 )
Change subject: util/docker: Unify local build targets
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29456/1/util/docker/Makefile
File util/docker/Makefile:
https://review.coreboot.org/#/c/29456/1/util/docker/Makefile@105
PS1, Line 105: override
I don't think the override operator is needed.  It just makes it so you can't update it from the command line.  Since it's not defined anywhere else, the makefiles should work fine without it.
-- 
To view, visit https://review.coreboot.org/29456
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9088fb9211726cddc37b17ddf70170c2c382679e
Gerrit-Change-Number: 29456
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Nov 2018 04:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No