Change in coreboot[master]: mb/google/volteer/halvor: Update settings for WiFi/BT functions
Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
mb/google/volteer/halvor: Update settings for WiFi/BT functions
Configure gpio/overridetree settings for WiFi/BT functions. Then WiFi/BT functions are enable on Halvor.
BUG=b:153680359, b:163004808 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that WiFi/BT can scan devices successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I085b192bb768c2c1238f3f857d315502ac10857e --- M src/mainboard/google/volteer/variants/halvor/gpio.c M src/mainboard/google/volteer/variants/halvor/overridetree.cb 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44372/1
diff --git a/src/mainboard/google/volteer/variants/halvor/gpio.c b/src/mainboard/google/volteer/variants/halvor/gpio.c index 2a98688..1cbe62d 100644 --- a/src/mainboard/google/volteer/variants/halvor/gpio.c +++ b/src/mainboard/google/volteer/variants/halvor/gpio.c @@ -23,6 +23,8 @@ PAD_CFG_NF(GPP_A9, NONE, DEEP, NF1), /* A10 : I2S2_RXD ==> I2S1_RXD */ PAD_CFG_NF(GPP_A10, NONE, DEEP, NF1), + /* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A18 : DDSP_HPDB ==> NC */ PAD_NC(GPP_A18, NONE), /* A22 : DDPC_CTRLDATA ==> NC */ @@ -96,6 +98,8 @@ PAD_NC(GPP_F11, NONE), /* F12 : GSXDOUT ==> EN_PP3300_TRACKPAD */ PAD_CFG_GPO(GPP_F12, 1, DEEP), + /* F13 : GSXDOUT ==> WiFi_DISABLE_L */ + PAD_CFG_GPO(GPP_F13, 1, DEEP), /* F14 : GSXDIN ==> NC */ PAD_NC(GPP_F14, NONE), /* F15 : GSXSRESET# ==> NC */ diff --git a/src/mainboard/google/volteer/variants/halvor/overridetree.cb b/src/mainboard/google/volteer/variants/halvor/overridetree.cb index 12e059c..ef4ebb6 100644 --- a/src/mainboard/google/volteer/variants/halvor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/halvor/overridetree.cb @@ -8,7 +8,7 @@ register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used register "usb2_ports[7]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used register "usb2_ports[8]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used - register "usb2_ports[9]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C Not Used
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC0)" # Type-A / Type-C Port 0 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC1)" # Type-A / Type-C Port 1
Frank Wu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
mb/google/volteer/halvor: Update settings for WiFi/BT functions
Configure gpio/overridetree settings for WiFi/BT functions. Then WiFi/BT functions are enable on Halvor.
BUG=b:153680359, b:163004808 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that WiFi/BT can scan devices successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I085b192bb768c2c1238f3f857d315502ac10857e --- M src/mainboard/google/volteer/variants/halvor/gpio.c M src/mainboard/google/volteer/variants/halvor/overridetree.cb 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44372/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44372/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44372/2/src/mainboard/google/voltee... PS2, Line 11: register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C Not Used commnet : reserve for CNVi BT
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44372
to look at the new patch set (#3).
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
mb/google/volteer/halvor: Update settings for WiFi/BT functions
Configure gpio/overridetree settings for WiFi/BT functions. Then WiFi/BT functions are enable on Halvor.
BUG=b:153680359, b:163004808 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that WiFi/BT can scan devices successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I085b192bb768c2c1238f3f857d315502ac10857e --- M src/mainboard/google/volteer/variants/halvor/gpio.c M src/mainboard/google/volteer/variants/halvor/overridetree.cb 2 files changed, 16 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44372/3
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44372/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44372/2/src/mainboard/google/voltee... PS2, Line 11: register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C Not Used
commnet : reserve for CNVi BT
Done
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44372
to look at the new patch set (#4).
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
mb/google/volteer/halvor: Update settings for WiFi/BT functions
Configure gpio/overridetree settings for WiFi/BT functions. Then WiFi/BT functions are enable on Halvor.
BUG=b:153680359, b:163004808 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that WiFi/BT can scan devices successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I085b192bb768c2c1238f3f857d315502ac10857e --- M src/mainboard/google/volteer/variants/halvor/gpio.c M src/mainboard/google/volteer/variants/halvor/overridetree.cb 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44372/4
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 4: Code-Review+2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44372/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44372/4/src/mainboard/google/voltee... PS4, Line 11: usb2_ports[9] am i looking at the right schematics? does USB2_9 exist on UP4?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44372/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/halvor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44372/4/src/mainboard/google/voltee... PS4, Line 11: usb2_ports[9]
am i looking at the right schematics? […]
Please check the EDS we mentioned in issue. This PCH internal route for CNVi.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 4: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44372/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44372/4//COMMIT_MSG@10 PS4, Line 10: enable enabled
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 4: Code-Review+2
LGTM, but this CL can't be submitted until the comment on the commit message is fixed and marked as resolved.
EricR Lai has uploaded a new patch set (#5) to the change originally created by Frank Wu. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
mb/google/volteer/halvor: Update settings for WiFi/BT functions
Configure gpio/overridetree settings for WiFi/BT functions. Then WiFi/BT functions are enabled on Halvor.
BUG=b:153680359, b:163004808 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that WiFi/BT can scan devices successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I085b192bb768c2c1238f3f857d315502ac10857e --- M src/mainboard/google/volteer/variants/halvor/gpio.c M src/mainboard/google/volteer/variants/halvor/overridetree.cb 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44372/5
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44372/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44372/4//COMMIT_MSG@10 PS4, Line 10: enable
enabled
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
Patch Set 5:
Patch Set 4: Code-Review+2
LGTM, but this CL can't be submitted until the comment on the commit message is fixed and marked as resolved.
Done 😊
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44372 )
Change subject: mb/google/volteer/halvor: Update settings for WiFi/BT functions ......................................................................
mb/google/volteer/halvor: Update settings for WiFi/BT functions
Configure gpio/overridetree settings for WiFi/BT functions. Then WiFi/BT functions are enabled on Halvor.
BUG=b:153680359, b:163004808 TEST=FW_NAME=halvor emerge-volteer coreboot chromeos-bootimage Verify that WiFi/BT can scan devices successfully.
Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Change-Id: I085b192bb768c2c1238f3f857d315502ac10857e Reviewed-on: https://review.coreboot.org/c/coreboot/+/44372 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/halvor/gpio.c M src/mainboard/google/volteer/variants/halvor/overridetree.cb 2 files changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved EricR Lai: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/halvor/gpio.c b/src/mainboard/google/volteer/variants/halvor/gpio.c index 2a98688..1cbe62d 100644 --- a/src/mainboard/google/volteer/variants/halvor/gpio.c +++ b/src/mainboard/google/volteer/variants/halvor/gpio.c @@ -23,6 +23,8 @@ PAD_CFG_NF(GPP_A9, NONE, DEEP, NF1), /* A10 : I2S2_RXD ==> I2S1_RXD */ PAD_CFG_NF(GPP_A10, NONE, DEEP, NF1), + /* A13 : PMC_I2C_SCL ==> BT_DISABLE_L */ + PAD_CFG_GPO(GPP_A13, 1, DEEP), /* A18 : DDSP_HPDB ==> NC */ PAD_NC(GPP_A18, NONE), /* A22 : DDPC_CTRLDATA ==> NC */ @@ -96,6 +98,8 @@ PAD_NC(GPP_F11, NONE), /* F12 : GSXDOUT ==> EN_PP3300_TRACKPAD */ PAD_CFG_GPO(GPP_F12, 1, DEEP), + /* F13 : GSXDOUT ==> WiFi_DISABLE_L */ + PAD_CFG_GPO(GPP_F13, 1, DEEP), /* F14 : GSXDIN ==> NC */ PAD_NC(GPP_F14, NONE), /* F15 : GSXSRESET# ==> NC */ diff --git a/src/mainboard/google/volteer/variants/halvor/overridetree.cb b/src/mainboard/google/volteer/variants/halvor/overridetree.cb index 12e059c..c6ac1b7 100644 --- a/src/mainboard/google/volteer/variants/halvor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/halvor/overridetree.cb @@ -8,7 +8,7 @@ register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used register "usb2_ports[7]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used register "usb2_ports[8]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used - register "usb2_ports[9]" = "USB2_PORT_EMPTY" # Type-A / Type-C Not Used + register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Reserve for CNVi BT
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC0)" # Type-A / Type-C Port 0 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC1)" # Type-A / Type-C Port 1
-
Caveh Jalali (Code Review) -
EricR Lai (Code Review)
-
Frank Wu (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)