HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37983 )
Change subject: src: Remove unneeded 'include <arch/io.h>' ......................................................................
src: Remove unneeded 'include <arch/io.h>'
Change-Id: Ie4293094ad703a2d8b68a8c640bd8d9cece2e6e8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/pcengines/apu1/gpio_ftns.c M src/northbridge/intel/pineview/early_init.c M src/northbridge/intel/sandybridge/early_init.c M src/northbridge/intel/x4x/early_init.c M src/soc/amd/picasso/smbus.c M src/soc/amd/stoneyridge/smbus.c M src/soc/intel/broadwell/finalize.c M src/southbridge/amd/agesa/hudson/early_setup.c M src/southbridge/amd/pi/hudson/early_setup.c 9 files changed, 0 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/37983/1
diff --git a/src/mainboard/pcengines/apu1/gpio_ftns.c b/src/mainboard/pcengines/apu1/gpio_ftns.c index bedd15a..4e58d55 100644 --- a/src/mainboard/pcengines/apu1/gpio_ftns.c +++ b/src/mainboard/pcengines/apu1/gpio_ftns.c @@ -15,7 +15,6 @@
#include <stdint.h> #include <amdblocks/acpimmio.h> -#include <arch/io.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include "gpio_ftns.h"
diff --git a/src/northbridge/intel/pineview/early_init.c b/src/northbridge/intel/pineview/early_init.c index aec910c..b5c5ee0 100644 --- a/src/northbridge/intel/pineview/early_init.c +++ b/src/northbridge/intel/pineview/early_init.c @@ -15,7 +15,6 @@ */
#include <console/console.h> -#include <arch/io.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <device/pci.h> diff --git a/src/northbridge/intel/sandybridge/early_init.c b/src/northbridge/intel/sandybridge/early_init.c index 4866558..95fc52d 100644 --- a/src/northbridge/intel/sandybridge/early_init.c +++ b/src/northbridge/intel/sandybridge/early_init.c @@ -17,7 +17,6 @@ */
#include <console/console.h> -#include <arch/io.h> #include <device/mmio.h> #include <device/device.h> #include <device/pci_ops.h> diff --git a/src/northbridge/intel/x4x/early_init.c b/src/northbridge/intel/x4x/early_init.c index f89411e..c9d44fc 100644 --- a/src/northbridge/intel/x4x/early_init.c +++ b/src/northbridge/intel/x4x/early_init.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <arch/io.h> #include <device/pci_ops.h> #include "iomap.h" #if CONFIG(SOUTHBRIDGE_INTEL_I82801GX) diff --git a/src/soc/amd/picasso/smbus.c b/src/soc/amd/picasso/smbus.c index 31457f9..79f09d6 100644 --- a/src/soc/amd/picasso/smbus.c +++ b/src/soc/amd/picasso/smbus.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <stdint.h> #include <console/console.h> #include <amdblocks/acpimmio.h> diff --git a/src/soc/amd/stoneyridge/smbus.c b/src/soc/amd/stoneyridge/smbus.c index 31457f9..79f09d6 100644 --- a/src/soc/amd/stoneyridge/smbus.c +++ b/src/soc/amd/stoneyridge/smbus.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <stdint.h> #include <console/console.h> #include <amdblocks/acpimmio.h> diff --git a/src/soc/intel/broadwell/finalize.c b/src/soc/intel/broadwell/finalize.c index 7866c4c..442a870 100644 --- a/src/soc/intel/broadwell/finalize.c +++ b/src/soc/intel/broadwell/finalize.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <bootstate.h> #include <console/console.h> #include <console/post_codes.h> diff --git a/src/southbridge/amd/agesa/hudson/early_setup.c b/src/southbridge/amd/agesa/hudson/early_setup.c index 84c4299..639a5e8 100644 --- a/src/southbridge/amd/agesa/hudson/early_setup.c +++ b/src/southbridge/amd/agesa/hudson/early_setup.c @@ -17,7 +17,6 @@ #define _HUDSON_EARLY_SETUP_C_
#include <stdint.h> -#include <arch/io.h> #include <device/pci_ops.h> #include <console/console.h> #include <amdblocks/acpimmio.h> diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c index 0e3646b..191a96c 100644 --- a/src/southbridge/amd/pi/hudson/early_setup.c +++ b/src/southbridge/amd/pi/hudson/early_setup.c @@ -18,7 +18,6 @@
#include <assert.h> #include <stdint.h> -#include <arch/io.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <console/console.h>
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37983 )
Change subject: src: Remove unneeded 'include <arch/io.h>' ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37983 )
Change subject: src: Remove unneeded 'include <arch/io.h>' ......................................................................
src: Remove unneeded 'include <arch/io.h>'
Change-Id: Ie4293094ad703a2d8b68a8c640bd8d9cece2e6e8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37983 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/pcengines/apu1/gpio_ftns.c M src/northbridge/intel/pineview/early_init.c M src/northbridge/intel/sandybridge/early_init.c M src/northbridge/intel/x4x/early_init.c M src/soc/amd/picasso/smbus.c M src/soc/amd/stoneyridge/smbus.c M src/soc/intel/broadwell/finalize.c M src/southbridge/amd/agesa/hudson/early_setup.c M src/southbridge/amd/pi/hudson/early_setup.c 9 files changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/mainboard/pcengines/apu1/gpio_ftns.c b/src/mainboard/pcengines/apu1/gpio_ftns.c index bedd15a..4e58d55 100644 --- a/src/mainboard/pcengines/apu1/gpio_ftns.c +++ b/src/mainboard/pcengines/apu1/gpio_ftns.c @@ -15,7 +15,6 @@
#include <stdint.h> #include <amdblocks/acpimmio.h> -#include <arch/io.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include "gpio_ftns.h"
diff --git a/src/northbridge/intel/pineview/early_init.c b/src/northbridge/intel/pineview/early_init.c index aec910c..b5c5ee0 100644 --- a/src/northbridge/intel/pineview/early_init.c +++ b/src/northbridge/intel/pineview/early_init.c @@ -15,7 +15,6 @@ */
#include <console/console.h> -#include <arch/io.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <device/pci.h> diff --git a/src/northbridge/intel/sandybridge/early_init.c b/src/northbridge/intel/sandybridge/early_init.c index 4866558..95fc52d 100644 --- a/src/northbridge/intel/sandybridge/early_init.c +++ b/src/northbridge/intel/sandybridge/early_init.c @@ -17,7 +17,6 @@ */
#include <console/console.h> -#include <arch/io.h> #include <device/mmio.h> #include <device/device.h> #include <device/pci_ops.h> diff --git a/src/northbridge/intel/x4x/early_init.c b/src/northbridge/intel/x4x/early_init.c index f89411e..c9d44fc 100644 --- a/src/northbridge/intel/x4x/early_init.c +++ b/src/northbridge/intel/x4x/early_init.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <arch/io.h> #include <device/pci_ops.h> #include "iomap.h" #if CONFIG(SOUTHBRIDGE_INTEL_I82801GX) diff --git a/src/soc/amd/picasso/smbus.c b/src/soc/amd/picasso/smbus.c index 31457f9..79f09d6 100644 --- a/src/soc/amd/picasso/smbus.c +++ b/src/soc/amd/picasso/smbus.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <stdint.h> #include <console/console.h> #include <amdblocks/acpimmio.h> diff --git a/src/soc/amd/stoneyridge/smbus.c b/src/soc/amd/stoneyridge/smbus.c index 31457f9..79f09d6 100644 --- a/src/soc/amd/stoneyridge/smbus.c +++ b/src/soc/amd/stoneyridge/smbus.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <stdint.h> #include <console/console.h> #include <amdblocks/acpimmio.h> diff --git a/src/soc/intel/broadwell/finalize.c b/src/soc/intel/broadwell/finalize.c index 7866c4c..442a870 100644 --- a/src/soc/intel/broadwell/finalize.c +++ b/src/soc/intel/broadwell/finalize.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <bootstate.h> #include <console/console.h> #include <console/post_codes.h> diff --git a/src/southbridge/amd/agesa/hudson/early_setup.c b/src/southbridge/amd/agesa/hudson/early_setup.c index 84c4299..639a5e8 100644 --- a/src/southbridge/amd/agesa/hudson/early_setup.c +++ b/src/southbridge/amd/agesa/hudson/early_setup.c @@ -17,7 +17,6 @@ #define _HUDSON_EARLY_SETUP_C_
#include <stdint.h> -#include <arch/io.h> #include <device/pci_ops.h> #include <console/console.h> #include <amdblocks/acpimmio.h> diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c index 0e3646b..191a96c 100644 --- a/src/southbridge/amd/pi/hudson/early_setup.c +++ b/src/southbridge/amd/pi/hudson/early_setup.c @@ -18,7 +18,6 @@
#include <assert.h> #include <stdint.h> -#include <arch/io.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <console/console.h>
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)