[M] Change in coreboot[main]: soc/mediatek/mt8196: Add tracker driver

[Xiwen Shao (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Xiwen Shao has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )

Change subject: soc/mediatek/mt8196: Add tracker driver
......................................................................

Patch Set 12: Code-Review+1

(16 comments)

File src/soc/mediatek/common/include/soc/tracker_common.h:

https://review.coreboot.org/c/coreboot/+/84929/comment/5fb4971a_99d58fb5?usp... :
PS9, Line 28: void tracker_dump_data(void);
> why is this necessary ?

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/05d874e6_668cc025?usp... :
PS9, Line 30: #endif
> > `adding a line without newline at end of file` […]

Done

File src/soc/mediatek/common/tracker.c:

https://review.coreboot.org/c/coreboot/+/84929/comment/da0c06b0_b5162d36?usp... :
PS9, Line 14: __weak
> why is this necessary ?

Done

File src/soc/mediatek/mt8196/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/84929/comment/39fe597d_9325822c?usp... :
PS9, Line 20: bootblock-y += tracker.c
> sort

Done

File src/soc/mediatek/mt8196/bootblock.c:

https://review.coreboot.org/c/coreboot/+/84929/comment/81c754d2_ebebb647?usp... :
PS9, Line 9: #include <soc/tracker_common.h>
> sort

Done

File src/soc/mediatek/mt8196/tracker.c:

https://review.coreboot.org/c/coreboot/+/84929/comment/4fb46d0c_ef3852cf?usp... :
PS9, Line 24: AR_TRACK_LOG_OFFSET
> move to next line

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/74ea37c1_02342024?usp... :
PS9, Line 25:
> one tab

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/1c199d7c_d6ff2e33?usp... :
PS9, Line 69: write32
> write32p

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/47d1c711_94e89581?usp... :
PS9, Line 96: read32
> read32 p

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/737b1835_843f9e2e?usp... :
PS9, Line 104: read32
> read32p

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/de07259b_24d38508?usp... :
PS9, Line 105: reg_low
> move to next line, and allign to BIOS_INFO

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/3b1bca50_e17f77d1?usp... :
PS9, Line 106: read32
> read32p

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/a812429c_702df1ce?usp... :
PS9, Line 106: read32
> read32p

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/b4fc0704_0818bfa9?usp... :
PS9, Line 107: read32
> read32p

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/74d1fa49_75222f25?usp... :
PS9, Line 107: read32
> read32p

Done

https://review.coreboot.org/c/coreboot/+/84929/comment/068b9c64_e9fe5acd?usp... :
PS9, Line 115: reg_entry = ((u64)read32((void *)reg_high)) << 32 | read32((void *)reg_low);
             : 			printk(BIOS_INFO, "%#lx:%#x:%#x:%#x:%#x:%#llx\n", reg_low,
             : 					read32((void *)reg_log), read32((void *)reg_id),
             : 					read32((void *)reg_low), read32((void *)reg_high), reg_entry);
> please use read32p

Done