Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Zhaoqing Jiu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86551?usp=email )
Change subject: soc/mediatek/mt8196: Save HW protect temperature to SRAM ......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86551/comment/f72c4855_2b74b990?usp... : PS2, Line 10: after the system suspends and resumes
No, won't affect resume time. We just give a correct value here, not affect logic.
Done
File src/soc/mediatek/mt8196/thermal.c:
https://review.coreboot.org/c/coreboot/+/86551/comment/15c3b6c4_56fad024?usp... : PS2, Line 626: const struct lvts_thermal_controller *tc = &lvts_tscpu_g_tc[i]; : if (tc->ctrl_on_off == CTRL_OFF) : continue;
you can still keep those.
Done
File src/soc/mediatek/mt8196/thermal_sram.c:
https://review.coreboot.org/c/coreboot/+/86551/comment/3d99be48_d4619293?usp... : PS2, Line 10: c
C
Done
https://review.coreboot.org/c/coreboot/+/86551/comment/98f0e762_56dccd0a?usp... : PS2, Line 66: int
uint32_t
Done
https://review.coreboot.org/c/coreboot/+/86551/comment/35c91caf_9da1fe09?usp... : PS2, Line 71: int
`unsigned int` IMO
Done
https://review.coreboot.org/c/coreboot/+/86551/comment/1f10a90a_30de353a?usp... : PS2, Line 71: int
uint32_t
Done
https://review.coreboot.org/c/coreboot/+/86551/comment/f41f3378_c9735ba0?usp... : PS2, Line 74: if ((idx * 4) < THERMAL_REBOOT_MSR_SRAM_LEN) {
If `idx * 4 >= THERMAL_REBOOT_MSR_SRAM_LEN` is an unexpected case, can we use an assertion?
Done