Hello Subrata Banik,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31282
to review the following change.
Change subject: soc/intel/cannonlake: Add CometLake SoC support ......................................................................
soc/intel/cannonlake: Add CometLake SoC support
This patch adds SOC_INTEL_COMETLAKE Kconfig option.
Change-Id: I2b0c269ade84d72cffaf59a0b53e0d6e3a84b835 Signed-off-by: Subrata Banik subrata.banik@intel.com Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/31282/1
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index cd8819d..0fbf864 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -30,6 +30,13 @@ help Intel Whiskeylake support
+config SOC_INTEL_COMETLAKE + bool + default n + select SOC_INTEL_COMMON_CANNONLAKE_BASE + help + Intel Cometlake support + config SOC_INTEL_CANNONLAKE_PCH_H bool default n @@ -265,11 +272,13 @@ config FSP_HEADER_PATH string "Location of FSP headers" default "3rdparty/fsp/CoffeeLakeFspBinPkg/Include/" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + default "3rdparty/fsp/CometLakeFspBinPkg/Include/" if SOC_INTEL_COMETLAKE default "src/vendorcode/intel/fsp/fsp2_0/cannonlake/"
config FSP_FD_PATH string depends on FSP_USE_REPO default "3rdparty/fsp/CoffeeLakeFspBinPkg/Fsp.fd" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + default "3rdparty/fsp/CometLakeFspBinPkg/Fsp.fd" if SOC_INTEL_COMETLAKE
endif
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31282 )
Change subject: soc/intel/cannonlake: Add CometLake SoC support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31282/1/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31282/1/src/soc/intel/cannonlake/Kconfig@275 PS1, Line 275: CometLakeFspBinPkg I think cml fsp headers are not in intelfsp/FSP yet, might need to set default to vendorcode
https://review.coreboot.org/#/c/31282/1/src/soc/intel/cannonlake/Kconfig@282 PS1, Line 282: 3rdparty/fsp/CometLakeFspBinPkg/Fsp.fd not valid for cometlake
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31282 )
Change subject: soc/intel/cannonlake: Add CometLake SoC support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31282/1/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31282/1/src/soc/intel/cannonlake/Kconfig@275 PS1, Line 275: CometLakeFspBinPkg
I think cml fsp headers are not in intelfsp/FSP yet, might need to set default to vendorcode
Currently FSP headers are not in upstream but need to upstream in this directory.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31282 )
Change subject: soc/intel/cannonlake: Add CometLake SoC support ......................................................................
Patch Set 3: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31282 )
Change subject: soc/intel/cannonlake: Add CometLake SoC support ......................................................................
Patch Set 4: Code-Review+2
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31282 )
Change subject: soc/intel/cannonlake: Add CometLake SoC support ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31282 )
Change subject: soc/intel/cannonlake: Add CometLake SoC support ......................................................................
soc/intel/cannonlake: Add CometLake SoC support
This patch adds SOC_INTEL_COMETLAKE Kconfig option.
Change-Id: I2b0c269ade84d72cffaf59a0b53e0d6e3a84b835 Signed-off-by: Subrata Banik subrata.banik@intel.com Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/31282 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Rizwan Qureshi rizwan.qureshi@intel.com Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Rizwan Qureshi: Looks good to me, approved Ronak Kanabar: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 927409d..9796546 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -30,6 +30,13 @@ help Intel Whiskeylake support
+config SOC_INTEL_COMETLAKE + bool + default n + select SOC_INTEL_COMMON_CANNONLAKE_BASE + help + Intel Cometlake support + config SOC_INTEL_CANNONLAKE_PCH_H bool default n @@ -274,6 +281,7 @@ config FSP_HEADER_PATH string "Location of FSP headers" default "3rdparty/fsp/CoffeeLakeFspBinPkg/Include/" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + default "src/vendorcode/intel/fsp/fsp2_0/cometlake/" if SOC_INTEL_COMETLAKE default "src/vendorcode/intel/fsp/fsp2_0/cannonlake/"
config FSP_FD_PATH
-
Aamir Bohra (Code Review) -
Furquan Shaikh (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)
-
Rizwan Qureshi (Code Review)
-
Ronak Kanabar (Code Review)