Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72659 )
Change subject: soc/amd: Use common reset code for PCO, CZN, MDN, PHX & Glinda
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Sure, I can do that. […]
i agree that making possible reverts easier isn't the strongest argument.
not mixing reworks/cleanups with changing behavior would still be good in order to have one patch for one logical change; right now i see two logical changes in one here.
i won't insist too strongly on splitting this into two patches, but would still be nice to have separate patches for the separate logical changes. splitting it between the socs as i suggested first would probably not be the best idea; changing all to use the new functionality without changing the reset type and then changing the reset types for phoenix and glinda (or the other way around; shouldn't really matter) would be a better split
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie05c790573e4e68f3ec91bacffcc7d7efb986d79
Gerrit-Change-Number: 72659
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 02 Feb 2023 23:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment