Attention is currently required from: Bill XIE.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78288?usp=email )
Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS4:
GM45 platforms with or without CONFIG(STATIC_OPTION_TABLE) always performs memory training and store […]
Ah makes sense, so the training cache is only for S3 resume on these platforms. Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78288?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I533e83f3b95f327b0e24f4d750f8812325b7770b
Gerrit-Change-Number: 78288
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Comment-Date: Mon, 09 Oct 2023 16:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-MessageType: comment