Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19372 )
Change subject: soc/intel/common/block: Add Intel common SMBus code ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/#/c/19372/6//COMMIT_MSG Commit Message:
PS6, Line 7: smbus
SMBus [1]
Done
PS6, Line 10: : *Smbus read/write byte APIs : *Common smbus initialization code
Please add at least one space after the bullet points.
Done
https://review.coreboot.org/#/c/19372/6/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/smbus.h:
Line 19: int do_smbus_read_byte(unsigned int smbus_base, unsigned int device,
That’s obvious from the name, so the comment is redundant?
Done
https://review.coreboot.org/#/c/19372/6/src/soc/intel/common/block/smbus/Kco... File src/soc/intel/common/block/smbus/Kconfig:
PS6, Line 4: SMBUS
SMBus
Done
https://review.coreboot.org/#/c/19372/6/src/soc/intel/common/block/smbus/smb... File src/soc/intel/common/block/smbus/smbus.c:
PS6, Line 107: n
Please use a tab. Now idea why this gets always copied.
Done
https://review.coreboot.org/#/c/19372/6/src/soc/intel/common/block/smbus/smb... File src/soc/intel/common/block/smbus/smbuslib.c:
Line 14: */
Please add a blank line between the license and code.
Done
-
Aamir Bohra (Code Review)