Attention is currently required from: Robert Zieba, Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Karthik Ramasubramanian.
Mark Hasemeyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75095 )
Change subject: mb/google/skyrim: Enable DmaProperty on WLAN device
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75095/comment/bd132b92_5797111c
PS2, Line 10: MMIO
I think it is a typo: MMIO -> IOMMU
Thanks, I'll fix the typo. The IOMMU is not able to protect against all attacks:
https://lwn.net/Articles/786558/
cc'd you on the internal bug that sparked this.
Patchset:
PS2:
I am not sure if setting DMA property for WLAN alone is sufficient since other PCIe ports are capabl […]
Agreed. Currently this matches the behavior of other Google mainboards, but we should evaluate all PCIe based ports.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06369a19afa5b881b26f5c1eb243e2db41a9bb36
Gerrit-Change-Number: 75095
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 10 May 2023 15:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment