Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Subrata Banik.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78253?usp=email )
Change subject: mb/google/nissa/var/quandiso: Update SD card GPIO settings
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78253/comment/5cb75f1a_a8ab0788 :
PS3, Line 8:
Why? Please elaborate.
Add more information in comment body and change the title.
File src/mainboard/google/brya/variants/quandiso/gpio.c:
https://review.coreboot.org/c/coreboot/+/78253/comment/e976a04d_00a75a41 :
PS3, Line 93: PAD_CFG_GPO(GPP_H12, 0, DEEP),
This change not match the title. Also you should add the comment body.
Add more information in comment body and change the title.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78253?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad6789d42b9a3f9b979fd481a88cc7d69db2dcfe
Gerrit-Change-Number: 78253
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 06 Oct 2023 06:33:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment