Attention is currently required from: Maciej Pijanowski, Michał Kopeć, Paul Menzel, Tim Crawford.
Michał Żygowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82673?usp=email )
Change subject: mb/novacustom: add V5x0TU board (Meteor Lake)
......................................................................
Patch Set 25:
(2 comments)
File src/mainboard/novacustom/mtl-h/romstage.c:
https://review.coreboot.org/c/coreboot/+/82673/comment/c344cbf2_74140616?usp... :
PS21, Line 13: .rcomp = {
: /* Values for MTL-H DDR5 2R */
: .resistor = 100,
:
: .targets = {70, 30, 25, 25, 25},
: },
You're right, removed.
Done
File src/mainboard/novacustom/mtl-h/romstage.c:
https://review.coreboot.org/c/coreboot/+/82673/comment/32d7a0fb_b3821736?usp... :
PS25, Line 18: .dq_pins_interleaved = false,
No need to initialize the field if its value is 0/false.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82673?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771
Gerrit-Change-Number: 82673
Gerrit-PatchSet: 25
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 24 Jan 2025 11:01:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com