Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85096?usp=email )
Change subject: scripts/update_submodules: Ensure SHA-1 and commit messages align with Linux style ......................................................................
scripts/update_submodules: Ensure SHA-1 and commit messages align with Linux style
- Replaces the abbreviated SHA-1 (`%h`) with the full SHA-1 (`%H`) truncated to 12 characters to ensure consistent length. - Updates the commit message format to include double quotes around commit titles: `commit <12+ chars of sha1> ("<title line>")`.
These changes improve the consistency and readability of auto-generated commit messages for submodule updates.
Change-Id: If62ba4e491b75f3dd3bf526787d608040646bcac Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M util/scripts/update_submodules 1 file changed, 6 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/85096/1
diff --git a/util/scripts/update_submodules b/util/scripts/update_submodules index 9f6c14f..8cbdfb3 100755 --- a/util/scripts/update_submodules +++ b/util/scripts/update_submodules @@ -102,8 +102,8 @@ exit 1 fi
- initial_commit_id="$(git log --pretty='%h' -n 1)" - initial_commit_description="$(git log --pretty='%ci - (%s)' -n 1)" + initial_commit_id="$(git log --pretty='%H' -n 1 | cut -c1-12)" + initial_commit_description="$(git log --pretty='%ci - ("%s")' -n 1)" if [[ ${skip_sync} != "1" ]]; then git fetch 2>/dev/null fi @@ -116,8 +116,8 @@ fi done
- updated_commit_id="$(git log --pretty='%h' -n 1 "${branch_name}" -- )" - updated_commit_description="$(git log --pretty='%ci - (%s)' -n 1 "${updated_commit_id}")" + updated_commit_id="$(git log --pretty='%H' -n 1 "${branch_name}" -- | cut -c1-12)" + updated_commit_description="$(git log --pretty='%ci - ("%s")' -n 1 "${updated_commit_id}")" if [ "${initial_commit_id}" = "${updated_commit_id}" ]; then echo "No updates for ${submodule}" continue @@ -140,11 +140,9 @@ git commit -s -F- > /dev/null 2>&1 <<-EOF Update ${submodule##*/} submodule to upstream ${branch##*/}
- Updating from commit id ${initial_commit_id}: - $initial_commit_description + Updating from commit ${initial_commit_id} ("$(echo $initial_commit_description)"):
- to commit id ${updated_commit_id}: - ${updated_commit_description} + to commit ${updated_commit_id} ("$(echo $updated_commit_description)"):
This brings in ${update_count} new commits${new_commit_terminator} ${update_log}