Attention is currently required from: Jamie Ryu, Kapil Porwal, Paul Menzel, Raj Astekar, Tarun Tuli.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75769?usp=email )
Change subject: mb/google/rex: LZ4 compress ramstage instead of LZMA
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75769/comment/9bdc79e8_f568e897 :
PS4, Line 7: change ramstage compression to LZ4
Maybe: […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/75769/comment/1b658a0c_0177dba3 :
PS4, Line 10: 35ms(30-37ms)
Please add a space before the (.
Acknowledged
https://review.coreboot.org/c/coreboot/+/75769/comment/2763e0dc_117b2f1b :
PS4, Line 24:
Thank you adding the data. Could you please also mention the flash ROM chip, that was used.
Windbond 32MB(W25Q256JW_DTR) is used.
https://review.coreboot.org/c/coreboot/+/75769/comment/0d5a69ee_aa5b4636 :
PS4, Line 25: (
Please put the space before the (.
Acknowledged
https://review.coreboot.org/c/coreboot/+/75769/comment/5f7a8f86_fc0b3410 :
PS4, Line 27: 165452
Is that the right value?
Yes, it's from cbfstool output
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6610f405d287bff2eb4eee6f09026e3361405ded
Gerrit-Change-Number: 75769
Gerrit-PatchSet: 5
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 21:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment