HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40013 )
Change subject: src/lib: Update gcov-io.[ch] (test) ......................................................................
src/lib: Update gcov-io.[ch] (test)
Change-Id: Iacdbd3ad563e13aea0718689bc4f6e5ac6a80cfc Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/lib/gcov-io.c M src/lib/gcov-io.h 2 files changed, 524 insertions(+), 645 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40013/1
diff --git a/src/lib/gcov-io.c b/src/lib/gcov-io.c index e142524..213c413 100644 --- a/src/lib/gcov-io.c +++ b/src/lib/gcov-io.c @@ -1,6 +1,5 @@ /* File format for coverage information - Copyright (C) 1996, 1997, 1998, 2000, 2002, 2003, 2004, 2005, 2007, - 2008 Free Software Foundation, Inc. + Copyright (C) 1996-2020 Free Software Foundation, Inc. Contributed by Bob Manson manson@cygnus.com. Completely remangled by Nathan Sidwell nathan@codesourcery.com.
@@ -19,29 +18,96 @@ Under Section 7 of GPL version 3, you are granted additional permissions described in the GCC Runtime Library Exception, version 3.1, as published by the Free Software Foundation. -*/ + +You should have received a copy of the GNU General Public License and +a copy of the GCC Runtime Library Exception along with this program; +see the files COPYING3 and COPYING.RUNTIME respectively. If not, see +http://www.gnu.org/licenses/. */
/* Routines declared in gcov-io.h. This file should be #included by another source file, after having #included gcov-io.h. */
#if !IN_GCOV -static void gcov_write_block(unsigned int); -static gcov_unsigned_t *gcov_write_words(unsigned int); +static void gcov_write_block (unsigned); +static gcov_unsigned_t *gcov_write_words (unsigned); #endif -static const gcov_unsigned_t *gcov_read_words(unsigned int); +static const gcov_unsigned_t *gcov_read_words (unsigned); #if !IN_LIBGCOV -static void gcov_allocate(unsigned int); +static void gcov_allocate (unsigned); #endif
-static inline gcov_unsigned_t from_file(gcov_unsigned_t value) +/* Optimum number of gcov_unsigned_t's read from or written to disk. */ +#define GCOV_BLOCK_SIZE (1 << 10) + +struct gcov_var +{ + FILE *file; + gcov_position_t start; /* Position of first byte of block */ + unsigned offset; /* Read/write position within the block. */ + unsigned length; /* Read limit in the block. */ + unsigned overread; /* Number of words overread. */ + int error; /* < 0 overflow, > 0 disk error. */ + int mode; /* < 0 writing, > 0 reading */ +#if IN_LIBGCOV + /* Holds one block plus 4 bytes, thus all coverage reads & writes + fit within this buffer and we always can transfer GCOV_BLOCK_SIZE + to and from the disk. libgcov never backtracks and only writes 4 + or 8 byte objects. */ + gcov_unsigned_t buffer[GCOV_BLOCK_SIZE + 1]; +#else + int endian; /* Swap endianness. */ + /* Holds a variable length block, as the compiler can write + strings and needs to backtrack. */ + size_t alloc; + gcov_unsigned_t *buffer; +#endif +} gcov_var; + +/* Save the current position in the gcov file. */ +/* We need to expose this function when compiling for gcov-tool. */ +#ifndef IN_GCOV_TOOL +static inline +#endif +gcov_position_t +gcov_position (void) +{ + gcov_nonruntime_assert (gcov_var.mode > 0); + return gcov_var.start + gcov_var.offset; +} + +/* Return nonzero if the error flag is set. */ +/* We need to expose this function when compiling for gcov-tool. */ +#ifndef IN_GCOV_TOOL +static inline +#endif +int +gcov_is_error (void) +{ + return gcov_var.file ? gcov_var.error : 1; +} + +#if IN_LIBGCOV +/* Move to beginning of file and initialize for writing. */ +GCOV_LINKAGE inline void +gcov_rewrite (void) +{ + gcov_var.mode = -1; + gcov_var.start = 0; + gcov_var.offset = 0; + fseek (gcov_var.file, 0L, SEEK_SET); +} +#endif + +static inline gcov_unsigned_t from_file (gcov_unsigned_t value) { #if !IN_LIBGCOV - if (gcov_var.endian) { - value = (value >> 16) | (value << 16); - value = ((value & 0xff00ff) << 8) | ((value >> 8) & 0xff00ff); - } + if (gcov_var.endian) + { + value = (value >> 16) | (value << 16); + value = ((value & 0xff00ff) << 8) | ((value >> 8) & 0xff00ff); + } #endif - return value; + return value; }
/* Open a gcov file. NAME is the name of the file to open and MODE @@ -49,120 +115,111 @@ opened. If MODE is >= 0 an existing file will be opened, if possible, and if MODE is <= 0, a new file will be created. Use MODE=0 to attempt to reopen an existing file and then fall back on - creating a new one. If MODE < 0, the file will be opened in + creating a new one. If MODE > 0, the file will be opened in read-only mode. Otherwise it will be opened for modification. - Return zero on failure, >0 on opening an existing file and <0 on - creating a new one. */ + Return zero on failure, non-zero on success. */
GCOV_LINKAGE int #if IN_LIBGCOV -gcov_open(const char *name) +gcov_open (const char *name) #else -gcov_open(const char *name, int mode) +gcov_open (const char *name, int mode) #endif { #if IN_LIBGCOV - const int mode = 0; + int mode = 0; #endif #if GCOV_LOCKED - struct flock s_flock; - int fd; + struct flock s_flock; + int fd;
- s_flock.l_whence = SEEK_SET; - s_flock.l_start = 0; - s_flock.l_len = 0; /* Until EOF. */ - s_flock.l_pid = getpid(); + s_flock.l_whence = SEEK_SET; + s_flock.l_start = 0; + s_flock.l_len = 0; /* Until EOF. */ + s_flock.l_pid = getpid (); #endif
- gcc_assert(!gcov_var.file); - gcov_var.start = 0; - gcov_var.offset = gcov_var.length = 0; - gcov_var.overread = -1u; - gcov_var.error = 0; + gcov_nonruntime_assert (!gcov_var.file); + gcov_var.start = 0; + gcov_var.offset = gcov_var.length = 0; + gcov_var.overread = -1u; + gcov_var.error = 0; #if !IN_LIBGCOV - gcov_var.endian = 0; + gcov_var.endian = 0; #endif #if GCOV_LOCKED - if (mode > 0) { - /* Read-only mode - acquire a read-lock. */ - s_flock.l_type = F_RDLCK; - fd = open(name, O_RDONLY); - } else { - /* Write mode - acquire a write-lock. */ - s_flock.l_type = F_WRLCK; - fd = open(name, O_RDWR | O_CREAT, 0666); - } - if (fd < 0) - return 0; + if (mode > 0) + { + /* Read-only mode - acquire a read-lock. */ + s_flock.l_type = F_RDLCK; + /* pass mode (ignored) for compatibility */ + fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); + } + else + { + /* Write mode - acquire a write-lock. */ + s_flock.l_type = F_WRLCK; + /* Truncate if force new mode. */ + fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); + } + if (fd < 0) + return 0;
- while (fcntl(fd, F_SETLKW, &s_flock) && errno == EINTR) - continue; + while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) + continue;
- gcov_var.file = fdopen(fd, (mode > 0) ? "rb" : "r+b"); + gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b");
- if (!gcov_var.file) { - close(fd); - return 0; - } - - if (mode > 0) - gcov_var.mode = 1; - else if (mode == 0) { - struct stat st; - - if (fstat(fd, &st) < 0) { - fclose(gcov_var.file); - gcov_var.file = 0; - return 0; - } - if (st.st_size != 0) - gcov_var.mode = 1; - else - gcov_var.mode = mode * 2 + 1; - } else - gcov_var.mode = mode * 2 + 1; + if (!gcov_var.file) + { + close (fd); + return 0; + } #else - if (mode >= 0) - gcov_var.file = fopen(name, (mode > 0) ? "rb" : "r+b"); + if (mode >= 0) + /* Open an existing file. */ + gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b");
- if (gcov_var.file) - gcov_var.mode = 1; - else if (mode <= 0) { - gcov_var.file = fopen(name, "w+b"); - if (gcov_var.file) - gcov_var.mode = mode * 2 + 1; - } - if (!gcov_var.file) - return 0; + if (gcov_var.file) + mode = 1; + else if (mode <= 0) + /* Create a new file. */ + gcov_var.file = fopen (name, "w+b"); + + if (!gcov_var.file) + return 0; #endif
- setbuf(gcov_var.file, (char *)0); + gcov_var.mode = mode ? mode : 1;
- return 1; + setbuf (gcov_var.file, (char *)0); + + return 1; }
/* Close the current gcov file. Flushes data to disk. Returns nonzero on failure or error flag set. */
GCOV_LINKAGE int -gcov_close(void) +gcov_close (void) { - if (gcov_var.file) { + if (gcov_var.file) + { #if !IN_GCOV - if (gcov_var.offset && gcov_var.mode < 0) - gcov_write_block(gcov_var.offset); + if (gcov_var.offset && gcov_var.mode < 0) + gcov_write_block (gcov_var.offset); #endif - fclose(gcov_var.file); - gcov_var.file = 0; - gcov_var.length = 0; - } + fclose (gcov_var.file); + gcov_var.file = 0; + gcov_var.length = 0; + } #if !IN_LIBGCOV - free(gcov_var.buffer); - gcov_var.alloc = 0; - gcov_var.buffer = 0; + free (gcov_var.buffer); + gcov_var.alloc = 0; + gcov_var.buffer = 0; #endif - gcov_var.mode = 0; - return gcov_var.error; + gcov_var.mode = 0; + return gcov_var.error; }
#if !IN_LIBGCOV @@ -171,34 +228,34 @@ not EXPECTED. */
GCOV_LINKAGE int -gcov_magic(gcov_unsigned_t magic, gcov_unsigned_t expected) +gcov_magic (gcov_unsigned_t magic, gcov_unsigned_t expected) { - if (magic == expected) - return 1; - magic = (magic >> 16) | (magic << 16); - magic = ((magic & 0xff00ff) << 8) | ((magic >> 8) & 0xff00ff); - if (magic == expected) { - gcov_var.endian = 1; - return -1; - } - return 0; + if (magic == expected) + return 1; + magic = (magic >> 16) | (magic << 16); + magic = ((magic & 0xff00ff) << 8) | ((magic >> 8) & 0xff00ff); + if (magic == expected) + { + gcov_var.endian = 1; + return -1; + } + return 0; } #endif
#if !IN_LIBGCOV static void -gcov_allocate(unsigned int length) +gcov_allocate (unsigned length) { - size_t new_size = gcov_var.alloc; + size_t new_size = gcov_var.alloc;
- if (!new_size) - new_size = GCOV_BLOCK_SIZE; - new_size += length; - new_size *= 2; + if (!new_size) + new_size = GCOV_BLOCK_SIZE; + new_size += length; + new_size *= 2;
- gcov_var.alloc = new_size; - gcov_var.buffer = XRESIZEVAR(gcov_unsigned_t, gcov_var.buffer, - new_size << 2); + gcov_var.alloc = new_size; + gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); } #endif
@@ -206,51 +263,51 @@ /* Write out the current block, if needs be. */
static void -gcov_write_block(unsigned int size) +gcov_write_block (unsigned size) { - if (fwrite(gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) - gcov_var.error = 1; - gcov_var.start += size; - gcov_var.offset -= size; + if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) + gcov_var.error = 1; + gcov_var.start += size; + gcov_var.offset -= size; }
/* Allocate space to write BYTES bytes to the gcov file. Return a pointer to those bytes, or NULL on failure. */
static gcov_unsigned_t * -gcov_write_words(unsigned int words) +gcov_write_words (unsigned words) { - gcov_unsigned_t *result; + gcov_unsigned_t *result;
- gcc_assert(gcov_var.mode < 0); + gcov_nonruntime_assert (gcov_var.mode < 0); #if IN_LIBGCOV - if (gcov_var.offset >= GCOV_BLOCK_SIZE) { - gcov_write_block(GCOV_BLOCK_SIZE); - if (gcov_var.offset) { - gcc_assert(gcov_var.offset == 1); - memcpy(gcov_var.buffer, gcov_var.buffer - + GCOV_BLOCK_SIZE, 4); - } + if (gcov_var.offset >= GCOV_BLOCK_SIZE) + { + gcov_write_block (GCOV_BLOCK_SIZE); + if (gcov_var.offset) + { + memcpy (gcov_var.buffer, gcov_var.buffer + GCOV_BLOCK_SIZE, 4); } + } #else - if (gcov_var.offset + words > gcov_var.alloc) - gcov_allocate(gcov_var.offset + words); + if (gcov_var.offset + words > gcov_var.alloc) + gcov_allocate (gcov_var.offset + words); #endif - result = &gcov_var.buffer[gcov_var.offset]; - gcov_var.offset += words; + result = &gcov_var.buffer[gcov_var.offset]; + gcov_var.offset += words;
- return result; + return result; }
/* Write unsigned VALUE to coverage file. Sets error flag appropriately. */
GCOV_LINKAGE void -gcov_write_unsigned(gcov_unsigned_t value) +gcov_write_unsigned (gcov_unsigned_t value) { - gcov_unsigned_t *buffer = gcov_write_words(1); + gcov_unsigned_t *buffer = gcov_write_words (1);
- buffer[0] = value; + buffer[0] = value; }
/* Write counter VALUE to coverage file. Sets error flag @@ -258,15 +315,15 @@
#if IN_LIBGCOV GCOV_LINKAGE void -gcov_write_counter(gcov_type value) +gcov_write_counter (gcov_type value) { - gcov_unsigned_t *buffer = gcov_write_words(2); + gcov_unsigned_t *buffer = gcov_write_words (2);
- buffer[0] = (gcov_unsigned_t) value; - if (sizeof(value) > sizeof(gcov_unsigned_t)) - buffer[1] = (gcov_unsigned_t) (value >> 32); - else - buffer[1] = 0; + buffer[0] = (gcov_unsigned_t) value; + if (sizeof (value) > sizeof (gcov_unsigned_t)) + buffer[1] = (gcov_unsigned_t) (value >> 32); + else + buffer[1] = 0; } #endif /* IN_LIBGCOV */
@@ -275,22 +332,59 @@ error, overflow flag on overflow */
GCOV_LINKAGE void -gcov_write_string(const char *string) +gcov_write_string (const char *string) { - unsigned int length = 0; - unsigned int alloc = 0; - gcov_unsigned_t *buffer; + unsigned length = 0; + unsigned alloc = 0; + gcov_unsigned_t *buffer;
- if (string) { - length = strlen(string); - alloc = (length + 4) >> 2; + if (string) + { + length = strlen (string); + alloc = (length + 4) >> 2; + } + + buffer = gcov_write_words (1 + alloc); + + buffer[0] = alloc; + + if (alloc > 0) + { + buffer[alloc] = 0; /* place nul terminators. */ + memcpy (&buffer[1], string, length); + } +} +#endif + +#if !IN_LIBGCOV +/* Write FILENAME to coverage file. Sets error flag on file + error, overflow flag on overflow */ + +GCOV_LINKAGE void +gcov_write_filename (const char *filename) +{ + if (profile_abs_path_flag && filename && filename[0] + && !(IS_DIR_SEPARATOR (filename[0]) +#if HAVE_DOS_BASED_FILE_SYSTEM + || filename[1] == ':' +#endif + )) + { + char *buf = getcwd (NULL, 0); + if (buf != NULL && buf[0]) + { + size_t len = strlen (buf); + buf = (char*)xrealloc (buf, len + strlen (filename) + 2); + if (!IS_DIR_SEPARATOR (buf[len - 1])) + strcat (buf, "/"); + strcat (buf, filename); + gcov_write_string (buf); + free (buf); + return; } + }
- buffer = gcov_write_words(1 + alloc); - - buffer[0] = alloc; - buffer[alloc] = 0; - memcpy(&buffer[1], string, length); + gcov_write_string (filename); } #endif
@@ -299,15 +393,15 @@ value to be used for gcov_write_length. */
GCOV_LINKAGE gcov_position_t -gcov_write_tag(gcov_unsigned_t tag) +gcov_write_tag (gcov_unsigned_t tag) { - gcov_position_t result = gcov_var.start + gcov_var.offset; - gcov_unsigned_t *buffer = gcov_write_words(2); + gcov_position_t result = gcov_var.start + gcov_var.offset; + gcov_unsigned_t *buffer = gcov_write_words (2);
- buffer[0] = tag; - buffer[1] = 0; + buffer[0] = tag; + buffer[1] = 0;
- return result; + return result; }
/* Write a record length using POSITION, which was returned by @@ -316,21 +410,21 @@ overflow. */
GCOV_LINKAGE void -gcov_write_length(gcov_position_t position) +gcov_write_length (gcov_position_t position) { - unsigned int offset; - gcov_unsigned_t length; - gcov_unsigned_t *buffer; + unsigned offset; + gcov_unsigned_t length; + gcov_unsigned_t *buffer;
- gcc_assert(gcov_var.mode < 0); - gcc_assert(position + 2 <= gcov_var.start + gcov_var.offset); - gcc_assert(position >= gcov_var.start); - offset = position - gcov_var.start; - length = gcov_var.offset - offset - 2; - buffer = (gcov_unsigned_t *) &gcov_var.buffer[offset]; - buffer[1] = length; - if (gcov_var.offset >= GCOV_BLOCK_SIZE) - gcov_write_block(gcov_var.offset); + gcov_nonruntime_assert (gcov_var.mode < 0); + gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); + gcov_nonruntime_assert (position >= gcov_var.start); + offset = position - gcov_var.start; + length = gcov_var.offset - offset - 2; + buffer = (gcov_unsigned_t *) &gcov_var.buffer[offset]; + buffer[1] = length; + if (gcov_var.offset >= GCOV_BLOCK_SIZE) + gcov_write_block (gcov_var.offset); }
#else /* IN_LIBGCOV */ @@ -338,33 +432,25 @@ /* Write a tag TAG and length LENGTH. */
GCOV_LINKAGE void -gcov_write_tag_length(gcov_unsigned_t tag, gcov_unsigned_t length) +gcov_write_tag_length (gcov_unsigned_t tag, gcov_unsigned_t length) { - gcov_unsigned_t *buffer = gcov_write_words(2); + gcov_unsigned_t *buffer = gcov_write_words (2);
- buffer[0] = tag; - buffer[1] = length; + buffer[0] = tag; + buffer[1] = length; }
/* Write a summary structure to the gcov file. Return nonzero on overflow. */
GCOV_LINKAGE void -gcov_write_summary(gcov_unsigned_t tag, const struct gcov_summary *summary) +gcov_write_summary (gcov_unsigned_t tag, const struct gcov_summary *summary) { - unsigned int ix; - const struct gcov_ctr_summary *csum; - - gcov_write_tag_length(tag, GCOV_TAG_SUMMARY_LENGTH); - gcov_write_unsigned(summary->checksum); - for (csum = summary->ctrs, ix = GCOV_COUNTERS_SUMMABLE; ix--; csum++) { - gcov_write_unsigned(csum->num); - gcov_write_unsigned(csum->runs); - gcov_write_counter(csum->sum_all); - gcov_write_counter(csum->run_max); - gcov_write_counter(csum->sum_max); - } + gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); + gcov_write_unsigned (summary->runs); + gcov_write_unsigned (summary->sum_max); } + #endif /* IN_LIBGCOV */
#endif /*!IN_GCOV */ @@ -373,132 +459,179 @@ NULL on failure (read past EOF). */
static const gcov_unsigned_t * -gcov_read_words(unsigned int words) +gcov_read_words (unsigned words) { - const gcov_unsigned_t *result; - unsigned int excess = gcov_var.length - gcov_var.offset; + const gcov_unsigned_t *result; + unsigned excess = gcov_var.length - gcov_var.offset;
- gcc_assert(gcov_var.mode > 0); - if (excess < words) { - gcov_var.start += gcov_var.offset; + if (gcov_var.mode <= 0) + return NULL; + + if (excess < words) + { + gcov_var.start += gcov_var.offset; + if (excess) + { #if IN_LIBGCOV - if (excess) { - gcc_assert(excess == 1); - memcpy(gcov_var.buffer, gcov_var.buffer - + gcov_var.offset, 4); - } + memcpy (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, 4); #else - memmove(gcov_var.buffer, gcov_var.buffer - + gcov_var.offset, excess * 4); + memmove (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, + excess * 4); #endif - gcov_var.offset = 0; - gcov_var.length = excess; -#if IN_LIBGCOV - gcc_assert(!gcov_var.length || gcov_var.length == 1); - excess = GCOV_BLOCK_SIZE; -#else - if (gcov_var.length + words > gcov_var.alloc) - gcov_allocate(gcov_var.length + words); - excess = gcov_var.alloc - gcov_var.length; -#endif - excess = fread(gcov_var.buffer + gcov_var.length, - 1, excess << 2, gcov_var.file) >> 2; - gcov_var.length += excess; - if (gcov_var.length < words) { - gcov_var.overread += words - gcov_var.length; - gcov_var.length = 0; - return 0; - } } - result = &gcov_var.buffer[gcov_var.offset]; - gcov_var.offset += words; - return result; + gcov_var.offset = 0; + gcov_var.length = excess; +#if IN_LIBGCOV + excess = GCOV_BLOCK_SIZE; +#else + if (gcov_var.length + words > gcov_var.alloc) + gcov_allocate (gcov_var.length + words); + excess = gcov_var.alloc - gcov_var.length; +#endif + excess = fread (gcov_var.buffer + gcov_var.length, + 1, excess << 2, gcov_var.file) >> 2; + gcov_var.length += excess; + if (gcov_var.length < words) + { + gcov_var.overread += words - gcov_var.length; + gcov_var.length = 0; + return 0; + } + } + result = &gcov_var.buffer[gcov_var.offset]; + gcov_var.offset += words; + return result; }
/* Read unsigned value from a coverage file. Sets error flag on file error, overflow flag on overflow */
GCOV_LINKAGE gcov_unsigned_t -gcov_read_unsigned(void) +gcov_read_unsigned (void) { - gcov_unsigned_t value; - const gcov_unsigned_t *buffer = gcov_read_words(1); + gcov_unsigned_t value; + const gcov_unsigned_t *buffer = gcov_read_words (1);
- if (!buffer) - return 0; - value = from_file(buffer[0]); - return value; + if (!buffer) + return 0; + value = from_file (buffer[0]); + return value; }
/* Read counter value from a coverage file. Sets error flag on file error, overflow flag on overflow */
GCOV_LINKAGE gcov_type -gcov_read_counter(void) +gcov_read_counter (void) { - gcov_type value; - const gcov_unsigned_t *buffer = gcov_read_words(2); + gcov_type value; + const gcov_unsigned_t *buffer = gcov_read_words (2);
- if (!buffer) - return 0; - value = from_file(buffer[0]); - if (sizeof(value) > sizeof(gcov_unsigned_t)) - value |= ((gcov_type) from_file(buffer[1])) << 32; - else if (buffer[1]) - gcov_var.error = -1; + if (!buffer) + return 0; + value = from_file (buffer[0]); + if (sizeof (value) > sizeof (gcov_unsigned_t)) + value |= ((gcov_type) from_file (buffer[1])) << 32; + else if (buffer[1]) + gcov_var.error = -1;
- return value; + return value; }
+/* Mangle filename path of BASE and output new allocated pointer with + mangled path. */ + +char * +mangle_path (char const *base) +{ + /* Convert '/' to '#', convert '..' to '^', + convert ':' to '~' on DOS based file system. */ + const char *probe; + char *buffer = (char *)xmalloc (strlen (base) + 1); + char *ptr = buffer; + +#if HAVE_DOS_BASED_FILE_SYSTEM + if (base[0] && base[1] == ':') + { + ptr[0] = base[0]; + ptr[1] = '~'; + ptr += 2; + base += 2; + } +#endif + for (; *base; base = probe) + { + size_t len; + + for (probe = base; *probe; probe++) + if (*probe == '/') + break; + len = probe - base; + if (len == 2 && base[0] == '.' && base[1] == '.') + *ptr++ = '^'; + else + { + memcpy (ptr, base, len); + ptr += len; + } + if (*probe) + { + *ptr++ = '#'; + probe++; + } + } + + /* Terminate the string. */ + *ptr = '\0'; + + return buffer; +} + +/* We need to expose the below function when compiling for gcov-tool. */ + +#if !IN_LIBGCOV || defined (IN_GCOV_TOOL) /* Read string from coverage file. Returns a pointer to a static buffer, or NULL on empty string. You must copy the string before calling another gcov function. */
-#if !IN_LIBGCOV GCOV_LINKAGE const char * -gcov_read_string(void) +gcov_read_string (void) { - unsigned int length = gcov_read_unsigned(); + unsigned length = gcov_read_unsigned ();
- if (!length) - return 0; + if (!length) + return 0;
- return (const char *) gcov_read_words(length); + return (const char *) gcov_read_words (length); } #endif
GCOV_LINKAGE void -gcov_read_summary(struct gcov_summary *summary) +gcov_read_summary (struct gcov_summary *summary) { - unsigned int ix; - struct gcov_ctr_summary *csum; - - summary->checksum = gcov_read_unsigned(); - for (csum = summary->ctrs, ix = GCOV_COUNTERS_SUMMABLE; ix--; csum++) { - csum->num = gcov_read_unsigned(); - csum->runs = gcov_read_unsigned(); - csum->sum_all = gcov_read_counter(); - csum->run_max = gcov_read_counter(); - csum->sum_max = gcov_read_counter(); - } + summary->runs = gcov_read_unsigned (); + summary->sum_max = gcov_read_unsigned (); }
-#if !IN_LIBGCOV +/* We need to expose the below function when compiling for gcov-tool. */ + +#if !IN_LIBGCOV || defined (IN_GCOV_TOOL) /* Reset to a known position. BASE should have been obtained from gcov_position, LENGTH should be a record length. */
GCOV_LINKAGE void -gcov_sync(gcov_position_t base, gcov_unsigned_t length) +gcov_sync (gcov_position_t base, gcov_unsigned_t length) { - gcc_assert(gcov_var.mode > 0); - base += length; - if (base - gcov_var.start <= gcov_var.length) - gcov_var.offset = base - gcov_var.start; - else { - gcov_var.offset = gcov_var.length = 0; - fseek(gcov_var.file, base << 2, SEEK_SET); - gcov_var.start = ftell(gcov_var.file) >> 2; - } + gcov_nonruntime_assert (gcov_var.mode > 0); + base += length; + if (base - gcov_var.start <= gcov_var.length) + gcov_var.offset = base - gcov_var.start; + else + { + gcov_var.offset = gcov_var.length = 0; + fseek (gcov_var.file, base << 2, SEEK_SET); + gcov_var.start = ftell (gcov_var.file) >> 2; + } } #endif
@@ -506,13 +639,12 @@ /* Move to a given position in a gcov file. */
GCOV_LINKAGE void -gcov_seek(gcov_position_t base) +gcov_seek (gcov_position_t base) { - gcc_assert(gcov_var.mode < 0); - if (gcov_var.offset) - gcov_write_block(gcov_var.offset); - fseek(gcov_var.file, base << 2, SEEK_SET); - gcov_var.start = ftell(gcov_var.file) >> 2; + if (gcov_var.offset) + gcov_write_block (gcov_var.offset); + fseek (gcov_var.file, base << 2, SEEK_SET); + gcov_var.start = ftell (gcov_var.file) >> 2; } #endif
@@ -520,13 +652,13 @@ /* Return the modification time of the current gcov file. */
GCOV_LINKAGE time_t -gcov_time(void) +gcov_time (void) { - struct stat status; + struct stat status;
- if (fstat(fileno(gcov_var.file), &status)) - return 0; - else - return status.st_mtime; + if (fstat (fileno (gcov_var.file), &status)) + return 0; + else + return status.st_mtime; } #endif /* IN_GCOV */ diff --git a/src/lib/gcov-io.h b/src/lib/gcov-io.h index 4c0b2e4..531d300 100644 --- a/src/lib/gcov-io.h +++ b/src/lib/gcov-io.h @@ -1,6 +1,5 @@ /* File format for coverage information - Copyright (C) 1996, 1997, 1998, 2000, 2002, - 2003, 2004, 2005, 2008, 2009 Free Software Foundation, Inc. + Copyright (C) 1996-2020 Free Software Foundation, Inc. Contributed by Bob Manson manson@cygnus.com. Completely remangled by Nathan Sidwell nathan@codesourcery.com.
@@ -19,7 +18,11 @@ Under Section 7 of GPL version 3, you are granted additional permissions described in the GCC Runtime Library Exception, version 3.1, as published by the Free Software Foundation. -*/ + +You should have received a copy of the GNU General Public License and +a copy of the GCC Runtime Library Exception along with this program; +see the files COPYING3 and COPYING.RUNTIME respectively. If not, see +http://www.gnu.org/licenses/. */
/* Coverage information is held in two files. A notes file, which is @@ -39,15 +42,19 @@ string. Zero length and NULL strings are simply stored as a length of zero (they have no trailing NUL or padding).
- int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 + int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 int64: int32:low int32:high string: int32:0 | int32:length char* char:0 padding padding: | char:0 | char:0 char:0 | char:0 char:0 char:0 item: int32 | int64 | string
- The basic format of the files is + The basic format of the notes file is
- file : int32:magic int32:version int32:stamp record* + file : int32:magic int32:version int32:stamp int32:support_unexecuted_blocks record* + + The basic format of the data file is + + file : int32:magic int32:version int32:stamp record*
The magic ident is different for the notes and the data files. The magic ident is used to determine the endianness of the file, when @@ -60,23 +67,23 @@
Although the ident and version are formally 32 bit numbers, they are derived from 4 character ASCII strings. The version number - consists of the single character major version number, a two - character minor version number (leading zero for versions less than - 10), and a single character indicating the status of the release. + consists of a two character major version number + (first digit starts from 'A' letter to not to clash with the older + numbering scheme), the single character minor version number, + and a single character indicating the status of the release. That will be 'e' experimental, 'p' prerelease and 'r' for release. Because, by good fortune, these are in alphabetical order, string collating can be used to compare version strings. Be aware that the 'e' designation will (naturally) be unstable and might be - incompatible with itself. For gcc 3.4 experimental, it would be - '304e' (0x33303465). When the major version reaches 10, the - letters A-Z will be used. Assuming minor increments releases every - 6 months, we have to make a major increment every 50 years. - Assuming major increments releases every 5 years, we're ok for the - next 155 years -- good enough for me. + incompatible with itself. For gcc 17.0 experimental, it would be + 'B70e' (0x42373065). As we currently do not release more than 5 minor + releases, the single character should be always fine. Major number + is currently changed roughly every year, which gives us space + for next 250 years (maximum allowed number would be 259.9).
A record has a tag, length and variable amount of data.
- record: header data + record: header data header: int32:tag int32:length data: item*
@@ -95,18 +102,18 @@ tags, values [41..9f] for the notes file and [a1..ff] for the data file.
- The basic block graph file contains the following records - note: unit function-graph* + The notes file contains the following records + note: unit function-graph* unit: header int32:checksum string:source function-graph: announce_function basic_blocks {arcs | lines}* announce_function: header int32:ident int32:lineno_checksum int32:cfg_checksum - string:name string:source int32:lineno + string:name string:source int32:start_lineno int32:start_column int32:end_lineno basic_block: header int32:flags* arcs: header int32:block_no arc* arc: int32:dest_block int32:flags - lines: header int32:block_no line* - int32:0 string:NULL + lines: header int32:block_no line* + int32:0 string:NULL line: int32:line_no | int32:0 string:filename
The BASIC_BLOCK record holds per-bb flags. The number of blocks @@ -126,16 +133,14 @@ blocks they are for.
The data file contains the following records. - data: {unit summary:object summary:program* function-data*}* + data: {unit summary:object function-data*}* unit: header int32:checksum function-data: announce_function present counts announce_function: header int32:ident int32:lineno_checksum int32:cfg_checksum present: header int32:present counts: header int64:count* - summary: int32:checksum {count-summary}GCOV_COUNTERS_SUMMABLE - count-summary: int32:num int32:runs int64:sum - int64:max int64:sum_max + summary: int32:checksum int32:runs int32:sum_max
The ANNOUNCE_FUNCTION record is the same as that in the note file, but without the source location. The COUNTS gives the @@ -177,114 +182,42 @@ #endif #endif /* __COREBOOT__ */
-#if IN_LIBGCOV -/* About the target */ - -#if BITS_PER_UNIT == 8 -typedef unsigned int gcov_unsigned_t __attribute__((mode(SI))); -typedef unsigned int gcov_position_t __attribute__((mode(SI))); -#if LONG_LONG_TYPE_SIZE > 32 -typedef signed gcov_type __attribute__((mode(DI))); -#else -typedef signed gcov_type __attribute__((mode(SI))); -#endif -#else -#if BITS_PER_UNIT == 16 -typedef unsigned int gcov_unsigned_t __attribute__((mode(HI))); -typedef unsigned int gcov_position_t __attribute__((mode(HI))); -#if LONG_LONG_TYPE_SIZE > 32 -typedef signed gcov_type __attribute__((mode(SI))); -#else -typedef signed gcov_type __attribute__((mode(HI))); -#endif -#else -typedef unsigned int gcov_unsigned_t __attribute__((mode(QI))); -typedef unsigned int gcov_position_t __attribute__((mode(QI))); -#if LONG_LONG_TYPE_SIZE > 32 -typedef signed gcov_type __attribute__((mode(HI))); -#else -typedef signed gcov_type __attribute__((mode(QI))); -#endif -#endif -#endif - - -#if defined(TARGET_POSIX_IO) -#define GCOV_LOCKED 1 -#else -#define GCOV_LOCKED 0 -#endif - -#else /* !IN_LIBGCOV */ +#ifndef IN_LIBGCOV /* About the host */
-typedef unsigned int gcov_unsigned_t; -typedef unsigned int gcov_position_t; +typedef unsigned gcov_unsigned_t; +typedef unsigned gcov_position_t; /* gcov_type is typedef'd elsewhere for the compiler */ #if IN_GCOV #define GCOV_LINKAGE static -typedef HOST_WIDEST_INT gcov_type; +typedef int64_t gcov_type; +typedef uint64_t gcov_type_unsigned; #if IN_GCOV > 0 #include <sys/types.h> #endif -#else /*!IN_GCOV */ -#define GCOV_TYPE_SIZE (LONG_LONG_TYPE_SIZE > 32 ? 64 : 32) #endif
-#if defined(HOST_HAS_F_SETLKW) +#if defined (HOST_HAS_F_SETLKW) #define GCOV_LOCKED 1 #else #define GCOV_LOCKED 0 #endif
+#define ATTRIBUTE_HIDDEN + #endif /* !IN_LIBGCOV */
-/* In gcov we want function linkage to be static. In the compiler we want - it extern, so that they can be accessed from elsewhere. In libgcov we - need these functions to be extern, so prefix them with __gcov. In - libgcov they must also be hidden so that the instance in the executable - is not also used in a DSO. */ -#if IN_LIBGCOV - -#ifndef __COREBOOT__ -#include "tconfig.h" -#endif /* __COREBOOT__ */ - -#define gcov_var __gcov_var -#define gcov_open __gcov_open -#define gcov_close __gcov_close -#define gcov_write_tag_length __gcov_write_tag_length -#define gcov_position __gcov_position -#define gcov_seek __gcov_seek -#define gcov_rewrite __gcov_rewrite -#define gcov_is_error __gcov_is_error -#define gcov_write_unsigned __gcov_write_unsigned -#define gcov_write_counter __gcov_write_counter -#define gcov_write_summary __gcov_write_summary -#define gcov_read_unsigned __gcov_read_unsigned -#define gcov_read_counter __gcov_read_counter -#define gcov_read_summary __gcov_read_summary - -/* Poison these, so they don't accidentally slip in. */ -#pragma GCC poison gcov_write_string gcov_write_tag gcov_write_length -#pragma GCC poison gcov_read_string gcov_sync gcov_time gcov_magic - -#ifdef HAVE_GAS_HIDDEN -#define ATTRIBUTE_HIDDEN __attribute__((__visibility__("hidden"))) -#else -#define ATTRIBUTE_HIDDEN -#endif - -#else - -#define ATTRIBUTE_HIDDEN - -#endif - #ifndef GCOV_LINKAGE #define GCOV_LINKAGE extern #endif
+#if IN_LIBGCOV +#define gcov_nonruntime_assert(EXPR) ((void)(0 && (EXPR))) +#else +#define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) +#define gcov_error(...) fatal_error (input_location, __VA_ARGS__) +#endif + /* File suffixes. */ #define GCOV_DATA_SUFFIX ".gcda" #define GCOV_NOTE_SUFFIX ".gcno" @@ -295,16 +228,16 @@
/* gcov-iov.h is automatically generated by the makefile from version.c, it looks like - #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) + #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) */ #include "gcov-iov.h"
/* Convert a magic or version number to a 4 character string. */ -#define GCOV_UNSIGNED2STRING(ARRAY, VALUE) \ - ((ARRAY)[0] = (char)((VALUE) >> 24), \ - (ARRAY)[1] = (char)((VALUE) >> 16), \ - (ARRAY)[2] = (char)((VALUE) >> 8), \ - (ARRAY)[3] = (char)((VALUE) >> 0)) +#define GCOV_UNSIGNED2STRING(ARRAY,VALUE) \ + ((ARRAY)[0] = (char)((VALUE) >> 24), \ + (ARRAY)[1] = (char)((VALUE) >> 16), \ + (ARRAY)[2] = (char)((VALUE) >> 8), \ + (ARRAY)[3] = (char)((VALUE) >> 0))
/* The record tags. Values [1..3f] are for tags which may be in either file. Values [41..9f] for those in the note file and [a1..ff] for @@ -315,71 +248,57 @@ #define GCOV_TAG_FUNCTION_LENGTH (3) #define GCOV_TAG_BLOCKS ((gcov_unsigned_t)0x01410000) #define GCOV_TAG_BLOCKS_LENGTH(NUM) (NUM) -#define GCOV_TAG_BLOCKS_NUM(LENGTH) (LENGTH) #define GCOV_TAG_ARCS ((gcov_unsigned_t)0x01430000) #define GCOV_TAG_ARCS_LENGTH(NUM) (1 + (NUM) * 2) #define GCOV_TAG_ARCS_NUM(LENGTH) (((LENGTH) - 1) / 2) #define GCOV_TAG_LINES ((gcov_unsigned_t)0x01450000) -#define GCOV_TAG_COUNTER_BASE ((gcov_unsigned_t)0x01a10000) +#define GCOV_TAG_COUNTER_BASE ((gcov_unsigned_t)0x01a10000) #define GCOV_TAG_COUNTER_LENGTH(NUM) ((NUM) * 2) #define GCOV_TAG_COUNTER_NUM(LENGTH) ((LENGTH) / 2) -#define GCOV_TAG_OBJECT_SUMMARY ((gcov_unsigned_t)0xa1000000) /* Obsolete */ -#define GCOV_TAG_PROGRAM_SUMMARY ((gcov_unsigned_t)0xa3000000) -#define GCOV_TAG_SUMMARY_LENGTH \ - (1 + GCOV_COUNTERS_SUMMABLE * (2 + 3 * 2)) +#define GCOV_TAG_OBJECT_SUMMARY ((gcov_unsigned_t)0xa1000000) +#define GCOV_TAG_PROGRAM_SUMMARY ((gcov_unsigned_t)0xa3000000) /* Obsolete */ +#define GCOV_TAG_SUMMARY_LENGTH (2) +#define GCOV_TAG_AFDO_FILE_NAMES ((gcov_unsigned_t)0xaa000000) +#define GCOV_TAG_AFDO_FUNCTION ((gcov_unsigned_t)0xac000000) +#define GCOV_TAG_AFDO_WORKING_SET ((gcov_unsigned_t)0xaf000000) +
/* Counters that are collected. */ -#define GCOV_COUNTER_ARCS 0 /* Arc transitions. */ -#define GCOV_COUNTERS_SUMMABLE 1 /* Counters which can be - summed. */ -#define GCOV_FIRST_VALUE_COUNTER 1 /* The first of counters used for value - profiling. They must form a consecutive - interval and their order must match - the order of HIST_TYPEs in - value-prof.h. */ -#define GCOV_COUNTER_V_INTERVAL 1 /* Histogram of value inside an interval. */ -#define GCOV_COUNTER_V_POW2 2 /* Histogram of exact power2 logarithm - of a value. */ -#define GCOV_COUNTER_V_SINGLE 3 /* The most common value of expression. */ -#define GCOV_COUNTER_V_DELTA 4 /* The most common difference between - consecutive values of expression. */
-#define GCOV_COUNTER_V_INDIR 5 /* The most common indirect address */ -#define GCOV_COUNTER_AVERAGE 6 /* Compute average value passed to the - counter. */ -#define GCOV_COUNTER_IOR 7 /* IOR of the all values passed to - counter. */ -#define GCOV_LAST_VALUE_COUNTER 7 /* The last of counters used for value - profiling. */ -#define GCOV_COUNTERS 8 +#define DEF_GCOV_COUNTER(COUNTER, NAME, MERGE_FN) COUNTER, +enum { +#include "gcov-counter.def" +GCOV_COUNTERS +}; +#undef DEF_GCOV_COUNTER + +/* The first of counters used for value profiling. They must form a + consecutive interval and their order must match the order of + HIST_TYPEs in value-prof.h. */ +#define GCOV_FIRST_VALUE_COUNTER GCOV_COUNTER_V_INTERVAL + +/* The last of counters used for value profiling. */ +#define GCOV_LAST_VALUE_COUNTER (GCOV_COUNTERS - 1)
/* Number of counters used for value profiling. */ #define GCOV_N_VALUE_COUNTERS \ - (GCOV_LAST_VALUE_COUNTER - GCOV_FIRST_VALUE_COUNTER + 1) + (GCOV_LAST_VALUE_COUNTER - GCOV_FIRST_VALUE_COUNTER + 1)
- /* A list of human readable names of the counters */ -#define GCOV_COUNTER_NAMES {"arcs", "interval", "pow2", "single", \ - "delta", "indirect_call", "average", "ior"} +/* Number of top N value histogram. */ +#define GCOV_TOPN_VALUES 4
- /* Names of merge functions for counters. */ -#define GCOV_MERGE_FUNCTIONS {"__gcov_merge_add", \ - "__gcov_merge_add", \ - "__gcov_merge_add", \ - "__gcov_merge_single", \ - "__gcov_merge_delta", \ - "__gcov_merge_single", \ - "__gcov_merge_add", \ - "__gcov_merge_ior"} +/* Total number of single value counters. */ +#define GCOV_TOPN_VALUES_COUNTERS (2 * GCOV_TOPN_VALUES + 1)
/* Convert a counter index to a tag. */ #define GCOV_TAG_FOR_COUNTER(COUNT) \ (GCOV_TAG_COUNTER_BASE + ((gcov_unsigned_t)(COUNT) << 17)) /* Convert a tag to a counter. */ #define GCOV_COUNTER_FOR_TAG(TAG) \ - ((unsigned int)(((TAG) - GCOV_TAG_COUNTER_BASE) >> 17)) + ((unsigned)(((TAG) - GCOV_TAG_COUNTER_BASE) >> 17)) /* Check whether a tag is a counter tag. */ #define GCOV_TAG_IS_COUNTER(TAG) \ - (!((TAG) & 0xFFFF) && GCOV_COUNTER_FOR_TAG(TAG) < GCOV_COUNTERS) + (!((TAG) & 0xFFFF) && GCOV_COUNTER_FOR_TAG (TAG) < GCOV_COUNTERS)
/* The tag level mask has 1's in the position of the inner levels, & the lsb of the current level, and zero on the current and outer @@ -387,156 +306,31 @@ #define GCOV_TAG_MASK(TAG) (((TAG) - 1) ^ (TAG))
/* Return nonzero if SUB is an immediate subtag of TAG. */ -#define GCOV_TAG_IS_SUBTAG(TAG, SUB) \ - (GCOV_TAG_MASK(TAG) >> 8 == GCOV_TAG_MASK(SUB) \ - && !(((SUB) ^ (TAG)) & ~GCOV_TAG_MASK(TAG))) +#define GCOV_TAG_IS_SUBTAG(TAG,SUB) \ + (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ + && !(((SUB) ^ (TAG)) & ~GCOV_TAG_MASK (TAG)))
/* Return nonzero if SUB is at a sublevel to TAG. */ -#define GCOV_TAG_IS_SUBLEVEL(TAG, SUB) \ - (GCOV_TAG_MASK(TAG) > GCOV_TAG_MASK(SUB)) +#define GCOV_TAG_IS_SUBLEVEL(TAG,SUB) \ + (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB))
/* Basic block flags. */ #define GCOV_BLOCK_UNEXPECTED (1 << 1)
/* Arc flags. */ -#define GCOV_ARC_ON_TREE (1 << 0) +#define GCOV_ARC_ON_TREE (1 << 0) #define GCOV_ARC_FAKE (1 << 1) #define GCOV_ARC_FALLTHROUGH (1 << 2)
-/* Structured records. */ - -/* Cumulative counter data. */ -struct gcov_ctr_summary { - gcov_unsigned_t num; /* number of counters. */ - gcov_unsigned_t runs; /* number of program runs */ - gcov_type sum_all; /* sum of all counters accumulated. */ - gcov_type run_max; /* maximum value on a single run. */ - gcov_type sum_max; /* sum of individual run max values. */ -}; - /* Object & program summary record. */ -struct gcov_summary { - gcov_unsigned_t checksum; /* checksum of program */ - struct gcov_ctr_summary ctrs[GCOV_COUNTERS_SUMMABLE]; -};
-/* Structures embedded in coverage program. The structures generated - by write_profile must match these. */ - -#if IN_LIBGCOV -/* Information about counters for a single function. */ -struct gcov_ctr_info { - gcov_unsigned_t num; /* number of counters. */ - gcov_type *values; /* their values. */ -}; - -/* Information about a single function. This uses the trailing array - idiom. The number of counters is determined from the merge pointer - array in gcov_info. The key is used to detect which of a set of - comdat functions was selected -- it points to the gcov_info object - of the object file containing the selected comdat function. */ - -struct gcov_fn_info { - const struct gcov_info *key; /* comdat key */ - gcov_unsigned_t ident; /* unique ident of function */ - gcov_unsigned_t lineno_checksum; /* function lineo_checksum */ - gcov_unsigned_t cfg_checksum; /* function cfg checksum */ - struct gcov_ctr_info ctrs[0]; /* instrumented counters */ -}; - -/* Type of function used to merge counters. */ -typedef void (*gcov_merge_fn) (gcov_type *, gcov_unsigned_t); - -/* Information about a single object file. */ -struct gcov_info { - gcov_unsigned_t version; /* expected version number */ - struct gcov_info *next; /* link to next, used by libgcov */ - - gcov_unsigned_t stamp; /* uniquifying time stamp */ - const char *filename; /* output file name */ - - gcov_merge_fn merge[GCOV_COUNTERS]; /* merge functions (null for - unused) */ - - unsigned int n_functions; /* number of functions */ - const struct gcov_fn_info *const *functions; /* pointer to pointers to - function information */ -}; - -/* Register a new object file module. */ -extern void __gcov_init(struct gcov_info *) ATTRIBUTE_HIDDEN; - -#ifndef __COREBOOT__ -/* Called before fork, to avoid double counting. */ -extern void __gcov_flush(void) ATTRIBUTE_HIDDEN; -#endif - -/* The merge function that just sums the counters. */ -extern void __gcov_merge_add(gcov_type *, unsigned int) ATTRIBUTE_HIDDEN; - -/* The merge function to choose the most common value. */ -extern void __gcov_merge_single(gcov_type *, unsigned int) ATTRIBUTE_HIDDEN; - -/* The merge function to choose the most common difference between - consecutive values. */ -extern void __gcov_merge_delta(gcov_type *, unsigned int) ATTRIBUTE_HIDDEN; - -/* The merge function that just ors the counters together. */ -extern void __gcov_merge_ior(gcov_type *, unsigned int) ATTRIBUTE_HIDDEN; - -/* The profiler functions. */ -extern void __gcov_interval_profiler(gcov_type *, gcov_type, int, unsigned int); -extern void __gcov_pow2_profiler(gcov_type *, gcov_type); -extern void __gcov_one_value_profiler(gcov_type *, gcov_type); -extern void __gcov_indirect_call_profiler(gcov_type *, gcov_type, void *, - void *); -extern void __gcov_average_profiler(gcov_type *, gcov_type); -extern void __gcov_ior_profiler(gcov_type *, gcov_type); - -#ifndef inhibit_libc -/* The wrappers around some library functions.. */ -extern pid_t __gcov_fork(void) ATTRIBUTE_HIDDEN; -extern int __gcov_execl(const char *, char *, ...) ATTRIBUTE_HIDDEN; -extern int __gcov_execlp(const char *, char *, ...) ATTRIBUTE_HIDDEN; -extern int __gcov_execle(const char *, char *, ...) ATTRIBUTE_HIDDEN; -extern int __gcov_execv(const char *, char *const []) ATTRIBUTE_HIDDEN; -extern int __gcov_execvp(const char *, char *const []) ATTRIBUTE_HIDDEN; -extern int __gcov_execve(const char *, char *const [], char *const []) - ATTRIBUTE_HIDDEN; -#endif - -#endif /* IN_LIBGCOV */ - -#if IN_LIBGCOV >= 0 - -/* Optimum number of gcov_unsigned_t's read from or written to disk. */ -#define GCOV_BLOCK_SIZE (1 << 10) - -GCOV_LINKAGE struct gcov_var +struct gcov_summary { - FILE *file; - gcov_position_t start; /* Position of first byte of block */ - unsigned int offset; /* Read/write position within the block. */ - unsigned int length; /* Read limit in the block. */ - unsigned int overread; /* Number of words overread. */ - int error; /* < 0 overflow, > 0 disk error. */ - int mode; /* < 0 writing, > 0 reading */ -#if IN_LIBGCOV - /* Holds one block plus 4 bytes, thus all coverage reads & writes - * fit within this buffer and we always can transfer GCOV_BLOCK_SIZE - * to and from the disk. libgcov never backtracks and only writes 4 - * or 8 byte objects. - */ - gcov_unsigned_t buffer[GCOV_BLOCK_SIZE + 1]; -#else - int endian; /* Swap endianness. */ - /* Holds a variable length block, as the compiler can write - * strings and needs to backtrack. - */ - size_t alloc; - gcov_unsigned_t *buffer; -#endif -} gcov_var ATTRIBUTE_HIDDEN; + gcov_unsigned_t runs; /* Number of program runs. */ + gcov_type sum_max; /* Sum of individual run max values. */ +}; + +#if !defined(inhibit_libc)
/* Functions for reading and writing gcov files. In libgcov you can open the file for reading then writing. Elsewhere you can open the @@ -547,87 +341,40 @@ you use the functions for reading, then gcov_rewrite then the functions for writing. Your file may become corrupted if you break these invariants. */ -#if IN_LIBGCOV -GCOV_LINKAGE int gcov_open(const char */*name*/) ATTRIBUTE_HIDDEN; -#else -GCOV_LINKAGE int gcov_open(const char */*name*/, int /*direction*/); -GCOV_LINKAGE int gcov_magic(gcov_unsigned_t, gcov_unsigned_t); + +#if !IN_LIBGCOV +GCOV_LINKAGE int gcov_open (const char */*name*/, int /*direction*/); +GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); #endif -GCOV_LINKAGE int gcov_close(void) ATTRIBUTE_HIDDEN;
/* Available everywhere. */ -static gcov_position_t gcov_position(void); -static int gcov_is_error(void); - -GCOV_LINKAGE gcov_unsigned_t gcov_read_unsigned(void) ATTRIBUTE_HIDDEN; -GCOV_LINKAGE gcov_type gcov_read_counter(void) ATTRIBUTE_HIDDEN; -GCOV_LINKAGE void gcov_read_summary(struct gcov_summary *) ATTRIBUTE_HIDDEN; - -#if IN_LIBGCOV -/* Available only in libgcov */ -GCOV_LINKAGE void gcov_write_counter(gcov_type) ATTRIBUTE_HIDDEN; -GCOV_LINKAGE void gcov_write_tag_length(gcov_unsigned_t, gcov_unsigned_t) - ATTRIBUTE_HIDDEN; -GCOV_LINKAGE void gcov_write_summary(gcov_unsigned_t /*tag*/, - const struct gcov_summary *) - ATTRIBUTE_HIDDEN; -static void gcov_rewrite(void); -GCOV_LINKAGE void gcov_seek(gcov_position_t /*position*/) ATTRIBUTE_HIDDEN; -#else -/* Available outside libgcov */ -GCOV_LINKAGE const char *gcov_read_string(void); -GCOV_LINKAGE void gcov_sync(gcov_position_t /*base*/, +GCOV_LINKAGE int gcov_close (void) ATTRIBUTE_HIDDEN; +GCOV_LINKAGE gcov_unsigned_t gcov_read_unsigned (void) ATTRIBUTE_HIDDEN; +GCOV_LINKAGE gcov_type gcov_read_counter (void) ATTRIBUTE_HIDDEN; +GCOV_LINKAGE void gcov_read_summary (struct gcov_summary *) ATTRIBUTE_HIDDEN; +GCOV_LINKAGE const char *gcov_read_string (void); +GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, gcov_unsigned_t /*length */); -#endif +char *mangle_path (char const *base);
#if !IN_GCOV /* Available outside gcov */ -GCOV_LINKAGE void gcov_write_unsigned(gcov_unsigned_t) ATTRIBUTE_HIDDEN; +GCOV_LINKAGE void gcov_write_unsigned (gcov_unsigned_t) ATTRIBUTE_HIDDEN; #endif
#if !IN_GCOV && !IN_LIBGCOV /* Available only in compiler */ -GCOV_LINKAGE void gcov_write_string(const char *); -GCOV_LINKAGE gcov_position_t gcov_write_tag(gcov_unsigned_t); -GCOV_LINKAGE void gcov_write_length(gcov_position_t /*position*/); +GCOV_LINKAGE void gcov_write_string (const char *); +GCOV_LINKAGE void gcov_write_filename (const char *); +GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); +GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); #endif
#if IN_GCOV > 0 /* Available in gcov */ -GCOV_LINKAGE time_t gcov_time(void); +GCOV_LINKAGE time_t gcov_time (void); #endif
-/* Save the current position in the gcov file. */ - -static inline gcov_position_t -gcov_position(void) -{ - gcc_assert(gcov_var.mode > 0); - return gcov_var.start + gcov_var.offset; -} - -/* Return nonzero if the error flag is set. */ - -static inline int -gcov_is_error(void) -{ - return gcov_var.file ? gcov_var.error : 1; -} - -#if IN_LIBGCOV -/* Move to beginning of file and initialize for writing. */ - -static inline void -gcov_rewrite(void) -{ - gcc_assert(gcov_var.mode > 0); - gcov_var.mode = -1; - gcov_var.start = 0; - gcov_var.offset = 0; - fseek(gcov_var.file, 0L, SEEK_SET); -} -#endif - -#endif /* IN_LIBGCOV >= 0 */ +#endif /* !inhibit_libc */
#endif /* GCC_GCOV_IO_H */
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40013 )
Change subject: src/lib: Update gcov-io.[ch] (test) ......................................................................
Patch Set 1:
(536 comments)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h File src/lib/gcov-io.h:
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@45 PS1, Line 45: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@51 PS1, Line 51: The basic format of the notes file is please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@55 PS1, Line 55: The basic format of the data file is please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@57 PS1, Line 57: file : int32:magic int32:version int32:stamp record* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@57 PS1, Line 57: file : int32:magic int32:version int32:stamp record* please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@57 PS1, Line 57: file : int32:magic int32:version int32:stamp record* please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@70 PS1, Line 70: consists of a two character major version number please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@71 PS1, Line 71: (first digit starts from 'A' letter to not to clash with the older please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@72 PS1, Line 72: numbering scheme), the single character minor version number, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@73 PS1, Line 73: and a single character indicating the status of the release. please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@78 PS1, Line 78: incompatible with itself. For gcc 17.0 experimental, it would be please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@79 PS1, Line 79: 'B70e' (0x42373065). As we currently do not release more than 5 minor please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@80 PS1, Line 80: releases, the single character should be always fine. Major number please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@81 PS1, Line 81: is currently changed roughly every year, which gives us space please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@82 PS1, Line 82: for next 250 years (maximum allowed number would be 259.9). please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@82 PS1, Line 82: for next 250 years (maximum allowed number would be 259.9). space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@86 PS1, Line 86: record: header data labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@105 PS1, Line 105: The notes file contains the following records please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@106 PS1, Line 106: note: unit function-graph* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@111 PS1, Line 111: string:name string:source int32:start_lineno int32:start_column int32:end_lineno labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@115 PS1, Line 115: lines: header int32:block_no line* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@115 PS1, Line 115: lines: header int32:block_no line* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@115 PS1, Line 115: lines: header int32:block_no line* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@116 PS1, Line 116: int32:0 string:NULL code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@136 PS1, Line 136: data: {unit summary:object function-data*}* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@136 PS1, Line 136: data: {unit summary:object function-data*}* space required before that '*' (ctx:VxE)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@136 PS1, Line 136: data: {unit summary:object function-data*}* space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@136 PS1, Line 136: data: {unit summary:object function-data*}* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@143 PS1, Line 143: summary: int32:checksum int32:runs int32:sum_max spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@143 PS1, Line 143: summary: int32:checksum int32:runs int32:sum_max labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@188 PS1, Line 188: typedef unsigned gcov_unsigned_t; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@189 PS1, Line 189: typedef unsigned gcov_position_t; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@200 PS1, Line 200: #if defined (HOST_HAS_F_SETLKW) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@217 PS1, Line 217: #define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@217 PS1, Line 217: #define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@218 PS1, Line 218: #define gcov_error(...) fatal_error (input_location, __VA_ARGS__) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@218 PS1, Line 218: #define gcov_error(...) fatal_error (input_location, __VA_ARGS__) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@231 PS1, Line 231: #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@231 PS1, Line 231: #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@236 PS1, Line 236: #define GCOV_UNSIGNED2STRING(ARRAY,VALUE) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@237 PS1, Line 237: ((ARRAY)[0] = (char)((VALUE) >> 24), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@238 PS1, Line 238: (ARRAY)[1] = (char)((VALUE) >> 16), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@239 PS1, Line 239: (ARRAY)[2] = (char)((VALUE) >> 8), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@240 PS1, Line 240: (ARRAY)[3] = (char)((VALUE) >> 0)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@255 PS1, Line 255: #define GCOV_TAG_COUNTER_BASE ((gcov_unsigned_t)0x01a10000) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@285 PS1, Line 285: (GCOV_LAST_VALUE_COUNTER - GCOV_FIRST_VALUE_COUNTER + 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@298 PS1, Line 298: ((unsigned)(((TAG) - GCOV_TAG_COUNTER_BASE) >> 17)) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@301 PS1, Line 301: (!((TAG) & 0xFFFF) && GCOV_COUNTER_FOR_TAG (TAG) < GCOV_COUNTERS) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@309 PS1, Line 309: #define GCOV_TAG_IS_SUBTAG(TAG,SUB) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@310 PS1, Line 310: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@310 PS1, Line 310: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@310 PS1, Line 310: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@311 PS1, Line 311: && !(((SUB) ^ (TAG)) & ~GCOV_TAG_MASK (TAG))) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@314 PS1, Line 314: #define GCOV_TAG_IS_SUBLEVEL(TAG,SUB) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@315 PS1, Line 315: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@321 PS1, Line 321: #define GCOV_ARC_ON_TREE (1 << 0) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@328 PS1, Line 328: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@329 PS1, Line 329: gcov_unsigned_t runs; /* Number of program runs. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@330 PS1, Line 330: gcov_type sum_max; /* Sum of individual run max values. */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@330 PS1, Line 330: gcov_type sum_max; /* Sum of individual run max values. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@346 PS1, Line 346: GCOV_LINKAGE int gcov_open (const char */*name*/, int /*direction*/); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@347 PS1, Line 347: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@347 PS1, Line 347: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@347 PS1, Line 347: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@351 PS1, Line 351: GCOV_LINKAGE int gcov_close (void) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@353 PS1, Line 353: GCOV_LINKAGE gcov_type gcov_read_counter (void) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@354 PS1, Line 354: GCOV_LINKAGE void gcov_read_summary (struct gcov_summary *) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@355 PS1, Line 355: GCOV_LINKAGE const char *gcov_read_string (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@356 PS1, Line 356: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@356 PS1, Line 356: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, function definition argument 'gcov_position_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@356 PS1, Line 356: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@358 PS1, Line 358: char *mangle_path (char const *base); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@367 PS1, Line 367: GCOV_LINKAGE void gcov_write_string (const char *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@368 PS1, Line 368: GCOV_LINKAGE void gcov_write_filename (const char *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@368 PS1, Line 368: GCOV_LINKAGE void gcov_write_filename (const char *); function definition argument 'const char *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@369 PS1, Line 369: GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@369 PS1, Line 369: GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@370 PS1, Line 370: GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@370 PS1, Line 370: GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); function definition argument 'gcov_position_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.h@375 PS1, Line 375: GCOV_LINKAGE time_t gcov_time (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c File src/lib/gcov-io.c:
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@31 PS1, Line 31: static void gcov_write_block (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@31 PS1, Line 31: static void gcov_write_block (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@32 PS1, Line 32: static gcov_unsigned_t *gcov_write_words (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@32 PS1, Line 32: static gcov_unsigned_t *gcov_write_words (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@34 PS1, Line 34: static const gcov_unsigned_t *gcov_read_words (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@34 PS1, Line 34: static const gcov_unsigned_t *gcov_read_words (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@36 PS1, Line 36: static void gcov_allocate (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@36 PS1, Line 36: static void gcov_allocate (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@43 PS1, Line 43: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@44 PS1, Line 44: FILE *file; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@45 PS1, Line 45: gcov_position_t start; /* Position of first byte of block */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@46 PS1, Line 46: unsigned offset; /* Read/write position within the block. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@46 PS1, Line 46: unsigned offset; /* Read/write position within the block. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@47 PS1, Line 47: unsigned length; /* Read limit in the block. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@47 PS1, Line 47: unsigned length; /* Read limit in the block. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@48 PS1, Line 48: unsigned overread; /* Number of words overread. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@48 PS1, Line 48: unsigned overread; /* Number of words overread. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@49 PS1, Line 49: int error; /* < 0 overflow, > 0 disk error. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@50 PS1, Line 50: int mode; /* < 0 writing, > 0 reading */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@56 PS1, Line 56: gcov_unsigned_t buffer[GCOV_BLOCK_SIZE + 1]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@58 PS1, Line 58: int endian; /* Swap endianness. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@61 PS1, Line 61: size_t alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@62 PS1, Line 62: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@72 PS1, Line 72: gcov_position (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@74 PS1, Line 74: gcov_nonruntime_assert (gcov_var.mode > 0); trailing whitespace
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@74 PS1, Line 74: gcov_nonruntime_assert (gcov_var.mode > 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@74 PS1, Line 74: gcov_nonruntime_assert (gcov_var.mode > 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@75 PS1, Line 75: return gcov_var.start + gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@84 PS1, Line 84: gcov_is_error (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@86 PS1, Line 86: return gcov_var.file ? gcov_var.error : 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@92 PS1, Line 92: gcov_rewrite (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@94 PS1, Line 94: gcov_var.mode = -1; trailing whitespace
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@94 PS1, Line 94: gcov_var.mode = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@95 PS1, Line 95: gcov_var.start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@96 PS1, Line 96: gcov_var.offset = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@97 PS1, Line 97: fseek (gcov_var.file, 0L, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@97 PS1, Line 97: fseek (gcov_var.file, 0L, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@101 PS1, Line 101: static inline gcov_unsigned_t from_file (gcov_unsigned_t value) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@104 PS1, Line 104: if (gcov_var.endian) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@104 PS1, Line 104: if (gcov_var.endian) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@104 PS1, Line 104: if (gcov_var.endian) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@105 PS1, Line 105: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@106 PS1, Line 106: value = (value >> 16) | (value << 16); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@107 PS1, Line 107: value = ((value & 0xff00ff) << 8) | ((value >> 8) & 0xff00ff); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@108 PS1, Line 108: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@110 PS1, Line 110: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@124 PS1, Line 124: gcov_open (const char *name) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@126 PS1, Line 126: gcov_open (const char *name, int mode) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@130 PS1, Line 130: int mode = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@133 PS1, Line 133: struct flock s_flock; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@134 PS1, Line 134: int fd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@136 PS1, Line 136: s_flock.l_whence = SEEK_SET; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@137 PS1, Line 137: s_flock.l_start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@138 PS1, Line 138: s_flock.l_len = 0; /* Until EOF. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@139 PS1, Line 139: s_flock.l_pid = getpid (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@139 PS1, Line 139: s_flock.l_pid = getpid (); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@142 PS1, Line 142: gcov_nonruntime_assert (!gcov_var.file); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@142 PS1, Line 142: gcov_nonruntime_assert (!gcov_var.file); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@143 PS1, Line 143: gcov_var.start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@144 PS1, Line 144: gcov_var.offset = gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@145 PS1, Line 145: gcov_var.overread = -1u; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@146 PS1, Line 146: gcov_var.error = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@148 PS1, Line 148: gcov_var.endian = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@151 PS1, Line 151: if (mode > 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@151 PS1, Line 151: if (mode > 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@151 PS1, Line 151: if (mode > 0) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@152 PS1, Line 152: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@154 PS1, Line 154: s_flock.l_type = F_RDLCK; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@156 PS1, Line 156: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@156 PS1, Line 156: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@156 PS1, Line 156: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@157 PS1, Line 157: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@158 PS1, Line 158: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@158 PS1, Line 158: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@158 PS1, Line 158: else suspect code indent for conditional statements (2, 7)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@159 PS1, Line 159: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@161 PS1, Line 161: s_flock.l_type = F_WRLCK; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@163 PS1, Line 163: fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@163 PS1, Line 163: fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@164 PS1, Line 164: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@165 PS1, Line 165: if (fd < 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@165 PS1, Line 165: if (fd < 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@166 PS1, Line 166: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@168 PS1, Line 168: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@168 PS1, Line 168: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@168 PS1, Line 168: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@169 PS1, Line 169: continue; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@171 PS1, Line 171: gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@171 PS1, Line 171: gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@173 PS1, Line 173: if (!gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@173 PS1, Line 173: if (!gcov_var.file) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@173 PS1, Line 173: if (!gcov_var.file) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@174 PS1, Line 174: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@175 PS1, Line 175: close (fd); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@175 PS1, Line 175: close (fd); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@176 PS1, Line 176: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@177 PS1, Line 177: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@179 PS1, Line 179: if (mode >= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@179 PS1, Line 179: if (mode >= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@181 PS1, Line 181: gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@181 PS1, Line 181: gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@183 PS1, Line 183: if (gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@183 PS1, Line 183: if (gcov_var.file) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@184 PS1, Line 184: mode = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@185 PS1, Line 185: else if (mode <= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@185 PS1, Line 185: else if (mode <= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@187 PS1, Line 187: gcov_var.file = fopen (name, "w+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@187 PS1, Line 187: gcov_var.file = fopen (name, "w+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@189 PS1, Line 189: if (!gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@189 PS1, Line 189: if (!gcov_var.file) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@190 PS1, Line 190: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@193 PS1, Line 193: gcov_var.mode = mode ? mode : 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@195 PS1, Line 195: setbuf (gcov_var.file, (char *)0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@195 PS1, Line 195: setbuf (gcov_var.file, (char *)0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@197 PS1, Line 197: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@204 PS1, Line 204: gcov_close (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@206 PS1, Line 206: if (gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@206 PS1, Line 206: if (gcov_var.file) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@206 PS1, Line 206: if (gcov_var.file) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@207 PS1, Line 207: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@209 PS1, Line 209: if (gcov_var.offset && gcov_var.mode < 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@210 PS1, Line 210: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@212 PS1, Line 212: fclose (gcov_var.file); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@212 PS1, Line 212: fclose (gcov_var.file); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@213 PS1, Line 213: gcov_var.file = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@214 PS1, Line 214: gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@215 PS1, Line 215: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@217 PS1, Line 217: free (gcov_var.buffer); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@217 PS1, Line 217: free (gcov_var.buffer); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@218 PS1, Line 218: gcov_var.alloc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@219 PS1, Line 219: gcov_var.buffer = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@221 PS1, Line 221: gcov_var.mode = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@222 PS1, Line 222: return gcov_var.error; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@231 PS1, Line 231: gcov_magic (gcov_unsigned_t magic, gcov_unsigned_t expected) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@233 PS1, Line 233: if (magic == expected) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@233 PS1, Line 233: if (magic == expected) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@234 PS1, Line 234: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@235 PS1, Line 235: magic = (magic >> 16) | (magic << 16); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@236 PS1, Line 236: magic = ((magic & 0xff00ff) << 8) | ((magic >> 8) & 0xff00ff); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@237 PS1, Line 237: if (magic == expected) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@237 PS1, Line 237: if (magic == expected) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@237 PS1, Line 237: if (magic == expected) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@238 PS1, Line 238: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@239 PS1, Line 239: gcov_var.endian = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@240 PS1, Line 240: return -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@241 PS1, Line 241: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@242 PS1, Line 242: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@248 PS1, Line 248: gcov_allocate (unsigned length) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@248 PS1, Line 248: gcov_allocate (unsigned length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@250 PS1, Line 250: size_t new_size = gcov_var.alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@252 PS1, Line 252: if (!new_size) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@252 PS1, Line 252: if (!new_size) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@253 PS1, Line 253: new_size = GCOV_BLOCK_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@254 PS1, Line 254: new_size += length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@255 PS1, Line 255: new_size *= 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@257 PS1, Line 257: gcov_var.alloc = new_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@258 PS1, Line 258: gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@258 PS1, Line 258: gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@266 PS1, Line 266: gcov_write_block (unsigned size) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@266 PS1, Line 266: gcov_write_block (unsigned size) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@268 PS1, Line 268: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@268 PS1, Line 268: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@268 PS1, Line 268: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@269 PS1, Line 269: gcov_var.error = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@270 PS1, Line 270: gcov_var.start += size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@271 PS1, Line 271: gcov_var.offset -= size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@278 PS1, Line 278: gcov_write_words (unsigned words) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@278 PS1, Line 278: gcov_write_words (unsigned words) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@280 PS1, Line 280: gcov_unsigned_t *result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@282 PS1, Line 282: gcov_nonruntime_assert (gcov_var.mode < 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@282 PS1, Line 282: gcov_nonruntime_assert (gcov_var.mode < 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@284 PS1, Line 284: if (gcov_var.offset >= GCOV_BLOCK_SIZE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@284 PS1, Line 284: if (gcov_var.offset >= GCOV_BLOCK_SIZE) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@284 PS1, Line 284: if (gcov_var.offset >= GCOV_BLOCK_SIZE) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@285 PS1, Line 285: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@286 PS1, Line 286: gcov_write_block (GCOV_BLOCK_SIZE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@286 PS1, Line 286: gcov_write_block (GCOV_BLOCK_SIZE); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@287 PS1, Line 287: if (gcov_var.offset) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@287 PS1, Line 287: if (gcov_var.offset) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@287 PS1, Line 287: if (gcov_var.offset) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@289 PS1, Line 289: memcpy (gcov_var.buffer, gcov_var.buffer + GCOV_BLOCK_SIZE, 4); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@291 PS1, Line 291: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@293 PS1, Line 293: if (gcov_var.offset + words > gcov_var.alloc) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@293 PS1, Line 293: if (gcov_var.offset + words > gcov_var.alloc) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@294 PS1, Line 294: gcov_allocate (gcov_var.offset + words); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@294 PS1, Line 294: gcov_allocate (gcov_var.offset + words); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@296 PS1, Line 296: result = &gcov_var.buffer[gcov_var.offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@297 PS1, Line 297: gcov_var.offset += words; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@299 PS1, Line 299: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@308 PS1, Line 308: gcov_unsigned_t *buffer = gcov_write_words (1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@308 PS1, Line 308: gcov_unsigned_t *buffer = gcov_write_words (1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@310 PS1, Line 310: buffer[0] = value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@318 PS1, Line 318: gcov_write_counter (gcov_type value) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@320 PS1, Line 320: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@320 PS1, Line 320: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@322 PS1, Line 322: buffer[0] = (gcov_unsigned_t) value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@323 PS1, Line 323: if (sizeof (value) > sizeof (gcov_unsigned_t)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@323 PS1, Line 323: if (sizeof (value) > sizeof (gcov_unsigned_t)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@323 PS1, Line 323: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@323 PS1, Line 323: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@324 PS1, Line 324: buffer[1] = (gcov_unsigned_t) (value >> 32); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@325 PS1, Line 325: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@325 PS1, Line 325: else suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@326 PS1, Line 326: buffer[1] = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@335 PS1, Line 335: gcov_write_string (const char *string) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@337 PS1, Line 337: unsigned length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@337 PS1, Line 337: unsigned length = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@338 PS1, Line 338: unsigned alloc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@338 PS1, Line 338: unsigned alloc = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@339 PS1, Line 339: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@341 PS1, Line 341: if (string) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@341 PS1, Line 341: if (string) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@341 PS1, Line 341: if (string) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@342 PS1, Line 342: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@343 PS1, Line 343: length = strlen (string); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@343 PS1, Line 343: length = strlen (string); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@344 PS1, Line 344: alloc = (length + 4) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@345 PS1, Line 345: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@347 PS1, Line 347: buffer = gcov_write_words (1 + alloc); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@347 PS1, Line 347: buffer = gcov_write_words (1 + alloc); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@349 PS1, Line 349: buffer[0] = alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@351 PS1, Line 351: if (alloc > 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@351 PS1, Line 351: if (alloc > 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@351 PS1, Line 351: if (alloc > 0) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@352 PS1, Line 352: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@353 PS1, Line 353: buffer[alloc] = 0; /* place nul terminators. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@354 PS1, Line 354: memcpy (&buffer[1], string, length); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@354 PS1, Line 354: memcpy (&buffer[1], string, length); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@355 PS1, Line 355: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@364 PS1, Line 364: gcov_write_filename (const char *filename) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@366 PS1, Line 366: if (profile_abs_path_flag && filename && filename[0] please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@366 PS1, Line 366: if (profile_abs_path_flag && filename && filename[0] that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@366 PS1, Line 366: if (profile_abs_path_flag && filename && filename[0] suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@367 PS1, Line 367: && !(IS_DIR_SEPARATOR (filename[0]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@367 PS1, Line 367: && !(IS_DIR_SEPARATOR (filename[0]) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@372 PS1, Line 372: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@373 PS1, Line 373: char *buf = getcwd (NULL, 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@373 PS1, Line 373: char *buf = getcwd (NULL, 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@374 PS1, Line 374: if (buf != NULL && buf[0]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@374 PS1, Line 374: if (buf != NULL && buf[0]) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@374 PS1, Line 374: if (buf != NULL && buf[0]) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@376 PS1, Line 376: size_t len = strlen (buf); Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@376 PS1, Line 376: size_t len = strlen (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@377 PS1, Line 377: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@377 PS1, Line 377: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@377 PS1, Line 377: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@378 PS1, Line 378: if (!IS_DIR_SEPARATOR (buf[len - 1])) Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@378 PS1, Line 378: if (!IS_DIR_SEPARATOR (buf[len - 1])) suspect code indent for conditional statements (10, 12)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@378 PS1, Line 378: if (!IS_DIR_SEPARATOR (buf[len - 1])) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@379 PS1, Line 379: strcat (buf, "/"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@380 PS1, Line 380: strcat (buf, filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@381 PS1, Line 381: gcov_write_string (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@382 PS1, Line 382: free (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@383 PS1, Line 383: return; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@385 PS1, Line 385: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@387 PS1, Line 387: gcov_write_string (filename); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@387 PS1, Line 387: gcov_write_string (filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@396 PS1, Line 396: gcov_write_tag (gcov_unsigned_t tag) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@398 PS1, Line 398: gcov_position_t result = gcov_var.start + gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@399 PS1, Line 399: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@399 PS1, Line 399: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@401 PS1, Line 401: buffer[0] = tag; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@402 PS1, Line 402: buffer[1] = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@404 PS1, Line 404: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@413 PS1, Line 413: gcov_write_length (gcov_position_t position) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@415 PS1, Line 415: unsigned offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@415 PS1, Line 415: unsigned offset; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@416 PS1, Line 416: gcov_unsigned_t length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@417 PS1, Line 417: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@419 PS1, Line 419: gcov_nonruntime_assert (gcov_var.mode < 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@419 PS1, Line 419: gcov_nonruntime_assert (gcov_var.mode < 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@420 PS1, Line 420: gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@420 PS1, Line 420: gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@421 PS1, Line 421: gcov_nonruntime_assert (position >= gcov_var.start); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@421 PS1, Line 421: gcov_nonruntime_assert (position >= gcov_var.start); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@422 PS1, Line 422: offset = position - gcov_var.start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@423 PS1, Line 423: length = gcov_var.offset - offset - 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@424 PS1, Line 424: buffer = (gcov_unsigned_t *) &gcov_var.buffer[offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@425 PS1, Line 425: buffer[1] = length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@426 PS1, Line 426: if (gcov_var.offset >= GCOV_BLOCK_SIZE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@426 PS1, Line 426: if (gcov_var.offset >= GCOV_BLOCK_SIZE) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@427 PS1, Line 427: gcov_write_block (gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@427 PS1, Line 427: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@435 PS1, Line 435: gcov_write_tag_length (gcov_unsigned_t tag, gcov_unsigned_t length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@437 PS1, Line 437: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@437 PS1, Line 437: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@439 PS1, Line 439: buffer[0] = tag; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@440 PS1, Line 440: buffer[1] = length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@447 PS1, Line 447: gcov_write_summary (gcov_unsigned_t tag, const struct gcov_summary *summary) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@449 PS1, Line 449: gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@449 PS1, Line 449: gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@450 PS1, Line 450: gcov_write_unsigned (summary->runs); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@451 PS1, Line 451: gcov_write_unsigned (summary->sum_max); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@462 PS1, Line 462: gcov_read_words (unsigned words) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@462 PS1, Line 462: gcov_read_words (unsigned words) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@464 PS1, Line 464: const gcov_unsigned_t *result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@465 PS1, Line 465: unsigned excess = gcov_var.length - gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@465 PS1, Line 465: unsigned excess = gcov_var.length - gcov_var.offset; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@467 PS1, Line 467: if (gcov_var.mode <= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@467 PS1, Line 467: if (gcov_var.mode <= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@468 PS1, Line 468: return NULL; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@470 PS1, Line 470: if (excess < words) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@470 PS1, Line 470: if (excess < words) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@470 PS1, Line 470: if (excess < words) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@471 PS1, Line 471: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@472 PS1, Line 472: gcov_var.start += gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@473 PS1, Line 473: if (excess) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@473 PS1, Line 473: if (excess) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@473 PS1, Line 473: if (excess) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@476 PS1, Line 476: memcpy (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, 4); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@478 PS1, Line 478: memmove (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@482 PS1, Line 482: gcov_var.offset = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@483 PS1, Line 483: gcov_var.length = excess; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@485 PS1, Line 485: excess = GCOV_BLOCK_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@487 PS1, Line 487: if (gcov_var.length + words > gcov_var.alloc) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@488 PS1, Line 488: gcov_allocate (gcov_var.length + words); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@489 PS1, Line 489: excess = gcov_var.alloc - gcov_var.length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@491 PS1, Line 491: excess = fread (gcov_var.buffer + gcov_var.length, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@491 PS1, Line 491: excess = fread (gcov_var.buffer + gcov_var.length, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@493 PS1, Line 493: gcov_var.length += excess; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@494 PS1, Line 494: if (gcov_var.length < words) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@494 PS1, Line 494: if (gcov_var.length < words) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@494 PS1, Line 494: if (gcov_var.length < words) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@498 PS1, Line 498: return 0; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@500 PS1, Line 500: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@501 PS1, Line 501: result = &gcov_var.buffer[gcov_var.offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@502 PS1, Line 502: gcov_var.offset += words; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@503 PS1, Line 503: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@512 PS1, Line 512: gcov_unsigned_t value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@513 PS1, Line 513: const gcov_unsigned_t *buffer = gcov_read_words (1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@513 PS1, Line 513: const gcov_unsigned_t *buffer = gcov_read_words (1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@515 PS1, Line 515: if (!buffer) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@515 PS1, Line 515: if (!buffer) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@516 PS1, Line 516: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@517 PS1, Line 517: value = from_file (buffer[0]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@517 PS1, Line 517: value = from_file (buffer[0]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@518 PS1, Line 518: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@525 PS1, Line 525: gcov_read_counter (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@527 PS1, Line 527: gcov_type value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@528 PS1, Line 528: const gcov_unsigned_t *buffer = gcov_read_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@528 PS1, Line 528: const gcov_unsigned_t *buffer = gcov_read_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@530 PS1, Line 530: if (!buffer) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@530 PS1, Line 530: if (!buffer) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@531 PS1, Line 531: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@532 PS1, Line 532: value = from_file (buffer[0]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@532 PS1, Line 532: value = from_file (buffer[0]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@533 PS1, Line 533: if (sizeof (value) > sizeof (gcov_unsigned_t)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@533 PS1, Line 533: if (sizeof (value) > sizeof (gcov_unsigned_t)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@533 PS1, Line 533: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@533 PS1, Line 533: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@534 PS1, Line 534: value |= ((gcov_type) from_file (buffer[1])) << 32; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@534 PS1, Line 534: value |= ((gcov_type) from_file (buffer[1])) << 32; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@535 PS1, Line 535: else if (buffer[1]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@535 PS1, Line 535: else if (buffer[1]) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@536 PS1, Line 536: gcov_var.error = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@538 PS1, Line 538: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@545 PS1, Line 545: mangle_path (char const *base) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@549 PS1, Line 549: const char *probe; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@550 PS1, Line 550: char *buffer = (char *)xmalloc (strlen (base) + 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@550 PS1, Line 550: char *buffer = (char *)xmalloc (strlen (base) + 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@550 PS1, Line 550: char *buffer = (char *)xmalloc (strlen (base) + 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@551 PS1, Line 551: char *ptr = buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@554 PS1, Line 554: if (base[0] && base[1] == ':') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@554 PS1, Line 554: if (base[0] && base[1] == ':') that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@554 PS1, Line 554: if (base[0] && base[1] == ':') suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@555 PS1, Line 555: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@556 PS1, Line 556: ptr[0] = base[0]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@557 PS1, Line 557: ptr[1] = '~'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@558 PS1, Line 558: ptr += 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@559 PS1, Line 559: base += 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@560 PS1, Line 560: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@562 PS1, Line 562: for (; *base; base = probe) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@562 PS1, Line 562: for (; *base; base = probe) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@562 PS1, Line 562: for (; *base; base = probe) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@563 PS1, Line 563: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@564 PS1, Line 564: size_t len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@566 PS1, Line 566: for (probe = base; *probe; probe++) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@567 PS1, Line 567: if (*probe == '/') suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@568 PS1, Line 568: break; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@569 PS1, Line 569: len = probe - base; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@570 PS1, Line 570: if (len == 2 && base[0] == '.' && base[1] == '.') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@572 PS1, Line 572: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@572 PS1, Line 572: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@572 PS1, Line 572: else suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@574 PS1, Line 574: memcpy (ptr, base, len); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@577 PS1, Line 577: if (*probe) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@577 PS1, Line 577: if (*probe) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@577 PS1, Line 577: if (*probe) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@582 PS1, Line 582: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@585 PS1, Line 585: *ptr = '\0'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@587 PS1, Line 587: return buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@592 PS1, Line 592: #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@598 PS1, Line 598: gcov_read_string (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@600 PS1, Line 600: unsigned length = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@600 PS1, Line 600: unsigned length = gcov_read_unsigned (); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@602 PS1, Line 602: if (!length) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@602 PS1, Line 602: if (!length) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@603 PS1, Line 603: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@605 PS1, Line 605: return (const char *) gcov_read_words (length); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@605 PS1, Line 605: return (const char *) gcov_read_words (length); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@610 PS1, Line 610: gcov_read_summary (struct gcov_summary *summary) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@612 PS1, Line 612: summary->runs = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@613 PS1, Line 613: summary->sum_max = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@618 PS1, Line 618: #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@623 PS1, Line 623: gcov_sync (gcov_position_t base, gcov_unsigned_t length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@625 PS1, Line 625: gcov_nonruntime_assert (gcov_var.mode > 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@625 PS1, Line 625: gcov_nonruntime_assert (gcov_var.mode > 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@626 PS1, Line 626: base += length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@627 PS1, Line 627: if (base - gcov_var.start <= gcov_var.length) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@627 PS1, Line 627: if (base - gcov_var.start <= gcov_var.length) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@628 PS1, Line 628: gcov_var.offset = base - gcov_var.start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@629 PS1, Line 629: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@629 PS1, Line 629: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@629 PS1, Line 629: else suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@630 PS1, Line 630: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@631 PS1, Line 631: gcov_var.offset = gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@632 PS1, Line 632: fseek (gcov_var.file, base << 2, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@632 PS1, Line 632: fseek (gcov_var.file, base << 2, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@633 PS1, Line 633: gcov_var.start = ftell (gcov_var.file) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@633 PS1, Line 633: gcov_var.start = ftell (gcov_var.file) >> 2; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@634 PS1, Line 634: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@642 PS1, Line 642: gcov_seek (gcov_position_t base) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@644 PS1, Line 644: if (gcov_var.offset) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@644 PS1, Line 644: if (gcov_var.offset) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@645 PS1, Line 645: gcov_write_block (gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@645 PS1, Line 645: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@646 PS1, Line 646: fseek (gcov_var.file, base << 2, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@646 PS1, Line 646: fseek (gcov_var.file, base << 2, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@647 PS1, Line 647: gcov_var.start = ftell (gcov_var.file) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@647 PS1, Line 647: gcov_var.start = ftell (gcov_var.file) >> 2; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@655 PS1, Line 655: gcov_time (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@657 PS1, Line 657: struct stat status; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@659 PS1, Line 659: if (fstat (fileno (gcov_var.file), &status)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@659 PS1, Line 659: if (fstat (fileno (gcov_var.file), &status)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@659 PS1, Line 659: if (fstat (fileno (gcov_var.file), &status)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@659 PS1, Line 659: if (fstat (fileno (gcov_var.file), &status)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@660 PS1, Line 660: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@661 PS1, Line 661: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@661 PS1, Line 661: else suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/1/src/lib/gcov-io.c@662 PS1, Line 662: return status.st_mtime; please, no spaces at the start of a line
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40013
to look at the new patch set (#2).
Change subject: src/lib: Update gcov-io.[ch] (test) ......................................................................
src/lib: Update gcov-io.[ch] (test)
Change-Id: Iacdbd3ad563e13aea0718689bc4f6e5ac6a80cfc Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/lib/gcov-io.c M src/lib/gcov-io.h 2 files changed, 514 insertions(+), 643 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40013/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40013 )
Change subject: src/lib: Update gcov-io.[ch] (test) ......................................................................
Patch Set 2:
(534 comments)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h File src/lib/gcov-io.h:
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@47 PS2, Line 47: The basic format of the notes file is please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@51 PS2, Line 51: The basic format of the data file is please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@53 PS2, Line 53: file : int32:magic int32:version int32:stamp record* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@53 PS2, Line 53: file : int32:magic int32:version int32:stamp record* please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@53 PS2, Line 53: file : int32:magic int32:version int32:stamp record* please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@66 PS2, Line 66: consists of a two character major version number please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@67 PS2, Line 67: (first digit starts from 'A' letter to not to clash with the older please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@68 PS2, Line 68: numbering scheme), the single character minor version number, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@69 PS2, Line 69: and a single character indicating the status of the release. please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@74 PS2, Line 74: incompatible with itself. For gcc 17.0 experimental, it would be please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@75 PS2, Line 75: 'B70e' (0x42373065). As we currently do not release more than 5 minor please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@76 PS2, Line 76: releases, the single character should be always fine. Major number please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@77 PS2, Line 77: is currently changed roughly every year, which gives us space please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@78 PS2, Line 78: for next 250 years (maximum allowed number would be 259.9). please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@78 PS2, Line 78: for next 250 years (maximum allowed number would be 259.9). space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@101 PS2, Line 101: The notes file contains the following records please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@107 PS2, Line 107: string:name string:source int32:start_lineno int32:start_column int32:end_lineno labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@111 PS2, Line 111: lines: header int32:block_no line* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@111 PS2, Line 111: lines: header int32:block_no line* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@111 PS2, Line 111: lines: header int32:block_no line* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@112 PS2, Line 112: int32:0 string:NULL code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@132 PS2, Line 132: data: {unit summary:object function-data*}* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@132 PS2, Line 132: data: {unit summary:object function-data*}* space required before that '*' (ctx:VxE)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@132 PS2, Line 132: data: {unit summary:object function-data*}* space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@132 PS2, Line 132: data: {unit summary:object function-data*}* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@139 PS2, Line 139: summary: int32:checksum int32:runs int32:sum_max spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@139 PS2, Line 139: summary: int32:checksum int32:runs int32:sum_max labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@184 PS2, Line 184: typedef unsigned gcov_unsigned_t; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@185 PS2, Line 185: typedef unsigned gcov_position_t; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@196 PS2, Line 196: #if defined (HOST_HAS_F_SETLKW) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@213 PS2, Line 213: #define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@213 PS2, Line 213: #define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@214 PS2, Line 214: #define gcov_error(...) fatal_error (input_location, __VA_ARGS__) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@214 PS2, Line 214: #define gcov_error(...) fatal_error (input_location, __VA_ARGS__) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@227 PS2, Line 227: #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@227 PS2, Line 227: #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@232 PS2, Line 232: #define GCOV_UNSIGNED2STRING(ARRAY,VALUE) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@233 PS2, Line 233: ((ARRAY)[0] = (char)((VALUE) >> 24), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@234 PS2, Line 234: (ARRAY)[1] = (char)((VALUE) >> 16), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@235 PS2, Line 235: (ARRAY)[2] = (char)((VALUE) >> 8), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@236 PS2, Line 236: (ARRAY)[3] = (char)((VALUE) >> 0)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@251 PS2, Line 251: #define GCOV_TAG_COUNTER_BASE ((gcov_unsigned_t)0x01a10000) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@281 PS2, Line 281: (GCOV_LAST_VALUE_COUNTER - GCOV_FIRST_VALUE_COUNTER + 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@294 PS2, Line 294: ((unsigned)(((TAG) - GCOV_TAG_COUNTER_BASE) >> 17)) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@297 PS2, Line 297: (!((TAG) & 0xFFFF) && GCOV_COUNTER_FOR_TAG (TAG) < GCOV_COUNTERS) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@305 PS2, Line 305: #define GCOV_TAG_IS_SUBTAG(TAG,SUB) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@306 PS2, Line 306: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@306 PS2, Line 306: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@306 PS2, Line 306: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@307 PS2, Line 307: && !(((SUB) ^ (TAG)) & ~GCOV_TAG_MASK (TAG))) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@310 PS2, Line 310: #define GCOV_TAG_IS_SUBLEVEL(TAG,SUB) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@317 PS2, Line 317: #define GCOV_ARC_ON_TREE (1 << 0) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@324 PS2, Line 324: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@325 PS2, Line 325: gcov_unsigned_t runs; /* Number of program runs. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@326 PS2, Line 326: gcov_type sum_max; /* Sum of individual run max values. */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@326 PS2, Line 326: gcov_type sum_max; /* Sum of individual run max values. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@342 PS2, Line 342: GCOV_LINKAGE int gcov_open (const char */*name*/, int /*direction*/); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@343 PS2, Line 343: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@343 PS2, Line 343: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@343 PS2, Line 343: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@347 PS2, Line 347: GCOV_LINKAGE int gcov_close (void) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@349 PS2, Line 349: GCOV_LINKAGE gcov_type gcov_read_counter (void) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@350 PS2, Line 350: GCOV_LINKAGE void gcov_read_summary (struct gcov_summary *) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@351 PS2, Line 351: GCOV_LINKAGE const char *gcov_read_string (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@352 PS2, Line 352: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@352 PS2, Line 352: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, function definition argument 'gcov_position_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@352 PS2, Line 352: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@354 PS2, Line 354: char *mangle_path (char const *base); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@363 PS2, Line 363: GCOV_LINKAGE void gcov_write_string (const char *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@364 PS2, Line 364: GCOV_LINKAGE void gcov_write_filename (const char *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@364 PS2, Line 364: GCOV_LINKAGE void gcov_write_filename (const char *); function definition argument 'const char *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@365 PS2, Line 365: GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@365 PS2, Line 365: GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@366 PS2, Line 366: GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@366 PS2, Line 366: GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); function definition argument 'gcov_position_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@371 PS2, Line 371: GCOV_LINKAGE time_t gcov_time (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c File src/lib/gcov-io.c:
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@27 PS2, Line 27: static void gcov_write_block (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@27 PS2, Line 27: static void gcov_write_block (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@28 PS2, Line 28: static gcov_unsigned_t *gcov_write_words (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@28 PS2, Line 28: static gcov_unsigned_t *gcov_write_words (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@30 PS2, Line 30: static const gcov_unsigned_t *gcov_read_words (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@30 PS2, Line 30: static const gcov_unsigned_t *gcov_read_words (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@32 PS2, Line 32: static void gcov_allocate (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@32 PS2, Line 32: static void gcov_allocate (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@39 PS2, Line 39: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@40 PS2, Line 40: FILE *file; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@41 PS2, Line 41: gcov_position_t start; /* Position of first byte of block */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@42 PS2, Line 42: unsigned offset; /* Read/write position within the block. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@42 PS2, Line 42: unsigned offset; /* Read/write position within the block. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@43 PS2, Line 43: unsigned length; /* Read limit in the block. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@43 PS2, Line 43: unsigned length; /* Read limit in the block. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@44 PS2, Line 44: unsigned overread; /* Number of words overread. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@44 PS2, Line 44: unsigned overread; /* Number of words overread. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@45 PS2, Line 45: int error; /* < 0 overflow, > 0 disk error. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@46 PS2, Line 46: int mode; /* < 0 writing, > 0 reading */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@52 PS2, Line 52: gcov_unsigned_t buffer[GCOV_BLOCK_SIZE + 1]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@54 PS2, Line 54: int endian; /* Swap endianness. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@57 PS2, Line 57: size_t alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@58 PS2, Line 58: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@68 PS2, Line 68: gcov_position (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@70 PS2, Line 70: gcov_nonruntime_assert (gcov_var.mode > 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@70 PS2, Line 70: gcov_nonruntime_assert (gcov_var.mode > 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@71 PS2, Line 71: return gcov_var.start + gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@80 PS2, Line 80: gcov_is_error (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@82 PS2, Line 82: return gcov_var.file ? gcov_var.error : 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@88 PS2, Line 88: gcov_rewrite (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@90 PS2, Line 90: gcov_var.mode = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@91 PS2, Line 91: gcov_var.start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@92 PS2, Line 92: gcov_var.offset = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@93 PS2, Line 93: fseek (gcov_var.file, 0L, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@93 PS2, Line 93: fseek (gcov_var.file, 0L, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@97 PS2, Line 97: static inline gcov_unsigned_t from_file (gcov_unsigned_t value) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@100 PS2, Line 100: if (gcov_var.endian) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@100 PS2, Line 100: if (gcov_var.endian) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@100 PS2, Line 100: if (gcov_var.endian) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@101 PS2, Line 101: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@102 PS2, Line 102: value = (value >> 16) | (value << 16); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@103 PS2, Line 103: value = ((value & 0xff00ff) << 8) | ((value >> 8) & 0xff00ff); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@104 PS2, Line 104: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@106 PS2, Line 106: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@120 PS2, Line 120: gcov_open (const char *name) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@122 PS2, Line 122: gcov_open (const char *name, int mode) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@126 PS2, Line 126: int mode = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@129 PS2, Line 129: struct flock s_flock; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@130 PS2, Line 130: int fd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@132 PS2, Line 132: s_flock.l_whence = SEEK_SET; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@133 PS2, Line 133: s_flock.l_start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@134 PS2, Line 134: s_flock.l_len = 0; /* Until EOF. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@135 PS2, Line 135: s_flock.l_pid = getpid (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@135 PS2, Line 135: s_flock.l_pid = getpid (); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@138 PS2, Line 138: gcov_nonruntime_assert (!gcov_var.file); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@138 PS2, Line 138: gcov_nonruntime_assert (!gcov_var.file); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@139 PS2, Line 139: gcov_var.start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@140 PS2, Line 140: gcov_var.offset = gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@141 PS2, Line 141: gcov_var.overread = -1u; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@142 PS2, Line 142: gcov_var.error = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@144 PS2, Line 144: gcov_var.endian = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@147 PS2, Line 147: if (mode > 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@147 PS2, Line 147: if (mode > 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@147 PS2, Line 147: if (mode > 0) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@148 PS2, Line 148: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@150 PS2, Line 150: s_flock.l_type = F_RDLCK; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@152 PS2, Line 152: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@152 PS2, Line 152: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@152 PS2, Line 152: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@153 PS2, Line 153: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@154 PS2, Line 154: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@154 PS2, Line 154: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@154 PS2, Line 154: else suspect code indent for conditional statements (2, 7)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@155 PS2, Line 155: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@157 PS2, Line 157: s_flock.l_type = F_WRLCK; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@159 PS2, Line 159: fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@159 PS2, Line 159: fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@160 PS2, Line 160: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@161 PS2, Line 161: if (fd < 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@161 PS2, Line 161: if (fd < 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@162 PS2, Line 162: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@164 PS2, Line 164: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@164 PS2, Line 164: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@164 PS2, Line 164: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@165 PS2, Line 165: continue; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@167 PS2, Line 167: gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@167 PS2, Line 167: gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@169 PS2, Line 169: if (!gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@169 PS2, Line 169: if (!gcov_var.file) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@169 PS2, Line 169: if (!gcov_var.file) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@170 PS2, Line 170: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@171 PS2, Line 171: close (fd); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@171 PS2, Line 171: close (fd); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@172 PS2, Line 172: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@173 PS2, Line 173: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@175 PS2, Line 175: if (mode >= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@175 PS2, Line 175: if (mode >= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@177 PS2, Line 177: gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@177 PS2, Line 177: gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@179 PS2, Line 179: if (gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@179 PS2, Line 179: if (gcov_var.file) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@180 PS2, Line 180: mode = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@181 PS2, Line 181: else if (mode <= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@181 PS2, Line 181: else if (mode <= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@183 PS2, Line 183: gcov_var.file = fopen (name, "w+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@183 PS2, Line 183: gcov_var.file = fopen (name, "w+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@185 PS2, Line 185: if (!gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@185 PS2, Line 185: if (!gcov_var.file) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@186 PS2, Line 186: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@189 PS2, Line 189: gcov_var.mode = mode ? mode : 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@191 PS2, Line 191: setbuf (gcov_var.file, (char *)0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@191 PS2, Line 191: setbuf (gcov_var.file, (char *)0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@193 PS2, Line 193: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@200 PS2, Line 200: gcov_close (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@202 PS2, Line 202: if (gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@202 PS2, Line 202: if (gcov_var.file) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@202 PS2, Line 202: if (gcov_var.file) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@203 PS2, Line 203: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@205 PS2, Line 205: if (gcov_var.offset && gcov_var.mode < 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@206 PS2, Line 206: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@208 PS2, Line 208: fclose (gcov_var.file); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@208 PS2, Line 208: fclose (gcov_var.file); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@209 PS2, Line 209: gcov_var.file = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@210 PS2, Line 210: gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@211 PS2, Line 211: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@213 PS2, Line 213: free (gcov_var.buffer); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@213 PS2, Line 213: free (gcov_var.buffer); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@214 PS2, Line 214: gcov_var.alloc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@215 PS2, Line 215: gcov_var.buffer = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@217 PS2, Line 217: gcov_var.mode = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@218 PS2, Line 218: return gcov_var.error; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@227 PS2, Line 227: gcov_magic (gcov_unsigned_t magic, gcov_unsigned_t expected) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@229 PS2, Line 229: if (magic == expected) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@229 PS2, Line 229: if (magic == expected) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@230 PS2, Line 230: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@231 PS2, Line 231: magic = (magic >> 16) | (magic << 16); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@232 PS2, Line 232: magic = ((magic & 0xff00ff) << 8) | ((magic >> 8) & 0xff00ff); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@233 PS2, Line 233: if (magic == expected) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@233 PS2, Line 233: if (magic == expected) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@233 PS2, Line 233: if (magic == expected) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@234 PS2, Line 234: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@235 PS2, Line 235: gcov_var.endian = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@236 PS2, Line 236: return -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@237 PS2, Line 237: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@238 PS2, Line 238: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@244 PS2, Line 244: gcov_allocate (unsigned length) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@244 PS2, Line 244: gcov_allocate (unsigned length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@246 PS2, Line 246: size_t new_size = gcov_var.alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@248 PS2, Line 248: if (!new_size) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@248 PS2, Line 248: if (!new_size) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@249 PS2, Line 249: new_size = GCOV_BLOCK_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@250 PS2, Line 250: new_size += length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@251 PS2, Line 251: new_size *= 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@253 PS2, Line 253: gcov_var.alloc = new_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@254 PS2, Line 254: gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@254 PS2, Line 254: gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@262 PS2, Line 262: gcov_write_block (unsigned size) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@262 PS2, Line 262: gcov_write_block (unsigned size) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@264 PS2, Line 264: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@264 PS2, Line 264: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@264 PS2, Line 264: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@265 PS2, Line 265: gcov_var.error = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@266 PS2, Line 266: gcov_var.start += size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@267 PS2, Line 267: gcov_var.offset -= size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@274 PS2, Line 274: gcov_write_words (unsigned words) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@274 PS2, Line 274: gcov_write_words (unsigned words) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@276 PS2, Line 276: gcov_unsigned_t *result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@278 PS2, Line 278: gcov_nonruntime_assert (gcov_var.mode < 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@278 PS2, Line 278: gcov_nonruntime_assert (gcov_var.mode < 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@280 PS2, Line 280: if (gcov_var.offset >= GCOV_BLOCK_SIZE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@280 PS2, Line 280: if (gcov_var.offset >= GCOV_BLOCK_SIZE) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@280 PS2, Line 280: if (gcov_var.offset >= GCOV_BLOCK_SIZE) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@281 PS2, Line 281: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@282 PS2, Line 282: gcov_write_block (GCOV_BLOCK_SIZE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@282 PS2, Line 282: gcov_write_block (GCOV_BLOCK_SIZE); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@283 PS2, Line 283: if (gcov_var.offset) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@283 PS2, Line 283: if (gcov_var.offset) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@283 PS2, Line 283: if (gcov_var.offset) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@285 PS2, Line 285: memcpy (gcov_var.buffer, gcov_var.buffer + GCOV_BLOCK_SIZE, 4); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@287 PS2, Line 287: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@289 PS2, Line 289: if (gcov_var.offset + words > gcov_var.alloc) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@289 PS2, Line 289: if (gcov_var.offset + words > gcov_var.alloc) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@290 PS2, Line 290: gcov_allocate (gcov_var.offset + words); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@290 PS2, Line 290: gcov_allocate (gcov_var.offset + words); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@292 PS2, Line 292: result = &gcov_var.buffer[gcov_var.offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@293 PS2, Line 293: gcov_var.offset += words; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@295 PS2, Line 295: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@304 PS2, Line 304: gcov_unsigned_t *buffer = gcov_write_words (1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@304 PS2, Line 304: gcov_unsigned_t *buffer = gcov_write_words (1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@306 PS2, Line 306: buffer[0] = value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@314 PS2, Line 314: gcov_write_counter (gcov_type value) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@316 PS2, Line 316: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@316 PS2, Line 316: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@318 PS2, Line 318: buffer[0] = (gcov_unsigned_t) value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@319 PS2, Line 319: if (sizeof (value) > sizeof (gcov_unsigned_t)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@319 PS2, Line 319: if (sizeof (value) > sizeof (gcov_unsigned_t)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@319 PS2, Line 319: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@319 PS2, Line 319: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@320 PS2, Line 320: buffer[1] = (gcov_unsigned_t) (value >> 32); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@321 PS2, Line 321: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@321 PS2, Line 321: else suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@322 PS2, Line 322: buffer[1] = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@331 PS2, Line 331: gcov_write_string (const char *string) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@333 PS2, Line 333: unsigned length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@333 PS2, Line 333: unsigned length = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@334 PS2, Line 334: unsigned alloc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@334 PS2, Line 334: unsigned alloc = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@335 PS2, Line 335: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@337 PS2, Line 337: if (string) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@337 PS2, Line 337: if (string) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@337 PS2, Line 337: if (string) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@338 PS2, Line 338: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@339 PS2, Line 339: length = strlen (string); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@339 PS2, Line 339: length = strlen (string); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@340 PS2, Line 340: alloc = (length + 4) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@341 PS2, Line 341: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@343 PS2, Line 343: buffer = gcov_write_words (1 + alloc); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@343 PS2, Line 343: buffer = gcov_write_words (1 + alloc); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@345 PS2, Line 345: buffer[0] = alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@347 PS2, Line 347: if (alloc > 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@347 PS2, Line 347: if (alloc > 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@347 PS2, Line 347: if (alloc > 0) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@348 PS2, Line 348: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@349 PS2, Line 349: buffer[alloc] = 0; /* place nul terminators. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@350 PS2, Line 350: memcpy (&buffer[1], string, length); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@350 PS2, Line 350: memcpy (&buffer[1], string, length); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@351 PS2, Line 351: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@360 PS2, Line 360: gcov_write_filename (const char *filename) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@362 PS2, Line 362: if (profile_abs_path_flag && filename && filename[0] please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@362 PS2, Line 362: if (profile_abs_path_flag && filename && filename[0] that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@362 PS2, Line 362: if (profile_abs_path_flag && filename && filename[0] suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@363 PS2, Line 363: && !(IS_DIR_SEPARATOR (filename[0]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@363 PS2, Line 363: && !(IS_DIR_SEPARATOR (filename[0]) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@368 PS2, Line 368: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@369 PS2, Line 369: char *buf = getcwd (NULL, 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@369 PS2, Line 369: char *buf = getcwd (NULL, 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@370 PS2, Line 370: if (buf != NULL && buf[0]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@370 PS2, Line 370: if (buf != NULL && buf[0]) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@370 PS2, Line 370: if (buf != NULL && buf[0]) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@372 PS2, Line 372: size_t len = strlen (buf); Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@372 PS2, Line 372: size_t len = strlen (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@373 PS2, Line 373: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@373 PS2, Line 373: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@373 PS2, Line 373: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@374 PS2, Line 374: if (!IS_DIR_SEPARATOR (buf[len - 1])) Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@374 PS2, Line 374: if (!IS_DIR_SEPARATOR (buf[len - 1])) suspect code indent for conditional statements (10, 12)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@374 PS2, Line 374: if (!IS_DIR_SEPARATOR (buf[len - 1])) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@375 PS2, Line 375: strcat (buf, "/"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@376 PS2, Line 376: strcat (buf, filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@377 PS2, Line 377: gcov_write_string (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@378 PS2, Line 378: free (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@379 PS2, Line 379: return; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@381 PS2, Line 381: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@383 PS2, Line 383: gcov_write_string (filename); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@383 PS2, Line 383: gcov_write_string (filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@392 PS2, Line 392: gcov_write_tag (gcov_unsigned_t tag) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@394 PS2, Line 394: gcov_position_t result = gcov_var.start + gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@395 PS2, Line 395: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@395 PS2, Line 395: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@397 PS2, Line 397: buffer[0] = tag; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@398 PS2, Line 398: buffer[1] = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@400 PS2, Line 400: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@409 PS2, Line 409: gcov_write_length (gcov_position_t position) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@411 PS2, Line 411: unsigned offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@411 PS2, Line 411: unsigned offset; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@412 PS2, Line 412: gcov_unsigned_t length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@413 PS2, Line 413: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@415 PS2, Line 415: gcov_nonruntime_assert (gcov_var.mode < 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@415 PS2, Line 415: gcov_nonruntime_assert (gcov_var.mode < 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@416 PS2, Line 416: gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@416 PS2, Line 416: gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@417 PS2, Line 417: gcov_nonruntime_assert (position >= gcov_var.start); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@417 PS2, Line 417: gcov_nonruntime_assert (position >= gcov_var.start); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@418 PS2, Line 418: offset = position - gcov_var.start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@419 PS2, Line 419: length = gcov_var.offset - offset - 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@420 PS2, Line 420: buffer = (gcov_unsigned_t *) &gcov_var.buffer[offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@421 PS2, Line 421: buffer[1] = length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@422 PS2, Line 422: if (gcov_var.offset >= GCOV_BLOCK_SIZE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@422 PS2, Line 422: if (gcov_var.offset >= GCOV_BLOCK_SIZE) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@423 PS2, Line 423: gcov_write_block (gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@423 PS2, Line 423: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@431 PS2, Line 431: gcov_write_tag_length (gcov_unsigned_t tag, gcov_unsigned_t length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@433 PS2, Line 433: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@433 PS2, Line 433: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@435 PS2, Line 435: buffer[0] = tag; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@436 PS2, Line 436: buffer[1] = length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@443 PS2, Line 443: gcov_write_summary (gcov_unsigned_t tag, const struct gcov_summary *summary) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@445 PS2, Line 445: gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@445 PS2, Line 445: gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@446 PS2, Line 446: gcov_write_unsigned (summary->runs); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@447 PS2, Line 447: gcov_write_unsigned (summary->sum_max); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@458 PS2, Line 458: gcov_read_words (unsigned words) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@458 PS2, Line 458: gcov_read_words (unsigned words) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@460 PS2, Line 460: const gcov_unsigned_t *result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@461 PS2, Line 461: unsigned excess = gcov_var.length - gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@461 PS2, Line 461: unsigned excess = gcov_var.length - gcov_var.offset; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@463 PS2, Line 463: if (gcov_var.mode <= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@463 PS2, Line 463: if (gcov_var.mode <= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@464 PS2, Line 464: return NULL; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@466 PS2, Line 466: if (excess < words) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@466 PS2, Line 466: if (excess < words) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@466 PS2, Line 466: if (excess < words) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@467 PS2, Line 467: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@468 PS2, Line 468: gcov_var.start += gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@469 PS2, Line 469: if (excess) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@469 PS2, Line 469: if (excess) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@469 PS2, Line 469: if (excess) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@472 PS2, Line 472: memcpy (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, 4); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@474 PS2, Line 474: memmove (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@478 PS2, Line 478: gcov_var.offset = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@479 PS2, Line 479: gcov_var.length = excess; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@481 PS2, Line 481: excess = GCOV_BLOCK_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@483 PS2, Line 483: if (gcov_var.length + words > gcov_var.alloc) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@484 PS2, Line 484: gcov_allocate (gcov_var.length + words); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@485 PS2, Line 485: excess = gcov_var.alloc - gcov_var.length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@487 PS2, Line 487: excess = fread (gcov_var.buffer + gcov_var.length, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@487 PS2, Line 487: excess = fread (gcov_var.buffer + gcov_var.length, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@489 PS2, Line 489: gcov_var.length += excess; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@490 PS2, Line 490: if (gcov_var.length < words) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@490 PS2, Line 490: if (gcov_var.length < words) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@490 PS2, Line 490: if (gcov_var.length < words) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@494 PS2, Line 494: return 0; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@496 PS2, Line 496: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@497 PS2, Line 497: result = &gcov_var.buffer[gcov_var.offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@498 PS2, Line 498: gcov_var.offset += words; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@499 PS2, Line 499: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@508 PS2, Line 508: gcov_unsigned_t value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@509 PS2, Line 509: const gcov_unsigned_t *buffer = gcov_read_words (1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@509 PS2, Line 509: const gcov_unsigned_t *buffer = gcov_read_words (1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@511 PS2, Line 511: if (!buffer) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@511 PS2, Line 511: if (!buffer) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@512 PS2, Line 512: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@513 PS2, Line 513: value = from_file (buffer[0]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@513 PS2, Line 513: value = from_file (buffer[0]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@514 PS2, Line 514: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@521 PS2, Line 521: gcov_read_counter (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@523 PS2, Line 523: gcov_type value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@524 PS2, Line 524: const gcov_unsigned_t *buffer = gcov_read_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@524 PS2, Line 524: const gcov_unsigned_t *buffer = gcov_read_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@526 PS2, Line 526: if (!buffer) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@526 PS2, Line 526: if (!buffer) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@527 PS2, Line 527: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@528 PS2, Line 528: value = from_file (buffer[0]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@528 PS2, Line 528: value = from_file (buffer[0]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@529 PS2, Line 529: if (sizeof (value) > sizeof (gcov_unsigned_t)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@529 PS2, Line 529: if (sizeof (value) > sizeof (gcov_unsigned_t)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@529 PS2, Line 529: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@529 PS2, Line 529: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@530 PS2, Line 530: value |= ((gcov_type) from_file (buffer[1])) << 32; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@530 PS2, Line 530: value |= ((gcov_type) from_file (buffer[1])) << 32; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@531 PS2, Line 531: else if (buffer[1]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@531 PS2, Line 531: else if (buffer[1]) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@532 PS2, Line 532: gcov_var.error = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@534 PS2, Line 534: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@541 PS2, Line 541: mangle_path (char const *base) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@545 PS2, Line 545: const char *probe; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@546 PS2, Line 546: char *buffer = (char *)xmalloc (strlen (base) + 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@546 PS2, Line 546: char *buffer = (char *)xmalloc (strlen (base) + 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@546 PS2, Line 546: char *buffer = (char *)xmalloc (strlen (base) + 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@547 PS2, Line 547: char *ptr = buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@550 PS2, Line 550: if (base[0] && base[1] == ':') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@550 PS2, Line 550: if (base[0] && base[1] == ':') that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@550 PS2, Line 550: if (base[0] && base[1] == ':') suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@551 PS2, Line 551: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@552 PS2, Line 552: ptr[0] = base[0]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@553 PS2, Line 553: ptr[1] = '~'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@554 PS2, Line 554: ptr += 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@555 PS2, Line 555: base += 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@556 PS2, Line 556: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@558 PS2, Line 558: for (; *base; base = probe) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@558 PS2, Line 558: for (; *base; base = probe) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@558 PS2, Line 558: for (; *base; base = probe) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@559 PS2, Line 559: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@560 PS2, Line 560: size_t len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@562 PS2, Line 562: for (probe = base; *probe; probe++) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@563 PS2, Line 563: if (*probe == '/') suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@564 PS2, Line 564: break; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@565 PS2, Line 565: len = probe - base; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@566 PS2, Line 566: if (len == 2 && base[0] == '.' && base[1] == '.') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@568 PS2, Line 568: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@568 PS2, Line 568: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@568 PS2, Line 568: else suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@570 PS2, Line 570: memcpy (ptr, base, len); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@573 PS2, Line 573: if (*probe) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@573 PS2, Line 573: if (*probe) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@573 PS2, Line 573: if (*probe) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@578 PS2, Line 578: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@581 PS2, Line 581: *ptr = '\0'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@583 PS2, Line 583: return buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@588 PS2, Line 588: #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@594 PS2, Line 594: gcov_read_string (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@596 PS2, Line 596: unsigned length = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@596 PS2, Line 596: unsigned length = gcov_read_unsigned (); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@598 PS2, Line 598: if (!length) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@598 PS2, Line 598: if (!length) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@599 PS2, Line 599: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@601 PS2, Line 601: return (const char *) gcov_read_words (length); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@601 PS2, Line 601: return (const char *) gcov_read_words (length); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@606 PS2, Line 606: gcov_read_summary (struct gcov_summary *summary) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@608 PS2, Line 608: summary->runs = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@609 PS2, Line 609: summary->sum_max = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@614 PS2, Line 614: #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@619 PS2, Line 619: gcov_sync (gcov_position_t base, gcov_unsigned_t length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@621 PS2, Line 621: gcov_nonruntime_assert (gcov_var.mode > 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@621 PS2, Line 621: gcov_nonruntime_assert (gcov_var.mode > 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@622 PS2, Line 622: base += length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@623 PS2, Line 623: if (base - gcov_var.start <= gcov_var.length) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@623 PS2, Line 623: if (base - gcov_var.start <= gcov_var.length) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@624 PS2, Line 624: gcov_var.offset = base - gcov_var.start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@625 PS2, Line 625: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@625 PS2, Line 625: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@625 PS2, Line 625: else suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@626 PS2, Line 626: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@627 PS2, Line 627: gcov_var.offset = gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@628 PS2, Line 628: fseek (gcov_var.file, base << 2, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@628 PS2, Line 628: fseek (gcov_var.file, base << 2, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@629 PS2, Line 629: gcov_var.start = ftell (gcov_var.file) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@629 PS2, Line 629: gcov_var.start = ftell (gcov_var.file) >> 2; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@630 PS2, Line 630: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@638 PS2, Line 638: gcov_seek (gcov_position_t base) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@640 PS2, Line 640: if (gcov_var.offset) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@640 PS2, Line 640: if (gcov_var.offset) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@641 PS2, Line 641: gcov_write_block (gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@641 PS2, Line 641: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@642 PS2, Line 642: fseek (gcov_var.file, base << 2, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@642 PS2, Line 642: fseek (gcov_var.file, base << 2, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@643 PS2, Line 643: gcov_var.start = ftell (gcov_var.file) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@643 PS2, Line 643: gcov_var.start = ftell (gcov_var.file) >> 2; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@651 PS2, Line 651: gcov_time (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@653 PS2, Line 653: struct stat status; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@655 PS2, Line 655: if (fstat (fileno (gcov_var.file), &status)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@655 PS2, Line 655: if (fstat (fileno (gcov_var.file), &status)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@655 PS2, Line 655: if (fstat (fileno (gcov_var.file), &status)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@655 PS2, Line 655: if (fstat (fileno (gcov_var.file), &status)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@656 PS2, Line 656: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@657 PS2, Line 657: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@657 PS2, Line 657: else suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@658 PS2, Line 658: return status.st_mtime; please, no spaces at the start of a line
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40013 )
Change subject: src/lib: Update gcov-io.[ch] (test) ......................................................................
Abandoned