Change in coreboot[master]: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEV...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Sheng-Liang Pan (Code Review)

21 Oct 2020 21 Oct '20

9:50 a.m.

Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger

change elan touchscreen interrupt to LEVEL trigger to pass uniformity test.

BUG=b:169632772 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully

Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 --- M src/mainboard/google/volteer/variants/voxel/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46624/1

diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb index d7a265b..5aa006b 100644 --- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb @@ -116,7 +116,7 @@ chip drivers/i2c/hid register "generic.hid" = ""ELAN90FC"" register "generic.desc" = ""ELAN Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Sheng-Liang Pan (Code Review)

21 Oct 21 Oct

9:58 a.m.

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Comment-Date: Wed, 21 Oct 2020 09:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:45 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 1:

Sheng-Liang, the build failure here isn't your fault (what's failing is board.SUPERMICRO_X11SSH_F), so I'd bet if you rebase, you'll get the +1 from build bot

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 21 Oct 2020 19:45:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sheng-Liang Pan (Code Review)

22 Oct 22 Oct

12:44 a.m.

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 2:

...

Patch Set 1:

Sheng-Liang, the build failure here isn't your fault (what's failing is board.SUPERMICRO_X11SSH_F), so I'd bet if you rebase, you'll get the +1 from build bot

done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 22 Oct 2020 00:44:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

10:31 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 2: Code-Review-1

Please see the bug, there may be a bigger problem this is masking

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 22 Oct 2020 22:31:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

29 Oct 29 Oct

9:52 p.m.

Tim Wawrzynczak has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

Removed Code-Review-1 by Tim Wawrzynczak twawrzynczak@chromium.org

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: deleteVote

Furquan Shaikh (Code Review)

9 Nov 9 Nov

8:09 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46624/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46624/2//COMMIT_MSG@9 PS2, Line 9: change elan touchscreen interrupt to LEVEL trigger to pass uniformity : test. Can you please add the following detail to the commit message:

ELAN and Goodix touchscreen devices used on voxel are I2C-HID devices and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4, the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.

References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d...

https://review.coreboot.org/c/coreboot/+/46624/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voxel/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46624/2/src/mainboard/google/voltee... PS2, Line 104: ACPI_IRQ_EDGE_LOW This is wrong too. Since this is an I2C-HID device the interrupt will have to be level triggered.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Mon, 09 Nov 2020 20:09:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sheng-Liang Pan (Code Review)

10 Nov 10 Nov

6:44 a.m.

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Derek Huang, YH Lin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46624

to look at the new patch set (#3).

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger

BUG=b:169632772 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46624/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 3 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Sheng-Liang Pan (Code Review)

7:02 a.m.

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Derek Huang, YH Lin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46624

to look at the new patch set (#4).

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger

BUG=b:169632772 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46624/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 4 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Sheng-Liang Pan (Code Review)

7:03 a.m.

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Derek Huang, YH Lin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46624

to look at the new patch set (#5).

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger

ELAN and Goodix touchscreen devices used on voxel are I2C-HID devices and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4,the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.

BUG=b:169632772 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46624/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 5 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Sheng-Liang Pan (Code Review)

7:03 a.m.

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Derek Huang, YH Lin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46624

to look at the new patch set (#6).

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger

ELAN and Goodix touchscreen devices used on voxel are I2C-HID devices and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4,the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.

BUG=b:169632772 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46624/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 6 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Sheng-Liang Pan (Code Review)

7:03 a.m.

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Derek Huang, YH Lin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46624

to look at the new patch set (#7).

Change subject: mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger ......................................................................

mb/google/volteer/var/voxel: change elan touchscreen interrupt to LEVEL trigger

ELAN and Goodix touchscreen devices used on voxel are I2C-HID devices and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4,the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.

BUG=b:169632772 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46624/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 7 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Sheng-Liang Pan (Code Review)

7:04 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/voxel: change elan and goodix touchscreen inter...

Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Derek Huang, YH Lin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46624

to look at the new patch set (#8).

Change subject: mb/google/volteer/var/voxel: change elan and goodix touchscreen interrupt to LEVEL trigger ......................................................................

mb/google/volteer/var/voxel: change elan and goodix touchscreen interrupt to LEVEL trigger

ELAN and Goodix touchscreen devices used on voxel are I2C-HID devices and as per "HID over I2C Protocol Specification"[1] Version 1.00 Section 7.4,the interrupt line used by the device is expected to be level triggered. Hence, this change updates the configuration of the touchscreen interrupt to be level triggered.

BUG=b:169632772 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46624/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 8 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

7:08 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/voxel: change elan and goodix touchscreen inter...

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan and goodix touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 8 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 10 Nov 2020 07:08:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sheng-Liang Pan (Code Review)

7:09 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/voxel: change elan and goodix touchscreen inter...

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan and goodix touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 8: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 8 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 10 Nov 2020 07:09:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Caveh Jalali (Code Review)

8:08 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/voxel: change elan and goodix touchscreen inter...

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan and goodix touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 8: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 8 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 10 Nov 2020 08:08:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

11 Nov 11 Nov

4:29 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/voxel: change elan and goodix touchscreen inter...

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan and goodix touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 8 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 11 Nov 2020 16:29:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:26 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/voxel: change elan and goodix touchscreen inter...

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan and goodix touchscreen interrupt to LEVEL trigger ......................................................................

Patch Set 8:

Heads up: Karthik pushed a change yesterday to update the trigger type for all volteer devices here: https://review.coreboot.org/c/coreboot/+/47416

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 8 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 11 Nov 2020 20:26:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sheng-Liang Pan (Code Review)

16 Nov 16 Nov

9:22 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/voxel: change elan and goodix touchscreen inter...

Sheng-Liang Pan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46624 )

Change subject: mb/google/volteer/var/voxel: change elan and goodix touchscreen interrupt to LEVEL trigger ......................................................................

Abandoned

abandon since https://review.coreboot.org/c/coreboot/+/47416 merged

-- To view, visit https://review.coreboot.org/c/coreboot/+/46624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0272d9a4796da9479bd06c74d0c68b1ce6069b3 Gerrit-Change-Number: 46624 Gerrit-PatchSet: 8 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: YH Lin yueherngl@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1514

days inactive

1540

days old

coreboot-gerrit@coreboot.org

18 comments

4 participants

tags (0)

participants (4)

Caveh Jalali (Code Review)
Furquan Shaikh (Code Review)
Sheng-Liang Pan (Code Review)
Tim Wawrzynczak (Code Review)