Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/t4xx_... File Documentation/mainboard/lenovo/t4xx_series.md:
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/t4xx_... PS4, Line 7: :doc:`thinkpad_hmm` Why is this here ? Should be mainboard/index.md
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md File Documentation/mainboard/lenovo/x1.md:
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md... PS4, Line 1: # Lenovo X1 this file needs to be referenced from mainboard/index.md
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x1.md... PS4, Line 9: No picture ?
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x2xx_... File Documentation/mainboard/lenovo/x2xx_series.md:
https://review.coreboot.org/#/c/29434/4/Documentation/mainboard/lenovo/x2xx_... PS4, Line 3: A skilled engineer takes around 5 minutes to remove the keyboard and not very detailed...
-
Patrick Rudolph (Code Review)