Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43670 )
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
mb/google/octopus/variants/garg: update Garfour SKU ID
SKUID: 51 - Garfour EVT (non-touch, TypeA DB) 52 - Garfour DVT (touch, HDMI DB)
BUG=b:161554087 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: I3cb17c2b665c303da210817a531c869c6324b249 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/garg/include/variant/sku.h M src/mainboard/google/octopus/variants/garg/variant.c 3 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/43670/1
diff --git a/src/mainboard/google/octopus/variants/garg/gpio.c b/src/mainboard/google/octopus/variants/garg/gpio.c index dca07f6..67e1056 100644 --- a/src/mainboard/google/octopus/variants/garg/gpio.c +++ b/src/mainboard/google/octopus/variants/garg/gpio.c @@ -66,6 +66,7 @@ case SKU_9_HDMI: case SKU_19_HDMI_TS: case SKU_50_HDMI: + case SKU_52_HDMI_TS: *num = ARRAY_SIZE(hdmi_override_table); return hdmi_override_table; case SKU_17_LTE: diff --git a/src/mainboard/google/octopus/variants/garg/include/variant/sku.h b/src/mainboard/google/octopus/variants/garg/include/variant/sku.h index 3ab6988..8fc63cc 100644 --- a/src/mainboard/google/octopus/variants/garg/include/variant/sku.h +++ b/src/mainboard/google/octopus/variants/garg/include/variant/sku.h @@ -14,6 +14,8 @@ SKU_38_2A2C_360_TS_NO_STYLUES = 38, SKU_49_2A2C_TS = 49, SKU_50_HDMI = 50, + SKU_51_2A2C = 51, + SKU_52_HDMI_TS = 52, };
#endif /* __MAINBOARD_SKU_H__ */ diff --git a/src/mainboard/google/octopus/variants/garg/variant.c b/src/mainboard/google/octopus/variants/garg/variant.c index 5188be6..5d9c5ee 100644 --- a/src/mainboard/google/octopus/variants/garg/variant.c +++ b/src/mainboard/google/octopus/variants/garg/variant.c @@ -47,6 +47,7 @@ case SKU_9_HDMI: case SKU_19_HDMI_TS: case SKU_50_HDMI: + case SKU_52_HDMI_TS: return "vbt_garg_hdmi.bin"; default: return "vbt.bin";
Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43670
to look at the new patch set (#3).
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
mb/google/octopus/variants/garg: update Garfour SKU ID
SKUID: 51 - Garfour EVT (non-touch, TypeA DB) 52 - Garfour DVT (touch, HDMI DB)
BUG=b:161554087 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: I3cb17c2b665c303da210817a531c869c6324b249 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/garg/include/variant/sku.h M src/mainboard/google/octopus/variants/garg/variant.c 3 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/43670/3
Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43670
to look at the new patch set (#4).
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
mb/google/octopus/variants/garg: update Garfour SKU ID
SKUID: 51 - Garfour EVT (non-touch, TypeA DB) 52 - Garfour DVT (touch, HDMI DB)
BUG=b:161554087 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: I3cb17c2b665c303da210817a531c869c6324b249 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/garg/include/variant/sku.h M src/mainboard/google/octopus/variants/garg/variant.c 3 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/43670/4
Hello build bot (Jenkins), Henry Sun, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43670
to look at the new patch set (#5).
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
mb/google/octopus/variants/garg: update Garfour SKU ID
SKUID 51 - Garfour EVT (non-touch, TypeA DB) 52 - Garfour DVT (touch, HDMI DB)
BUG=b:161554087 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: I3cb17c2b665c303da210817a531c869c6324b249 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/garg/include/variant/sku.h M src/mainboard/google/octopus/variants/garg/variant.c 3 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/43670/5
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43670 )
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
Patch Set 5:
Please help review
Thanks
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43670 )
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
Patch Set 5: Code-Review+2
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43670 )
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
Patch Set 5:
Hi Karthik, Could you kindly help cherry-pick to chrome ToT? Thanks
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43670 )
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
Patch Set 5: Code-Review+1
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43670 )
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
mb/google/octopus/variants/garg: update Garfour SKU ID
SKUID 51 - Garfour EVT (non-touch, TypeA DB) 52 - Garfour DVT (touch, HDMI DB)
BUG=b:161554087 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: I3cb17c2b665c303da210817a531c869c6324b249 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43670 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Henry Sun henrysun@google.com --- M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/garg/include/variant/sku.h M src/mainboard/google/octopus/variants/garg/variant.c 3 files changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Henry Sun: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/garg/gpio.c b/src/mainboard/google/octopus/variants/garg/gpio.c index dca07f6..67e1056 100644 --- a/src/mainboard/google/octopus/variants/garg/gpio.c +++ b/src/mainboard/google/octopus/variants/garg/gpio.c @@ -66,6 +66,7 @@ case SKU_9_HDMI: case SKU_19_HDMI_TS: case SKU_50_HDMI: + case SKU_52_HDMI_TS: *num = ARRAY_SIZE(hdmi_override_table); return hdmi_override_table; case SKU_17_LTE: diff --git a/src/mainboard/google/octopus/variants/garg/include/variant/sku.h b/src/mainboard/google/octopus/variants/garg/include/variant/sku.h index 3ab6988..8fc63cc 100644 --- a/src/mainboard/google/octopus/variants/garg/include/variant/sku.h +++ b/src/mainboard/google/octopus/variants/garg/include/variant/sku.h @@ -14,6 +14,8 @@ SKU_38_2A2C_360_TS_NO_STYLUES = 38, SKU_49_2A2C_TS = 49, SKU_50_HDMI = 50, + SKU_51_2A2C = 51, + SKU_52_HDMI_TS = 52, };
#endif /* __MAINBOARD_SKU_H__ */ diff --git a/src/mainboard/google/octopus/variants/garg/variant.c b/src/mainboard/google/octopus/variants/garg/variant.c index 5188be6..5d9c5ee 100644 --- a/src/mainboard/google/octopus/variants/garg/variant.c +++ b/src/mainboard/google/octopus/variants/garg/variant.c @@ -47,6 +47,7 @@ case SKU_9_HDMI: case SKU_19_HDMI_TS: case SKU_50_HDMI: + case SKU_52_HDMI_TS: return "vbt_garg_hdmi.bin"; default: return "vbt.bin";
-
Henry Sun (Code Review) -
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Tony Huang (Code Review)