Attention is currently required from: Hung-Te Lin, Wentao Qin, Xuxin Xiong, Yang Wu.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82089?usp=email )
Change subject: mb/google/corsola/wugtrio: Add initialization of USB port0
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82089/comment/04ff01d8_edb38807 :
PS9, Line 7: wugtrio
var/wugtrio
File src/soc/mediatek/common/usb.c:
https://review.coreboot.org/c/coreboot/+/82089/comment/3c833010_cc399cff :
PS9, Line 162:
Can we also add `update_usb_base_regs(SSUSB_IPPC_BASE, SSUSB_SIF_BASE)` here, so that the behavior is independent of the calling order of `setup_usb_secondary_host` and `setup_usb_host`.
File src/soc/mediatek/mt8186/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/82089/comment/0be23ff1_5f08fff9 :
PS9, Line 80: SSUSB_IPPC_BASE = IO_PHYS + 0x01283E00,
: SSUSB_IPPC_BASE_P0 = IO_PHYS + 0x01203E00,
Sort by addresses.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82089?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I725b80593f5fc498a204bf47f943c36ccbd78134
Gerrit-Change-Number: 82089
Gerrit-PatchSet: 9
Gerrit-Owner: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mingjin Ge
mingjin.ge@mediatek.corp-partner.google.com
Gerrit-Reviewer: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 09:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment