Change in coreboot[master]: mb/google/hatch: Make Nightfury variant alphabettically sorted
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40400 )
Change subject: mb/google/hatch: Make Nightfury variant alphabettically sorted ......................................................................
mb/google/hatch: Make Nightfury variant alphabettically sorted
Change-Id: I21a710ee0df45188f1f43aad61967069faf88fdb Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/40400/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 2419722..6eff9070 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -103,8 +103,8 @@ default "Kindred" if BOARD_GOOGLE_KINDRED default "Kohaku" if BOARD_GOOGLE_KOHAKU default "Mushu" if BOARD_GOOGLE_MUSHU - default "Palkia" if BOARD_GOOGLE_PALKIA default "Nightfury" if BOARD_GOOGLE_NIGHTFURY + default "Palkia" if BOARD_GOOGLE_PALKIA default "Puff" if BOARD_GOOGLE_PUFF default "Kaisa" if BOARD_GOOGLE_KAISA default "Stryke" if BOARD_GOOGLE_STRYKE @@ -131,8 +131,8 @@ default "kindred" if BOARD_GOOGLE_KINDRED default "kohaku" if BOARD_GOOGLE_KOHAKU default "mushu" if BOARD_GOOGLE_MUSHU - default "palkia" if BOARD_GOOGLE_PALKIA default "nightfury" if BOARD_GOOGLE_NIGHTFURY + default "palkia" if BOARD_GOOGLE_PALKIA default "puff" if BOARD_GOOGLE_PUFF default "kaisa" if BOARD_GOOGLE_KAISA default "stryke" if BOARD_GOOGLE_STRYKE diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index ce34211..f3f944f 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -60,6 +60,12 @@ select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
+config BOARD_GOOGLE_NIGHTFURY + bool "-> Nightfury" + select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP + select BOARD_ROMSIZE_KB_16384 + config BOARD_GOOGLE_PALKIA bool "-> Palkia" select BOARD_GOOGLE_BASEBOARD_HATCH @@ -68,12 +74,6 @@ select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011
-config BOARD_GOOGLE_NIGHTFURY - bool "-> Nightfury" - select BOARD_GOOGLE_BASEBOARD_HATCH - select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP - select BOARD_ROMSIZE_KB_16384 - config BOARD_GOOGLE_PUFF bool "-> Puff" select BOARD_GOOGLE_BASEBOARD_HATCH
Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40400 )
Change subject: mb/google/hatch: Make Nightfury variant alphabettically sorted ......................................................................
Patch Set 1: Code-Review+1
Daniel Kurtz has uploaded a new patch set (#2) to the change originally created by Edward O'Callaghan. ( https://review.coreboot.org/c/coreboot/+/40400 )
Change subject: mb/google/hatch: Sort Nightfury variant alphabetically ......................................................................
mb/google/hatch: Sort Nightfury variant alphabetically
Change-Id: I21a710ee0df45188f1f43aad61967069faf88fdb Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/40400/2
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40400 )
Change subject: mb/google/hatch: Sort Nightfury variant alphabetically ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Daniel Kurtz, Andrew McRae,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40400
to look at the new patch set (#3).
Change subject: mb/google/hatch: Make Nightfury variant alphabettically sorted ......................................................................
mb/google/hatch: Make Nightfury variant alphabettically sorted
Change-Id: I21a710ee0df45188f1f43aad61967069faf88fdb Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/40400/3
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40400 )
Change subject: mb/google/hatch: Make Nightfury variant alphabettically sorted ......................................................................
Patch Set 4: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40400 )
Change subject: mb/google/hatch: Make Nightfury variant alphabettically sorted ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40400/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40400/4//COMMIT_MSG@7 PS4, Line 7: alphabettically No double 't': alphabetically
You can also say: "Sort variants alphabetically" to make the summary shorter
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40400 )
Change subject: mb/google/hatch: Make Nightfury variant alphabettically sorted ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40400/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40400/4//COMMIT_MSG@7 PS4, Line 7: alphabettically
No double 't': alphabetically […]
See $subject of PS#2 :-) Gerrit change was overwritten on re-upload of CL.
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40400?usp=email )
Change subject: mb/google/hatch: Make Nightfury variant alphabettically sorted ......................................................................
Abandoned
-
Andrew McRae (Code Review) -
Angel Pons (Code Review)
-
Daniel Kurtz (Code Review)
-
Edward O'Callaghan (Code Review)
-
Stefan Reinauer (Code Review)