Change in ...coreboot[master]: mb/pcengines/apu2: describe serial ports in ACPI

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

[XL] Change in coreboot[master]:...

Michał Żygowski (Code Review)

24 May 2019 24 May '19

5:22 p.m.

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32989

Change subject: mb/pcengines/apu2: describe serial ports in ACPI ......................................................................

mb/pcengines/apu2: describe serial ports in ACPI

FreeBSD users had to manually configure serial ports on their installations. Defining serial ports in ACPI save that effort.

Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 --- A src/mainboard/pcengines/apu2/acpi/superio.asl M src/mainboard/pcengines/apu2/dsdt.asl 2 files changed, 68 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/32989/1

diff --git a/src/mainboard/pcengines/apu2/acpi/superio.asl b/src/mainboard/pcengines/apu2/acpi/superio.asl new file mode 100644 index 0000000..c61e3d7 --- /dev/null +++ b/src/mainboard/pcengines/apu2/acpi/superio.asl @@ -0,0 +1,65 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 PC Engines Gmbh + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Scope (_SB.PCI0.LIBR) { + + Device (COM1) { + Name (_HID, EISAID ("PNP0501")) + Name (_UID, 1) + + Method (_STA, 0, NotSerialized) { + Return (0x0F) + } + + Name (_CRS, ResourceTemplate () + { + IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) + IRQNoFlags () {4} + }) + + Name (_PRS, ResourceTemplate () + { + StartDependentFn (0, 0) { + IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) + IRQNoFlags () {4} + } + EndDependentFn () + }) + } + + Device (COM2) { + Name (_HID, EISAID ("PNP0501")) + Name (_UID, 2) + + Method (_STA, 0, NotSerialized) { + Return (0x0F) + } + + Name (_CRS, ResourceTemplate () + { + IO (Decode16, 0x02F8, 0x2F8, 0x08, 0x08) + IRQNoFlags () {3} + }) + + Name (_PRS, ResourceTemplate () + { + StartDependentFn (0, 0) { + IO (Decode16, 0x02F8, 0x2F8, 0x08, 0x08) + IRQNoFlags () {3} + } + EndDependentFn () + }) + } +} \ No newline at end of file diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl index 3bf0ed6..409f03d 100644 --- a/src/mainboard/pcengines/apu2/dsdt.asl +++ b/src/mainboard/pcengines/apu2/dsdt.asl @@ -81,5 +81,8 @@

/* Define the System Indicators for the platform */ #include "acpi/si.asl" + + /* Super IO devices (COM ports) */ + #include "acpi/superio.asl" } /* End of ASL file */

Attachments:

attachment.htm (text/html — 7.7 KB)

Show replies by date

Michał Żygowski (Code Review)

24 May 24 May

5:34 p.m.

New subject: Change in ...coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32989

to look at the new patch set (#2).

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

mb/pcengines/apu2: Describe serial ports in ACPI

FreeBSD users had to manually configure the serial ports on their installations. Describing the serial ports in ACPI save that effort and leaves the configuration to the system.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/32989/2

Michał Żygowski (Code Review)

28 May 28 May

12:02 p.m.

New subject: Change in ...coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32989

to look at the new patch set (#3).

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

mb/pcengines/apu2: Describe serial ports in ACPI

FreeBSD users had to manually configure the serial ports on their installations. Describing the serial ports in ACPI save that effort and leaves the configuration to the system.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/32989/3

Patrick Rudolph (Code Review)

6:02 p.m.

New subject: Change in ...coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32989/3/src/mainboard/pcengines/apu2/acpi/su... File src/mainboard/pcengines/apu2/acpi/superio.asl:

https://review.coreboot.org/#/c/32989/3/src/mainboard/pcengines/apu2/acpi/su... PS3, Line 19: I usually that's part of the superio directory and you just include asl code here

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Tue, 28 May 2019 16:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michał Żygowski (Code Review)

6:05 p.m.

New subject: Change in ...coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32989/3/src/mainboard/pcengines/apu2/acpi/su... File src/mainboard/pcengines/apu2/acpi/superio.asl:

https://review.coreboot.org/#/c/32989/3/src/mainboard/pcengines/apu2/acpi/su... PS3, Line 19: I

...

usually that's part of the superio directory and you just include asl code here

For the Nuvoton NCT5104D there is no ASL code. Should I just import generic PNP UART with proper defines?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Tue, 28 May 2019 16:05:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Mike Banon (Code Review)

16 Nov 16 Nov

3:27 p.m.

New subject: Change in coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3: Code-Review+1

Seems to be good, although I don't have any means to test it (don't have an APU2)

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Sat, 16 Nov 2019 14:27:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mike Banon (Code Review)

19 Apr 19 Apr

6:20 p.m.

New subject: Change in coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3: Code-Review+2

Patrick Georgi (Code Review)

1 May 1 May

9:03 a.m.

New subject: Change in coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... PS3, Line 19: I

...

For the Nuvoton NCT5104D there is no ASL code. […]

Wow, sorry for the lack of follow up here: If the generic code works, use that. otherwise it might be useful to implement the structure (that is, create ASL code for NCT5104D)

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Fri, 01 May 2020 07:03:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Paul Menzel (Code Review)

10:07 a.m.

New subject: Change in coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/32989/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/32989/3//COMMIT_MSG@9 PS3, Line 9: had I’d use present tense: have.

https://review.coreboot.org/c/coreboot/+/32989/3//COMMIT_MSG@10 PS3, Line 10: save saves

https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... PS3, Line 14: */ Please use SPDX headers.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 01 May 2020 08:07:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

10:38 a.m.

New subject: Change in coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... PS3, Line 19: I

...

Wow, sorry for the lack of follow up here: If the generic code works, use that. […]

I'd prefer to have this ASL code under the superio/ scope. Maybe use another SIO as an example

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 01 May 2020 08:38:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Michał Żygowski (Code Review)

4 May 4 May

12:23 p.m.

New subject: Change in coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... PS3, Line 19: I

...

I'd prefer to have this ASL code under the superio/ scope. […]

I will take the SSDT generator way to do it when I find free cycles for this patch, not so important for me now.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 May 2020 10:23:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Mike Banon (Code Review)

16 May 16 May

9:26 p.m.

New subject: Change in coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3:

Please resolve a couple of remaining comments to get this patch merged.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 16 May 2020 19:26:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

4 Aug 4 Aug

12:11 a.m.

New subject: [M] Change in coreboot[master]: mb/pcengines/apu2: Describe serial ports in ACPI

Attention is currently required from: Michał Żygowski.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989?usp=email )

Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3:

...

If I find some free time I will get back to it... […]

Michal, please note that this patch (for which I voted +2 back then) is going to be "auto-abandoned"

-- To view, visit https://review.coreboot.org/c/coreboot/+/32989?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Thu, 03 Aug 2023 22:11:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: comment

477

days inactive

2009

days old

coreboot-gerrit@coreboot.org

12 comments

6 participants

tags (0)

participants (6)

Angel Pons (Code Review)
Michał Żygowski (Code Review)
Mike Banon (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)