Attention is currently required from: Felix Singer, Nico Huber, Tim Wawrzynczak, Paul Menzel, Angel Pons.
vaibhav has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62968 )
Change subject: src/acpi/acpigen_usb.c: Fix False Memory leak error
......................................................................
Patch Set 2:
(1 comment)
File src/acpi/acpigen_usb.c:
https://review.coreboot.org/c/coreboot/+/62968/comment/0ceefa09_126adb5d
PS2, Line 92: #ifdef __clang_analyzer__
: free(fresh);
: #endif
I think scan-build is just stupid. […]
If i am able to understand correctly, you are proposing to edit the function defintion of `acpi_dp_add_reference()`
If so, to achieve this we would need to add an extra parameter `path` (so that strdup() may be called inside it) in addition to `free`ing the leak inside the definition ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifed611bd0b9c1da3678386bff33bca3eac0311b4
Gerrit-Change-Number: 62968
Gerrit-PatchSet: 2
Gerrit-Owner: vaibhav
vrockz747@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 04 Apr 2022 15:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment