Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38978/5/src/mainboard/acer/es1-572/...
File src/mainboard/acer/es1-572/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38978/5/src/mainboard/acer/es1-572/...
PS5, Line 113: PchSerialIoPci
set this to PchSerialIoSkipInit to let coreboot configure UART. […]
Let's make it clear: it didn't hang your machine, it made your machine stop outputting logs. However, since you had no payload, it might as well have died there...
In any case, I'll consider switching this as SerialIO shouldn't be giving me troubles anymore
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38978
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id98788a2c5e54f70fd1cacbd70d636f5e63b2619
Gerrit-Change-Number: 38978
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Comment-Date: Sun, 29 Mar 2020 17:56:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment