Change in coreboot[master]: lib/edid: Zero struct only when used

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38913 )

Change subject: lib/edid: Zero struct only when used
......................................................................

lib/edid: Zero struct only when used

Change-Id: I1c14e7458153fb992b17f30d7015321fae533bb2
Signed-off-by: Paul Menzel 
---
M src/lib/edid.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/38913/1

diff --git a/src/lib/edid.c b/src/lib/edid.c
index 238fed5..048cc6a 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -1138,8 +1138,6 @@
        .conformant = EDID_CONFORMANT,
    };

-	memset(out, 0, sizeof(*out));
-
    if (!edid) {
    	printk(BIOS_ERR, "No EDID found\n");
    	return EDID_ABSENT;
@@ -1152,6 +1150,8 @@
    	return EDID_ABSENT;
    }

+	memset(out, 0, sizeof(*out));
+
    if (manufacturer_name(edid + 0x08, out->manufacturer_name))
    	c.manufacturer_name_well_formed = 1;

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38913 )

Change subject: lib/edid: Zero struct only when used
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38913 )

Change subject: lib/edid: Zero struct only when used
......................................................................

lib/edid: Zero struct only when used

Change-Id: I1c14e7458153fb992b17f30d7015321fae533bb2
Signed-off-by: Paul Menzel 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38913
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
---
M src/lib/edid.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/lib/edid.c b/src/lib/edid.c
index 238fed5..048cc6a 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -1138,8 +1138,6 @@
        .conformant = EDID_CONFORMANT,
    };

-	memset(out, 0, sizeof(*out));
-
    if (!edid) {
    	printk(BIOS_ERR, "No EDID found\n");
    	return EDID_ABSENT;
@@ -1152,6 +1150,8 @@
    	return EDID_ABSENT;
    }

+	memset(out, 0, sizeof(*out));
+
    if (manufacturer_name(edid + 0x08, out->manufacturer_name))
    	c.manufacturer_name_well_formed = 1;