Attention is currently required from: Keith Hui.
Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85797?usp=email )
The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now.
Change subject: mb/asus/p8x7x-series: Streamline DT PCIe configs ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/mainboard/asus/p8x7x-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85797/comment/ba7426ae_5b0de4a2?usp... : PS1, Line 40: device ref pcie_rp1 on end # PCIe x4 slot, by various names If they are still present in the overridetrees so that the comment about the name is still present, is there a point in adding it to on in the default devicetree?
https://review.coreboot.org/c/coreboot/+/85797/comment/fe8a969f_45638891?usp... : PS1, Line 41: device ref pcie_rp2 off end : device ref pcie_rp3 off end : device ref pcie_rp4 off end : device ref pcie_rp5 off end : device ref pcie_rp6 off end : device ref pcie_rp7 off end : device ref pcie_rp8 off end All of these default to off in the chipset devicetree (`nb/intel/sandybridge/chipset.cb`) and thus are technically unnecessary in the board devicetree.
-
Nicholas Chin (Code Review)