Change in ...coreboot[master]: mainboard/msi: remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33895

Change subject: mainboard/msi: remove stdlib.h when unused
......................................................................

mainboard/msi: remove stdlib.h when unused

Change-Id: I282d02d58a5740369371a6f0bbdf7e900e3edc56
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/msi/ms7721/BiosCallOuts.c
M src/mainboard/msi/ms7721/buildOpts.c
M src/mainboard/msi/ms9652_fam10/get_bus_conf.c
3 files changed, 0 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/33895/1

diff --git a/src/mainboard/msi/ms7721/BiosCallOuts.c b/src/mainboard/msi/ms7721/BiosCallOuts.c
index b3cac1d..ccad187 100644
--- a/src/mainboard/msi/ms7721/BiosCallOuts.c
+++ b/src/mainboard/msi/ms7721/BiosCallOuts.c
@@ -17,9 +17,7 @@
 #include <AGESA.h>
 #include <northbridge/amd/agesa/BiosCallOuts.h>
 #include <northbridge/amd/agesa/state_machine.h>
-
 #include <vendorcode/amd/agesa/f15tn/Proc/Fch/FchPlatform.h>
-#include <stdlib.h>

const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
diff --git a/src/mainboard/msi/ms7721/buildOpts.c b/src/mainboard/msi/ms7721/buildOpts.c
index 9e57e39..8edadda 100644
--- a/src/mainboard/msi/ms7721/buildOpts.c
+++ b/src/mainboard/msi/ms7721/buildOpts.c
@@ -25,8 +25,6 @@
  *
  */

-#include <stdlib.h>
-
 #include <vendorcode/amd/agesa/f15tn/AGESA.h>

/*  Include the files that instantiate the configuration definitions.  */
@@ -41,7 +39,6 @@
 #include <vendorcode/amd/agesa/f15tn/Proc/Mem/mm.h>
 #include <vendorcode/amd/agesa/f15tn/Proc/Mem/mn.h>

-
 /*  Select the CPU family.  */
 #define INSTALL_FAMILY_10_SUPPORT FALSE
 #define INSTALL_FAMILY_12_SUPPORT FALSE
diff --git a/src/mainboard/msi/ms9652_fam10/get_bus_conf.c b/src/mainboard/msi/ms9652_fam10/get_bus_conf.c
index 74b14b4..9d8ece9 100644
--- a/src/mainboard/msi/ms9652_fam10/get_bus_conf.c
+++ b/src/mainboard/msi/ms9652_fam10/get_bus_conf.c
@@ -21,10 +21,8 @@
 #include <string.h>
 #include <stdint.h>
 #include <cpu/amd/multicore.h>
-
 #include <cpu/amd/amdfam10_sysconf.h>

-#include <stdlib.h>
 #include "mb_sysconf.h"

// Global variables for MB layouts and these will be shared by irqtable mptable and acpi_tables

Change in coreboot[master]: mb/msi/ms7721: Remove unused include <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33895

to look at the new patch set (#2).

Change subject: mb/msi/ms7721: Remove unused include <stdlib.h>
......................................................................

mb/msi/ms7721: Remove unused include <stdlib.h>

Change-Id: I282d02d58a5740369371a6f0bbdf7e900e3edc56
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/msi/ms7721/BiosCallOuts.c
M src/mainboard/msi/ms7721/buildOpts.c
2 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/33895/2

Change in coreboot[master]: mb/msi/ms7721: Remove unused include <stdlib.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33895 )

Change subject: mb/msi/ms7721: Remove unused include <stdlib.h>
......................................................................

Abandoned

see 32023

Change in coreboot[master]: mb/msi/ms7721: Remove unused include <stdlib.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33895 )

Change subject: mb/msi/ms7721: Remove unused include <stdlib.h>
......................................................................

Restored

Change in coreboot[master]: mb/{elmex,jetway,msi,pcengines}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33895

to look at the new patch set (#3).

Change subject: mb/{elmex,jetway,msi,pcengines}: Remove unused <stdlib.h>
......................................................................

mb/{elmex,jetway,msi,pcengines}: Remove unused <stdlib.h>

Change-Id: I282d02d58a5740369371a6f0bbdf7e900e3edc56
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/elmex/pcm205400/BiosCallOuts.c
M src/mainboard/elmex/pcm205400/buildOpts.c
M src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c
M src/mainboard/jetway/nf81-t56n-lf/buildOpts.c
M src/mainboard/msi/ms7721/BiosCallOuts.c
M src/mainboard/msi/ms7721/buildOpts.c
M src/mainboard/pcengines/apu1/BiosCallOuts.c
M src/mainboard/pcengines/apu1/buildOpts.c
M src/mainboard/pcengines/apu2/BiosCallOuts.c
9 files changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/33895/3

Change in coreboot[master]: mb/{elmex,jetway,msi,pcengines}: Remove unused <stdlib.h>

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33895 )

Change subject: mb/{elmex,jetway,msi,pcengines}: Remove unused <stdlib.h>
......................................................................

Patch Set 6: Code-Review+1

Change in coreboot[master]: mb/{msi,pcengines}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello Piotr Król, build bot (Jenkins), Michał Żygowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33895

to look at the new patch set (#7).

Change subject: mb/{msi,pcengines}: Remove unused <stdlib.h>
......................................................................

mb/{msi,pcengines}: Remove unused <stdlib.h>

Change-Id: I282d02d58a5740369371a6f0bbdf7e900e3edc56
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/msi/ms7721/BiosCallOuts.c
M src/mainboard/msi/ms7721/buildOpts.c
M src/mainboard/pcengines/apu1/BiosCallOuts.c
M src/mainboard/pcengines/apu1/buildOpts.c
M src/mainboard/pcengines/apu2/BiosCallOuts.c
5 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/33895/7

Change in coreboot[master]: mb/{msi,pcengines}: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33895 )

Change subject: mb/{msi,pcengines}: Remove unused <stdlib.h>
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: mb/{msi,pcengines}: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33895 )

Change subject: mb/{msi,pcengines}: Remove unused <stdlib.h>
......................................................................

mb/{msi,pcengines}: Remove unused <stdlib.h>

Change-Id: I282d02d58a5740369371a6f0bbdf7e900e3edc56
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33895
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
---
M src/mainboard/msi/ms7721/BiosCallOuts.c
M src/mainboard/msi/ms7721/buildOpts.c
M src/mainboard/pcengines/apu1/BiosCallOuts.c
M src/mainboard/pcengines/apu1/buildOpts.c
M src/mainboard/pcengines/apu2/BiosCallOuts.c
5 files changed, 0 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/mainboard/msi/ms7721/BiosCallOuts.c b/src/mainboard/msi/ms7721/BiosCallOuts.c
index b3cac1d..eb3c43c 100644
--- a/src/mainboard/msi/ms7721/BiosCallOuts.c
+++ b/src/mainboard/msi/ms7721/BiosCallOuts.c
@@ -19,7 +19,6 @@
 #include <northbridge/amd/agesa/state_machine.h>

#include <vendorcode/amd/agesa/f15tn/Proc/Fch/FchPlatform.h>
-#include <stdlib.h>

const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
diff --git a/src/mainboard/msi/ms7721/buildOpts.c b/src/mainboard/msi/ms7721/buildOpts.c
index 9e57e39..2dd223d 100644
--- a/src/mainboard/msi/ms7721/buildOpts.c
+++ b/src/mainboard/msi/ms7721/buildOpts.c
@@ -25,7 +25,6 @@
  *
  */

-#include <stdlib.h>

#include <vendorcode/amd/agesa/f15tn/AGESA.h>

diff --git a/src/mainboard/pcengines/apu1/BiosCallOuts.c b/src/mainboard/pcengines/apu1/BiosCallOuts.c
index caaa1f4..f738aa3 100644
--- a/src/mainboard/pcengines/apu1/BiosCallOuts.c
+++ b/src/mainboard/pcengines/apu1/BiosCallOuts.c
@@ -18,7 +18,6 @@
 #include <spd_bin.h>
 #include <northbridge/amd/agesa/BiosCallOuts.h>
 #include <SB800.h>
-#include <stdlib.h>

#include "gpio_ftns.h"

diff --git a/src/mainboard/pcengines/apu1/buildOpts.c b/src/mainboard/pcengines/apu1/buildOpts.c
index 1f73eee..3c037e5 100644
--- a/src/mainboard/pcengines/apu1/buildOpts.c
+++ b/src/mainboard/pcengines/apu1/buildOpts.c
@@ -25,7 +25,6 @@
  *
  */

-#include <stdlib.h>

/*	Select the CPU family.	*/
diff --git a/src/mainboard/pcengines/apu2/BiosCallOuts.c b/src/mainboard/pcengines/apu2/BiosCallOuts.c
index 264dd77..1ae5301 100644
--- a/src/mainboard/pcengines/apu2/BiosCallOuts.c
+++ b/src/mainboard/pcengines/apu2/BiosCallOuts.c
@@ -19,7 +19,6 @@
 #include <northbridge/amd/agesa/BiosCallOuts.h>
 #include <northbridge/amd/agesa/state_machine.h>
 #include <FchPlatform.h>
-#include <stdlib.h>

#include "gpio_ftns.h"
 #include "imc.h"