Change in coreboot[master]: nb/intel/i945: Refactor `dump_spd_registers` function - coreboot-gerrit

3 Apr 2021


      Attention is currently required from: Nico Huber, Stefan Reinauer, Angel Pons, Arthur Heymans, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51899 )
Change subject: nb/intel/i945: Refactor `dump_spd_registers` function
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/northbridge/intel/i945/debug.c:
https://review.coreboot.org/c/coreboot/+/51899/comment/e27ffa59_e72220b9 
PS4, Line 63: 		const unsigned int device = spd_map[d];
nit: needed?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51899
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b5b71cff290343c1000d5613209049fa9724e3d
Gerrit-Change-Number: 51899
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sat, 03 Apr 2021 20:18:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment