Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46940 )
Change subject: util/docker: Add sdcc to our build nodes ......................................................................
util/docker: Add sdcc to our build nodes
core-ec will need it.
Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/46940/1
diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 36b77d6..9449c05 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -20,6 +20,7 @@ RUN apt-get -y update && \ apt-get -y install \ meson ninja-build \ + sdcc \ lua5.3 liblua5.3-dev default-jre-headless openssh-server && \ apt-get clean
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46940 )
Change subject: util/docker: Add sdcc to our build nodes ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46940 )
Change subject: util/docker: Add sdcc to our build nodes ......................................................................
util/docker: Add sdcc to our build nodes
core-ec will need it.
Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46940 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 36b77d6..9449c05 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -20,6 +20,7 @@ RUN apt-get -y update && \ apt-get -y install \ meson ninja-build \ + sdcc \ lua5.3 liblua5.3-dev default-jre-headless openssh-server && \ apt-get clean
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46940 )
Change subject: util/docker: Add sdcc to our build nodes ......................................................................
Patch Set 2: Code-Review+2
Oh, sorry for not responding. I didn't get a notification.
Thanks!
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46940 )
Change subject: util/docker: Add sdcc to our build nodes ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46940/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46940/2//COMMIT_MSG@9 PS2, Line 9: core-ec will need it. What is core-ec?
-
Felix Singer (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)