Attention is currently required from: Appukuttan V K, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Wonkyu Kim.
Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82481?usp=email )
Change subject: soc/intel: Fix pointer size mismatch errors in crashlog
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/common/block/crashlog/crashlog.c:
https://review.coreboot.org/c/coreboot/+/82481/comment/70f79439_9bb0e72c?usp... :
PS2, Line 20: u32 __weak cl_get_cpu_bar_addr(void)
Acknowledged
Intel team decided to clean this part of incremental CL that would add support for 64-bit crashlog. hence, unblocking this review comment.
https://review.coreboot.org/c/coreboot/+/82481/comment/30378849_002feb9d?usp... :
PS2, Line 166: u32 desc_table_addr
Acknowledged
i don't believe you have ack the feedback. Can you please take a look? ideally we wish to replace `u32 desc_table_addr` with `uintptr_t desc_table_addr`
Intel to address this review comment in a separate where they plan to add support for 64-bit crashlog.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82481?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d0814a8b767270ec140341bfb51d0782469545d
Gerrit-Change-Number: 82481
Gerrit-PatchSet: 7
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 31 May 2024 07:27:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Appukuttan V K
appukuttan.vk@intel.com
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com