Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22215 )
Change subject: [WIP]nb/intel/sandybridge/raminit: Add ECC support ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy... PS9, Line 173: size_t Why size_t?
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy... PS9, Line 269: non ECC this functions as an adjective: non-ECC
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy... PS9, Line 465: if (ctrl->ecc_enabled) Could use a ternary operator, or would it look too bad?
Another option would be to pass the value to use in "training".
-
Angel Pons (Code Review)