Attention is currently required from: Brandon Breitenstein, Eran Mitrani, Hannah Williams, Jamie Ryu, Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78322?usp=email )
Change subject: mb/google/rex/var/rex: Configure PL4 to 64W if battery status is invalid
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c:
https://review.coreboot.org/c/coreboot/+/78322/comment/181cb4e6_333fe89c :
PS5, Line 25: p
Acknowledged
'optimized' sounds like the preferred/nominal profile,
but this is really the fail-safe profile.
https://review.coreboot.org/c/coreboot/+/78322/comment/b01d8331_3d560df4 :
PS5, Line 48: battery_status
What is the condition we are going to check to limit PL4 now? Are we going to consider Battery level […]
`EC_BATT_FLAG_LEVEL_CRITICAL` means we're below
`CONFIG_BATT_HOST_SHUTDOWN_PERCENTAGE` (default 4%)
at which point we notify the AP with `EC_HOST_EVENT_BATTERY_CRITICAL`
in the hopes the user is notified before we force a shutdown
or things go dark.
there are a bunch of additional thresholds that go into deciding
to shut down the AP...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78322?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I12fd40abda76c8e7522b06a5aee72665f32ddec8
Gerrit-Change-Number: 78322
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 13 Oct 2023 02:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment