Attention is currently required from: Maximilian Brune, Nico Huber, Philipp Hug, Ron Minnich.
Alper Nebi Yasak has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80363?usp=email )
Change subject: mainboard/qemu-riscv: Get top of memory from device-tree blob
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/emulation/qemu-riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/80363/comment/d53bb3c3_e3fa8071?usp... :
PS3, Line 11: if (CONFIG(FLATTENED_DEVICE_TREE)) {
Now that there is no shared soc code anymore we don't need that anymore.
Done, thanks!
File src/soc/ucb/riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/80363/comment/ac9e5a1d_9e4e0d52?usp... :
PS2, Line 13: top = fdt_get_memory_top((void *)HLS()->fdt);
I wonder why they share a SoC. Though to me, the most straight forward option […]
Done in patchset 3. But a mainboard-specific `cbmem.c` had been added, so reverted as the config check is no longer necessary as Maximilian said.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80363?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e4a95f49ad373675939329eef40d7423a4132ab
Gerrit-Change-Number: 80363
Gerrit-PatchSet: 4
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 28 May 2024 16:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Alper Nebi Yasak
alpernebiyasak@gmail.com