Change in coreboot[master]: console/*: Use same indents for switch/case

List overview All Threads
Download

newer

older

[XS] Change in coreboot[master]:...

Felix Singer (Code Review)

7 Jan 2021 7 Jan '21

7:16 a.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/*: Use same indents for switch/case ......................................................................

console/*: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/console/vtxprintf.c 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/49204/1

diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index c7bb585..16044c3 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -127,12 +127,12 @@ repeat: ++fmt; /* this also skips first '%' */ switch (*fmt) { - case '-': flags |= LEFT; goto repeat; - case '+': flags |= PLUS; goto repeat; - case ' ': flags |= SPACE; goto repeat; - case '#': flags |= SPECIAL; goto repeat; - case '0': flags |= ZEROPAD; goto repeat; - } + case '-': flags |= LEFT; goto repeat; + case '+': flags |= PLUS; goto repeat; + case ' ': flags |= SPACE; goto repeat; + case '#': flags |= SPECIAL; goto repeat; + case '0': flags |= ZEROPAD; goto repeat; + }

/* get field width */ field_width = -1;

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

build bot (Jenkins) (Code Review)

7 Jan 7 Jan

7:16 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/*: Use same indents for switch/case ......................................................................

Patch Set 1:

(5 comments)

https://review.coreboot.org/c/coreboot/+/49204/1/src/console/vtxprintf.c File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/1/src/console/vtxprintf.c@130 PS1, Line 130: case '-': flags |= LEFT; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/1/src/console/vtxprintf.c@131 PS1, Line 131: case '+': flags |= PLUS; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/1/src/console/vtxprintf.c@132 PS1, Line 132: case ' ': flags |= SPACE; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/1/src/console/vtxprintf.c@133 PS1, Line 133: case '#': flags |= SPECIAL; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/1/src/console/vtxprintf.c@134 PS1, Line 134: case '0': flags |= ZEROPAD; goto repeat; trailing statements should be on next line

Felix Singer (Code Review)

7:32 a.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49204

to look at the new patch set (#2).

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

console/vtxprintf.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/console/vtxprintf.c 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/49204/2

Angel Pons (Code Review)

5:13 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 2: Code-Review+2

Kyösti Mälkki (Code Review)

5:36 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 2:

(1 comment)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/da12d968_a3380dc7 PS2, Line 128: ++fmt; /* this also skips first '%' */ Seems like a one too many tab to me.

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 16:36:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

5:53 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 2:

(1 comment)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/a9204ce2_d5c31905 PS2, Line 128: ++fmt; /* this also skips first '%' */

...

Seems like a one too many tab to me.

Wow, this has been like this for over 15 years.

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 16:53:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Nico Huber (Code Review)

9:49 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 2:

(1 comment)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/f0ab8371_95b05d80 PS2, Line 134: case '0': flags |= ZEROPAD; goto repeat; TBH, in such cases where the terminating statement (break/continue/goto/ return) is on the same line, I prefer to indent the case line. I would be very angry if somebody "fixes" my code like that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 20:49:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

9:52 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/262b872c_129f9eea PS2, Line 134: case '0': flags |= ZEROPAD; goto repeat;

...

TBH, in such cases where the terminating statement (break/continue/goto/ […]

Yeah, I don't consider this an improvement, but I think our coding style doesn't capture this syntax. I would happily +2 a revert of this change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 20:52:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

9:59 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 2:

(1 comment)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/a5c7ef6c_ae4050cd PS2, Line 134: case '0': flags |= ZEROPAD; goto repeat;

...

Yeah, I don't consider this an improvement, but I think our coding style doesn't capture this syntax […]

That's the problem, right? If we have reasons to +2 either direction, we risk to walk in circles :D

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Thu, 07 Jan 2021 20:59:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

8 Jan 8 Jan

8:11 a.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 3:

(5 comments)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/0d4f3c39_ff5eec5d PS3, Line 130: case '-': flags |= LEFT; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/afe41c6e_a210f185 PS3, Line 131: case '+': flags |= PLUS; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/9515ce4c_bac72b61 PS3, Line 132: case ' ': flags |= SPACE; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/e7deee2f_193609f6 PS3, Line 133: case '#': flags |= SPECIAL; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/11a43b34_b496e2b5 PS3, Line 134: case '0': flags |= ZEROPAD; goto repeat; trailing statements should be on next line

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 08 Jan 2021 07:11:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

10:51 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 4:

(5 comments)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/30186d80_c3e55fa0 PS4, Line 130: case '-': flags |= LEFT; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/11cbab5d_8de488e7 PS4, Line 131: case '+': flags |= PLUS; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/e4b7a8cb_99733dfe PS4, Line 132: case ' ': flags |= SPACE; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/0ab40a0d_28e06767 PS4, Line 133: case '#': flags |= SPECIAL; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/9f6b6bc9_94e7eff0 PS4, Line 134: case '0': flags |= ZEROPAD; goto repeat; trailing statements should be on next line

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 08 Jan 2021 21:51:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9 Jan 9 Jan

2:51 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 5:

(5 comments)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/e73a2c4c_b55c00b0 PS5, Line 130: case '-': flags |= LEFT; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/efb4d050_2eb66774 PS5, Line 131: case '+': flags |= PLUS; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/d605bf21_635edabb PS5, Line 132: case ' ': flags |= SPACE; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/14440397_b37e87ad PS5, Line 133: case '#': flags |= SPECIAL; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/52e57c84_9c8531bb PS5, Line 134: case '0': flags |= ZEROPAD; goto repeat; trailing statements should be on next line

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sat, 09 Jan 2021 13:51:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

4:10 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49204

to look at the new patch set (#6).

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

console/vtxprintf.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/console/vtxprintf.c 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/49204/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

4:24 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 6:

(5 comments)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/c413934f_eda1399d PS6, Line 130: case '-': flags |= LEFT; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/f0829fa8_d9c494f1 PS6, Line 131: case '+': flags |= PLUS; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/49523957_b425bfaa PS6, Line 132: case ' ': flags |= SPACE; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/bde33d21_f56dcff3 PS6, Line 133: case '#': flags |= SPECIAL; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/7db977c9_16ad820d PS6, Line 134: case '0': flags |= ZEROPAD; goto repeat; trailing statements should be on next line

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sat, 09 Jan 2021 15:24:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

5:22 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49204

to look at the new patch set (#7).

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

console/vtxprintf.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/console/vtxprintf.c 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/49204/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

5:22 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 7:

(5 comments)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/53dd3245_21a25ee5 PS7, Line 130: case '-': flags |= LEFT; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/f7c7fd07_8a47df23 PS7, Line 131: case '+': flags |= PLUS; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/ebdef92a_b6f1845c PS7, Line 132: case ' ': flags |= SPACE; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/a31ae647_e7105767 PS7, Line 133: case '#': flags |= SPECIAL; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/1a060bba_0dbc802f PS7, Line 134: case '0': flags |= ZEROPAD; goto repeat; trailing statements should be on next line

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sat, 09 Jan 2021 16:22:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

5:23 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49204

to look at the new patch set (#8).

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

console/vtxprintf.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/console/vtxprintf.c 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/49204/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

5:23 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 8:

(5 comments)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/24428d9d_cbb9d8dd PS8, Line 130: case '-': flags |= LEFT; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/044449f4_80326900 PS8, Line 131: case '+': flags |= PLUS; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/42ebc74a_3ac8631b PS8, Line 132: case ' ': flags |= SPACE; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/83395054_53e115f3 PS8, Line 133: case '#': flags |= SPECIAL; goto repeat; trailing statements should be on next line

https://review.coreboot.org/c/coreboot/+/49204/comment/7f9771ca_6c42af27 PS8, Line 134: case '0': flags |= ZEROPAD; goto repeat; trailing statements should be on next line

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sat, 09 Jan 2021 16:23:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

22 Apr 22 Apr

8:09 a.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 8:

(1 comment)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/206bb9cc_ca666f12 PS2, Line 134: case '0': flags |= ZEROPAD; goto repeat;

...

That's the problem, right? If we have reasons to +2 either direction, […]

So, what's the conclusion here? Running in circles or not?

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Thu, 22 Apr 2021 06:09:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Nico Huber (Code Review)

12:29 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 8:

(1 comment)

File src/console/vtxprintf.c:

https://review.coreboot.org/c/coreboot/+/49204/comment/25aee243_8e6db596 PS2, Line 134: case '0': flags |= ZEROPAD; goto repeat;

...

So, what's the conclusion here? Running in circles or not?

I'd prefer to try to update our `coding_style.md`.

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Thu, 22 Apr 2021 10:29:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

12:58 p.m.

New subject: Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49204 )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Patch Set 8: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 22 Apr 2021 10:58:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

10 Jun 10 Jun

5:13 a.m.

New subject: [S] Change in coreboot[master]: console/vtxprintf.c: Use same indents for switch/case

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49204?usp=email )

Change subject: console/vtxprintf.c: Use same indents for switch/case ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/49204?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13c723c335d18bbdd2dcb041f44b187df6c5d728 Gerrit-Change-Number: 49204 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer service+coreboot-gerrit@felixsinger.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: abandon

532

days inactive

1416

days old

coreboot-gerrit@coreboot.org

21 comments

6 participants

tags (0)

participants (6)

Angel Pons (Code Review)
build bot (Jenkins) (Code Review)
Felix Singer (Code Review)
Kyösti Mälkki (Code Review)
Nico Huber (Code Review)
Stefan Reinauer (Code Review)