Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32387
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
mb/google/octopus/variants/bloog: Add goodix touchscreen support
Add goodix touchscreen support
BUG=none BRANCH=octopus TEST=emerge-octopus coreboot and verify that touchscreen works on bloog.
Change-Id: I0b3b481ca806b6452d67ace5dfe53f12a14ac3be Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bloog/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32387/1
diff --git a/src/mainboard/google/octopus/variants/bloog/overridetree.cb b/src/mainboard/google/octopus/variants/bloog/overridetree.cb index 20b5dd3..21a10f7 100644 --- a/src/mainboard/google/octopus/variants/bloog/overridetree.cb +++ b/src/mainboard/google/octopus/variants/bloog/overridetree.cb @@ -101,6 +101,20 @@ register "has_power_resource" = "1" device i2c 10 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.has_power_resource" = "1" + register "generic.enable_delay_ms" = "10" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end end # - I2C 7 end
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
Patch Set 1:
Hi Furquan, Can you help review on this? Thanks
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32387/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/overridetree.cb:
https://review.coreboot.org/#/c/32387/1/src/mainboard/google/octopus/variant... PS1, Line 110: 120 Is that required as per the datasheet?
https://review.coreboot.org/#/c/32387/1/src/mainboard/google/octopus/variant... PS1, Line 114: register "generic.enable_delay_ms" = "10" Is that really required? Enable + reset delay seems to be 130ms which will add to resume time.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
Patch Set 1:
Patch Set 1:
(2 comments)
Hi Furquan, The touchscreen vendor respond the timing measure result can meet their spec. Thanks
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
(2 comments)
Hi Furquan, The touchscreen vendor respond the timing measure result can meet their spec. Thanks
Can you please raise a bug for this and attach the datasheet there that specifies the timing requirements? Thanks!
Hello Karthik Ramasubramanian, Wisley Chen, Justin TerAvest, Paul Menzel, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32387
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
mb/google/octopus/variants/bloog: Add goodix touchscreen support
Add goodix touchscreen support
BUG=b:131082228 BRANCH=octopus TEST=emerge-octopus coreboot and verify that touchscreen works on bloog.
Change-Id: I0b3b481ca806b6452d67ace5dfe53f12a14ac3be Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bloog/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/32387/2
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
Patch Set 2:
Hi Furquan, The issue tracker link. https://partnerissuetracker.corp.google.com/issues/131082228
Thanks
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
Patch Set 2: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
Patch Set 2: Code-Review+2
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
Patch Set 2:
Hi Furquan, Can you help merge the change? Thank you
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support ......................................................................
mb/google/octopus/variants/bloog: Add goodix touchscreen support
Add goodix touchscreen support
BUG=b:131082228 BRANCH=octopus TEST=emerge-octopus coreboot and verify that touchscreen works on bloog.
Change-Id: I0b3b481ca806b6452d67ace5dfe53f12a14ac3be Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32387 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/octopus/variants/bloog/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/bloog/overridetree.cb b/src/mainboard/google/octopus/variants/bloog/overridetree.cb index 20b5dd3..21a10f7 100644 --- a/src/mainboard/google/octopus/variants/bloog/overridetree.cb +++ b/src/mainboard/google/octopus/variants/bloog/overridetree.cb @@ -101,6 +101,20 @@ register "has_power_resource" = "1" device i2c 10 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.has_power_resource" = "1" + register "generic.enable_delay_ms" = "10" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end end # - I2C 7 end