Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )
Change subject: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/#/c/30021/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30021/8//COMMIT_MSG@38 PS8, Line 38: - Detecting the model of Soldered RAM at runtime, and loading the
That should be mentioned in the Documentation !
Ack
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... File src/mainboard/lenovo/t430s/variants/t431s/romstage.c:
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... PS8, Line 37: pci
No need to write it here, only if you want to access io range 0x6a0 in romstage.
Ack
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... File src/mainboard/lenovo/t430s/variants/t431s/smihandler.c:
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... PS8, Line 25:
Ack
Ack
-
Bill XIE (Code Review)