Change in coreboot[master]: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Martin Roth (Code Review)

9 Feb 2020 9 Feb '20

11:27 p.m.

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38810 )

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint

We haven't been able to update IASL in 8 months because of this conflict. Ignoring it doesn't make things any worse than they are now.

Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e --- M Makefile.inc 1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38810/1

diff --git a/Makefile.inc b/Makefile.inc index 4ca173b..584fa34 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -261,7 +261,16 @@ # Redundant offset remarks are not useful in any way and are masking useful # ones that might indicate an issue so it is better to hide them. REDUNDANT_OFFSET_REMARK = 2158 +# Ignore _HID & _ADR coexisting in Intel Lynxpoint and Broadwell ASL code. +# See cb:38803 & cb:38802 +# "Multiple types (Device object requires either a _HID or _ADR, but not both)" +MULTIPLE_TYPES_WARNING = 3073 + +ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT)$(SOC_INTEL_BROADWELL),y) +IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) -vw $(MULTIPLE_TYPES_WARNING) +else IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) +endif

define asl_template $(CONFIG_CBFS_PREFIX)/$(1).aml-file = $(obj)/$(1).aml

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Martin Roth (Code Review)

9 Feb 9 Feb

11:37 p.m.

Hello Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38810

to look at the new patch set (#2).

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint

We haven't been able to update IASL in 8 months because of this conflict. Ignoring it doesn't make things any worse than they are now.

Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e --- M Makefile.inc 1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38810/2

Angel Pons (Code Review)

10 Feb 10 Feb

12:23 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38810 )

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38810/2/Makefile.inc File Makefile.inc:

https://review.coreboot.org/c/coreboot/+/38810/2/Makefile.inc@265 PS2, Line 265: # See cb:38803 & cb:38802 I dropped these changes, they were an ugly kludge.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38810 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 09 Feb 2020 23:23:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

12:50 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38810 )

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38810/2/Makefile.inc File Makefile.inc:

https://review.coreboot.org/c/coreboot/+/38810/2/Makefile.inc@265 PS2, Line 265: # See cb:38803 & cb:38802

...

I dropped these changes, they were an ugly kludge.

I just wanted some examples to put here so that people could see where the issues were. If there are better patches to show as where the issue is, I'd be happy to change them.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38810 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 09 Feb 2020 23:50:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:13 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38810 )

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38810 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Feb 2020 00:13:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

1:29 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38810 )

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38810/2/Makefile.inc File Makefile.inc:

https://review.coreboot.org/c/coreboot/+/38810/2/Makefile.inc@265 PS2, Line 265: # See cb:38803 & cb:38802

...

I just wanted some examples to put here so that people could see where the issues were. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/38810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38810 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Feb 2020 00:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Nico Huber (Code Review)

11:11 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38810 )

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/38810/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38810/2//COMMIT_MSG@9 PS2, Line 9: We haven't been able to update IASL in 8 months because of this : conflict. Rather because people were bullied (IIRC, there were even threats to remove boards, as if this bullshit warning would weigh as much as no-CAR-global-migration). If review comments had been honored instead of pushing the same (already reverted) broken patches again and again, we could have updated it months ago.

https://review.coreboot.org/c/coreboot/+/38810/2//COMMIT_MSG@10 PS2, Line 10: Ignoring it doesn't make things any worse than they are now. That seems highly subjective. By disabling it for specific cases, you imply that the warning is reasonable otherwise. Which was never discussed nor has anybody explained its benefits.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38810 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Feb 2020 10:11:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:31 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38810 )

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38810 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Feb 2020 12:31:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11 Feb 11 Feb

8:49 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38810 )

Change subject: Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint ......................................................................

Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint

We haven't been able to update IASL in 8 months because of this conflict. Ignoring it doesn't make things any worse than they are now.

Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Reviewed-on: https://review.coreboot.org/c/coreboot/+/38810 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M Makefile.inc 1 file changed, 9 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved

diff --git a/Makefile.inc b/Makefile.inc index 4ca173b..2690e8f 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -261,7 +261,16 @@ # Redundant offset remarks are not useful in any way and are masking useful # ones that might indicate an issue so it is better to hide them. REDUNDANT_OFFSET_REMARK = 2158 +# Ignore _HID & _ADR coexisting in Intel Lynxpoint and Broadwell ASL code. +# See cb:38803 & cb:38802 +# "Multiple types (Device object requires either a _HID or _ADR, but not both)" +MULTIPLE_TYPES_WARNING = 3073 + +ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT)$(CONFIG_SOC_INTEL_BROADWELL),y) +IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) -vw $(MULTIPLE_TYPES_WARNING) +else IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) +endif

define asl_template $(CONFIG_CBFS_PREFIX)/$(1).aml-file = $(obj)/$(1).aml

-- To view, visit https://review.coreboot.org/c/coreboot/+/38810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Gerrit-Change-Number: 38810 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1904

days inactive

1906

days old

coreboot-gerrit@coreboot.org

8 comments

6 participants

tags (0)

participants (6)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Martin Roth (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)