Change in coreboot[master]: soc/intel/common/block/lpc: Add function to return fixed io decode ra...
Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38745 )
Change subject: soc/intel/common/block/lpc: Add function to return fixed io decode ranges ......................................................................
soc/intel/common/block/lpc: Add function to return fixed io decode ranges
Add function to return the fixed io decode ranges contained in register 0x80 of the LPC interface.
BUG=N/A TEST=build
Change-Id: Ie46d7c9d7a399a8489c030d906f75ba61db19cc4 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/soc/intel/common/block/include/intelblocks/lpc_lib.h M src/soc/intel/common/block/lpc/lpc_lib.c 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/38745/1
diff --git a/src/soc/intel/common/block/include/intelblocks/lpc_lib.h b/src/soc/intel/common/block/include/intelblocks/lpc_lib.h index f77b8d5..cf6d8e9 100644 --- a/src/soc/intel/common/block/include/intelblocks/lpc_lib.h +++ b/src/soc/intel/common/block/include/intelblocks/lpc_lib.h @@ -70,6 +70,8 @@ * Output:I/O Enable Bits */ uint16_t lpc_enable_fixed_io_ranges(uint16_t io_enables); +/* Return the current decode settings */ +uint16_t lpc_get_fixed_io_decode(void); /* Open a generic IO window to the LPC bus. Four windows are available. */ void lpc_open_pmio_window(uint16_t base, uint16_t size); /* Close all generic IO windows to the LPC bus. */ diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c index bc89e4c..3ad2176 100644 --- a/src/soc/intel/common/block/lpc/lpc_lib.c +++ b/src/soc/intel/common/block/lpc/lpc_lib.c @@ -37,6 +37,11 @@ return io_enables; }
+uint16_t lpc_get_fixed_io_decode(void) +{ + return pci_read_config16(PCH_DEV_LPC, LPC_IO_DECODE); +} + /* * Find the first unused IO window. * Returns -1 if not found, 0 for reg 0x84, 1 for reg 0x88 ...
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38745 )
Change subject: soc/intel/common/block/lpc: Add function to return fixed io decode ranges ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38745/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38745/2//COMMIT_MSG@7 PS2, Line 7: soc/intel/common/block/lpc: Add function to return fixed io decode ranges Change title into Add lpc_get_fixed_io_decode()
Hello Patrick Rudolph, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38745
to look at the new patch set (#3).
Change subject: soc/intel/common/block/lpc: Add lpc_get_fixed_io_decode ......................................................................
soc/intel/common/block/lpc: Add lpc_get_fixed_io_decode
Add function to return the fixed io decode ranges contained in register 0x80 of the LPC interface.
BUG=N/A TEST=build
Change-Id: Ie46d7c9d7a399a8489c030d906f75ba61db19cc4 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/soc/intel/common/block/include/intelblocks/lpc_lib.h M src/soc/intel/common/block/lpc/lpc_lib.c 2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/38745/3
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38745 )
Change subject: soc/intel/common/block/lpc: Add lpc_get_fixed_io_decode ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38745/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38745/2//COMMIT_MSG@7 PS2, Line 7: soc/intel/common/block/lpc: Add function to return fixed io decode ranges
Change title into Add lpc_get_fixed_io_decode()
Done
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38745 )
Change subject: soc/intel/common/block/lpc: Add lpc_get_fixed_io_decode ......................................................................
Patch Set 3: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38745 )
Change subject: soc/intel/common/block/lpc: Add lpc_get_fixed_io_decode ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38745 )
Change subject: soc/intel/common/block/lpc: Add lpc_get_fixed_io_decode ......................................................................
soc/intel/common/block/lpc: Add lpc_get_fixed_io_decode
Add function to return the fixed io decode ranges contained in register 0x80 of the LPC interface.
BUG=N/A TEST=build
Change-Id: Ie46d7c9d7a399a8489c030d906f75ba61db19cc4 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38745 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/include/intelblocks/lpc_lib.h M src/soc/intel/common/block/lpc/lpc_lib.c 2 files changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved
diff --git a/src/soc/intel/common/block/include/intelblocks/lpc_lib.h b/src/soc/intel/common/block/include/intelblocks/lpc_lib.h index f77b8d5..cf6d8e9 100644 --- a/src/soc/intel/common/block/include/intelblocks/lpc_lib.h +++ b/src/soc/intel/common/block/include/intelblocks/lpc_lib.h @@ -70,6 +70,8 @@ * Output:I/O Enable Bits */ uint16_t lpc_enable_fixed_io_ranges(uint16_t io_enables); +/* Return the current decode settings */ +uint16_t lpc_get_fixed_io_decode(void); /* Open a generic IO window to the LPC bus. Four windows are available. */ void lpc_open_pmio_window(uint16_t base, uint16_t size); /* Close all generic IO windows to the LPC bus. */ diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c index bc89e4c..3ad2176 100644 --- a/src/soc/intel/common/block/lpc/lpc_lib.c +++ b/src/soc/intel/common/block/lpc/lpc_lib.c @@ -37,6 +37,11 @@ return io_enables; }
+uint16_t lpc_get_fixed_io_decode(void) +{ + return pci_read_config16(PCH_DEV_LPC, LPC_IO_DECODE); +} + /* * Find the first unused IO window. * Returns -1 if not found, 0 for reg 0x84, 1 for reg 0x88 ...
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)