Change in libgfxinit[master]: gma: Give GM45 its own designation (separate from G45) - coreboot-gerrit

4 Oct 2019


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35711 )
Change subject: gma: Give GM45 its own designation (separate from G45)
......................................................................
Patch Set 3:
...
Patch Set 3:
...
Patch Set 3: Code-Review+2
My main concern with this change is that G45 and GM45 are dangerously similar names.
Maybe use Eaglelake and Cantiga instead?
I'd keep the same names as Linux.
Ack
-- 
To view, visit https://review.coreboot.org/c/libgfxinit/+/35711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I99bbd0582a03a9e2806ef2ebf63e466ec40133b3
Gerrit-Change-Number: 35711
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 10:29:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment