HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45865 )
Change subject: mb/getac/p470/acpi/ec.asl: Remove duplicated code ......................................................................
mb/getac/p470/acpi/ec.asl: Remove duplicated code
"If(And(RFDV, 0x02)) {Or(Local0, 0x02, Local0)}" is duplicated.
Change-Id: I91698fb308cd37c65aa65e563bcd88743097f56c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/acpi/ec.asl 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/45865/1
diff --git a/src/mainboard/getac/p470/acpi/ec.asl b/src/mainboard/getac/p470/acpi/ec.asl index 90ae644..5c0f4d8 100644 --- a/src/mainboard/getac/p470/acpi/ec.asl +++ b/src/mainboard/getac/p470/acpi/ec.asl @@ -469,9 +469,6 @@ If(And(RFDV, 0x02)) { Or(Local0, 0x02, Local0) } - If(And(RFDV, 0x02)) { - Or(Local0, 0x02, Local0) - } If(And(RFDV, 0x04)) { Or(Local0, 0x04, Local0) }
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45865 )
Change subject: mb/getac/p470/acpi/ec.asl: Remove duplicated code ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45865/1/src/mainboard/getac/p470/ac... File src/mainboard/getac/p470/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/45865/1/src/mainboard/getac/p470/ac... PS1, Line 469: If(And(RFDV, 0x02)) { : Or(Local0, 0x02, Local0) : } : If(And(RFDV, 0x02)) { : Or(Local0, 0x02, Local0) : } same
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45865 )
Change subject: mb/getac/p470/acpi/ec.asl: Remove duplicated code ......................................................................
Patch Set 1: Code-Review+1
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45865 )
Change subject: mb/getac/p470/acpi/ec.asl: Remove duplicated code ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45865 )
Change subject: mb/getac/p470/acpi/ec.asl: Remove duplicated code ......................................................................
mb/getac/p470/acpi/ec.asl: Remove duplicated code
"If(And(RFDV, 0x02)) {Or(Local0, 0x02, Local0)}" is duplicated.
Change-Id: I91698fb308cd37c65aa65e563bcd88743097f56c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45865 Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/getac/p470/acpi/ec.asl 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/mainboard/getac/p470/acpi/ec.asl b/src/mainboard/getac/p470/acpi/ec.asl index 90ae644..5c0f4d8 100644 --- a/src/mainboard/getac/p470/acpi/ec.asl +++ b/src/mainboard/getac/p470/acpi/ec.asl @@ -469,9 +469,6 @@ If(And(RFDV, 0x02)) { Or(Local0, 0x02, Local0) } - If(And(RFDV, 0x02)) { - Or(Local0, 0x02, Local0) - } If(And(RFDV, 0x04)) { Or(Local0, 0x04, Local0) }
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)