Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29104 )
Change subject: sdm845: Port I2C driver ......................................................................
Patch Set 33:
(1 comment)
https://review.coreboot.org/#/c/29104/33/src/soc/qualcomm/sdm845/include/soc... File src/soc/qualcomm/sdm845/include/soc/qcom_qup_se.h:
https://review.coreboot.org/#/c/29104/33/src/soc/qualcomm/sdm845/include/soc... PS33, Line 217: }; This definition still needs to move into the SPI patch, otherwise that one can't compile on its own.