Attention is currently required from: Marshall Dawson, Matt DeVillier.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/84837?usp=email )
Change subject: drivers/spi: add RPMC support ......................................................................
Patch Set 10:
(3 comments)
File src/drivers/spi/spi_flash_rpmc.c:
https://review.coreboot.org/c/coreboot/+/84837/comment/e1f73003_c0b776b2?usp... : PS9, Line 250: memcpy(&buf[8], signature, SPI_RPMC_SIG_LEN);
Could consider using [4+SPI_RPMC_KEY_DATA_LEN], similar to line 218.
good point; updated the code
https://review.coreboot.org/c/coreboot/+/84837/comment/348d3f2b_ed8e49ae?usp... : PS9, Line 281: memcpy(&buf[8], signature, SPI_RPMC_SIG_LEN);
similar
Done
https://review.coreboot.org/c/coreboot/+/84837/comment/76f30267_16e7e0ed?usp... : PS9, Line 314: memcpy(&buf[16], signature, SPI_RPMC_SIG_LEN);
similar
Done