Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46460 )
Change subject: soc/intel: drop unneeded ISST configuration code
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Looks good to me. But maybe wait a little for other
people to chime in.
https://review.coreboot.org/c/coreboot/+/46460/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46460/6//COMMIT_MSG@16
PS6, Line 16: OS to not enable HWP if that is desired.
I confirmed this on CML-U (Clevo L141CU), KBL-H (Smc X11SSM-F) and SKL-U (Acer ES1-572) by printing […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I952720cf1de78b00b1bf749f10e9c0acd6ecb6b7
Gerrit-Change-Number: 46460
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Oct 2020 21:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment