Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, agogo.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )
Change subject: soc/mediatek/mt8196: Initialize MCUPM
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File src/soc/mediatek/mt8196/mcupm.c:
https://review.coreboot.org/c/coreboot/+/85888/comment/5b62fc61_253a0d8e?usp... :
PS6, Line 21: "[EB_SPMC] Polling MCU_PORT_SET_R0_0 timeout, %#x\n",
I meant the limit (which equals the tries). […]
I think the log is fine as long as MTK thinks the information is enough for them to debug.
The comment already mentioned that is W1C (write 1 clear) register.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I223f245d384f32d54f6170a28b29573638f77296
Gerrit-Change-Number: 85888
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: agogo
agogo.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: agogo
agogo.huang@mediatek.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 16 Jan 2025 15:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: agogo
agogo.huang@mediatek.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Yidi Lin
yidilin@google.com