[L] Change in coreboot[master]: drivers/soundwire/max98363: Support MAX98363 SoundWire device - coreboot-gerrit

27 Feb 2023


      Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Kapil Porwal, Dinesh Gehlot.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73278 )
Change subject: drivers/soundwire/max98363: Support MAX98363 SoundWire device
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/soundwire/max98363/max98363.c:
https://review.coreboot.org/c/coreboot/+/73278/comment/d6a91497_5f180682 
PS2, Line 119: static char name[5];
Use malloc and set config->name pointer to it? Using static for a longer scope is not nice, as it would break if you have 2 of such chips the return pointer becomes invalid.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/73278
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie56109d615759e3e5e32782c8782cb2f47014ec4
Gerrit-Change-Number: 73278
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Eran Mitrani mitrani@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Comment-Date: Mon, 27 Feb 2023 08:49:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment