Attention is currently required from: Angel Pons, Federico Amedeo Izzo.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email )
Change subject: mb/aoostar: Add AOOSTAR R1 (WTR_R1) ......................................................................
Patch Set 10:
(8 comments)
File src/mainboard/aoostar/wtr_r1/devicetree.cb:
PS9:
Missing SPDX license identifier.
Done
https://review.coreboot.org/c/coreboot/+/82010/comment/568f6de2_7e95f947 : PS9, Line 11: # FSP configuration
Remove superfluous comment
Done
https://review.coreboot.org/c/coreboot/+/82010/comment/d08ff66c_185d624a : PS9, Line 13: # Sagv Configuration
Same
Done
https://review.coreboot.org/c/coreboot/+/82010/comment/bd19f2c1_17c9f2a1 : PS9, Line 16: # Enable DPTF
Same
Done
https://review.coreboot.org/c/coreboot/+/82010/comment/860790d2_423fdfa8 : PS9, Line 21: # Intel Common SoC Config
Same
Done
https://review.coreboot.org/c/coreboot/+/82010/comment/ad9f767e_bfb83a38 : PS9, Line 74: register "usb2_ports[6]" = "USB2_PORT_EMPTY"
Not needed, remove.
Done
https://review.coreboot.org/c/coreboot/+/82010/comment/a96522fa_c9c023c7 : PS9, Line 79: register "usb3_ports[2]" = "USB3_PORT_EMPTY" : register "usb3_ports[3]" = "USB3_PORT_EMPTY" : register "usb3_ports[4]" = "USB3_PORT_EMPTY"
Not needed, remove.
Done
https://review.coreboot.org/c/coreboot/+/82010/comment/2abac3de_828403c0 : PS9, Line 85: register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC3)" # USB3/2 Type A upper
Move to tcss_xhci PCI device
Done